All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcus Wolf <marcus.wolf@smarthome-wolf.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Simon Sandström" <simon@nikanor.nu>,
	gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	linux@Wolf-Entwicklungen.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h
Date: Wed, 6 Dec 2017 12:31:31 +0200	[thread overview]
Message-ID: <2ebc402d-f2af-40cb-7aa2-c9f062a0dd3d@smarthome-wolf.de> (raw)
In-Reply-To: <20171206100833.3ficksukt6xaazl4@mwanda>



Am 06.12.2017 um 12:23 schrieb Dan Carpenter:
> On Wed, Dec 06, 2017 at 11:46:41AM +0200, Marcus Wolf wrote:
>>> diff --git a/drivers/staging/pi433/rf69_enum.h b/drivers/staging/pi433/rf69_enum.h
>>> index babe597e2ec6..5247e9269de9 100644
>>> --- a/drivers/staging/pi433/rf69_enum.h
>>> +++ b/drivers/staging/pi433/rf69_enum.h
>>> @@ -18,9 +18,9 @@
>>>    #ifndef RF69_ENUM_H
>>>    #define RF69_ENUM_H
>>> -enum optionOnOff {
>>> -	optionOff,
>>> -	optionOn
>>> +enum option_on_off {
>>> +	OPTION_OFF,
>>> +	OPTION_ON
>>>    };
>>>    enum mode {
>>>
>>
>> Hi Simon,
>>
>> nice work.
>>
>> Thank you very much for all the style fixes :-)
>>
> 
> 
> Wow...  This was the one patch I thought was going to sink this
> patchset... 

I don't get that. What do you mean?

> Isn't enum optionOnOff part of the userspace headers?
> 
> I thought we weren't allowed to change that.

All enums are for user space (or inteded to be used in userspace in 
future). Didn't introduce enums for internal use.

Reagrds,
Marcus

  reply	other threads:[~2017-12-06 10:31 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 22:08 [PATCH v2 00/11] Fix indentation and CamelCase issue in staging/pi433 Simon Sandström
2017-12-05 22:08 ` [PATCH v2 01/11] staging: pi433: Fix indentation in rf69_enum.h Simon Sandström
2017-12-05 22:08 ` [PATCH v2 02/11] staging: pi433: Capitalize constant definitions Simon Sandström
2017-12-05 22:08 ` [PATCH v2 03/11] staging: pi433: Rename variable in struct pi433_rx_cfg Simon Sandström
2017-12-05 22:08 ` [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h Simon Sandström
2017-12-06  9:46   ` Marcus Wolf
2017-12-06 10:23     ` Dan Carpenter
2017-12-06 10:31       ` Marcus Wolf [this message]
2017-12-06 10:44         ` Dan Carpenter
2017-12-06 11:07           ` Marcus Wolf
2017-12-06 19:57           ` Simon Sandström
2017-12-06 22:17             ` Marcus Wolf
2017-12-07  9:41               ` Dan Carpenter
2017-12-05 22:08 ` [PATCH v2 05/11] staging: pi433: Rename enum modShaping " Simon Sandström
2017-12-05 22:08 ` [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions Simon Sandström
2017-12-06  9:05   ` Marcus Wolf
2017-12-06  9:37     ` Dan Carpenter
2017-12-06 10:07       ` Marcus Wolf
2017-12-06 15:11         ` Greg KH
2017-12-06 10:36       ` Marcus Wolf
2017-12-06 15:16   ` Greg KH
2017-12-06 20:27     ` Simon Sandström
2017-12-05 22:08 ` [PATCH v2 07/11] staging: pi433: Split rf69_set_sync_enabled " Simon Sandström
2017-12-05 22:08 ` [PATCH v2 08/11] staging: pi433: Remove enum data_mode Simon Sandström
2017-12-06  9:11   ` Marcus Wolf
2017-12-06 12:47     ` Dan Carpenter
2017-12-07  9:47       ` staging: pi433: Plans from Smarthome-Wolf Marcus Wolf
2017-12-05 22:08 ` [PATCH v2 09/11] staging: pi433: Combine all rf69_set_amplifier_x() Simon Sandström
2017-12-06  9:43   ` Marcus Wolf
2017-12-05 22:08 ` [PATCH v2 10/11] staging: pi433: Move enum option_on_off to pi433_if.h Simon Sandström
2017-12-05 22:08 ` [PATCH v2 11/11] staging: pi433: Remove SET_CHECKED usage from pi433_probe Simon Sandström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ebc402d-f2af-40cb-7aa2-c9f062a0dd3d@smarthome-wolf.de \
    --to=marcus.wolf@smarthome-wolf.de \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@Wolf-Entwicklungen.de \
    --cc=simon@nikanor.nu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.