From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Phil Reid <preid@electromag.com.au>,
mika.westerberg@linux.intel.com, wsa@the-dreams.de,
tim@krieglstein.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v3 1/4] i2c: Switch to using gpiod interface for gpio bus recovery
Date: Thu, 28 Sep 2017 13:54:55 +0300 [thread overview]
Message-ID: <2ecc500b-42ec-8f30-b8cf-fd646eaaa198@linux.intel.com> (raw)
In-Reply-To: <1506595483.16112.137.camel@linux.intel.com>
On 09/28/2017 01:44 PM, Andy Shevchenko wrote:
>> interface. This will allow individual driver to be updated and tested
>> individual to switch to using the gpiod interface.
>
>> int scl_gpio;
>> int sda_gpio;
>> + struct gpio_desc *scl_gpiod;
>> + struct gpio_desc *sda_gpiod;
>
> I think we even could get rid of plain integers completely.
> In case some call needs it we can derive it still from the descriptor.
>
I guess it's still worth to split that into multiple patches and those
driver conversion and integer removal can be follow up patches somewhere
in the future?
--
Jarkko
next prev parent reply other threads:[~2017-09-28 10:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 6:17 [PATCH v3 0/4] i2c: designware: add i2c gpio recovery option Phil Reid
2017-08-30 6:17 ` [PATCH v3 1/4] i2c: Switch to using gpiod interface for gpio bus recovery Phil Reid
2017-09-28 10:44 ` Andy Shevchenko
2017-09-28 10:54 ` Jarkko Nikula [this message]
2017-09-28 10:58 ` Andy Shevchenko
2017-09-29 6:59 ` Phil Reid
2017-09-29 11:48 ` Andy Shevchenko
2017-08-30 6:17 ` [PATCH v3 2/4] i2c: designware: move i2c_dw_plat_prepare_clk to common Phil Reid
2017-09-28 13:01 ` Jarkko Nikula
2017-08-30 6:17 ` [PATCH v3 3/4] i2c: designware: rename i2c_dw_plat_prepare_clk to i2c_dw_prepare_clk Phil Reid
2017-09-28 13:01 ` Jarkko Nikula
2017-08-30 6:17 ` [PATCH v3 4/4] i2c: designware: add i2c gpio recovery option Phil Reid
2017-09-28 10:58 ` Andy Shevchenko
2017-09-29 7:00 ` Phil Reid
2017-09-28 13:21 ` Jarkko Nikula
2017-10-06 5:56 ` Phil Reid
2017-09-28 7:37 ` [PATCH v3 0/4] " Phil Reid
2017-09-28 9:55 ` Jarkko Nikula
2017-09-28 10:55 ` Andy Shevchenko
2017-10-04 9:41 ` Ferry Toth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ecc500b-42ec-8f30-b8cf-fd646eaaa198@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=preid@electromag.com.au \
--cc=tim@krieglstein.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.