From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Cc: linux-renesas-soc@vger.kernel.org, Ulrich Hecht <uli@fpond.eu>
Subject: Re: [PATCH v2 02/16] dt-bindings: display: renesas: lvds: Document r8a77990 bindings
Date: Mon, 24 Sep 2018 12:36:00 +0100 [thread overview]
Message-ID: <2ed87630-2f54-6ace-30b1-5a5667911aa2@ideasonboard.com> (raw)
In-Reply-To: <20180914091046.483-3-laurent.pinchart+renesas@ideasonboard.com>
Hi Laurent,
On 14/09/18 10:10, Laurent Pinchart wrote:
> The E3 (r8a77990) supports two LVDS channels. Extend the binding to
> support them.
This commit message sounds rather like we are modifying the bindings,
rather than just adding a compatible string. I went looking for extra
changes - but I see we only need a compatible addition.
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Still, the change looks accurate to me - and at the moment I can't think
of a better description so:
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> index 5a4e379bb414..13af7e2ac7e8 100644
> --- a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> @@ -15,6 +15,7 @@ Required properties:
> - "renesas,r8a7796-lvds" for R8A7796 (R-Car M3-W) compatible LVDS encoders
> - "renesas,r8a77970-lvds" for R8A77970 (R-Car V3M) compatible LVDS encoders
> - "renesas,r8a77980-lvds" for R8A77980 (R-Car V3H) compatible LVDS encoders
> + - "renesas,r8a77990-lvds" for R8A77990 (R-Car E3) compatible LVDS encoders
> - "renesas,r8a77995-lvds" for R8A77995 (R-Car D3) compatible LVDS encoders
>
> - reg: Base address and length for the memory-mapped registers
>
--
Regards
--
Kieran
WARNING: multiple messages have this Message-ID (diff)
From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Cc: linux-renesas-soc@vger.kernel.org, Ulrich Hecht <uli@fpond.eu>
Subject: Re: [PATCH v2 02/16] dt-bindings: display: renesas: lvds: Document r8a77990 bindings
Date: Mon, 24 Sep 2018 12:36:00 +0100 [thread overview]
Message-ID: <2ed87630-2f54-6ace-30b1-5a5667911aa2@ideasonboard.com> (raw)
In-Reply-To: <20180914091046.483-3-laurent.pinchart+renesas@ideasonboard.com>
Hi Laurent,
On 14/09/18 10:10, Laurent Pinchart wrote:
> The E3 (r8a77990) supports two LVDS channels. Extend the binding to
> support them.
This commit message sounds rather like we are modifying the bindings,
rather than just adding a compatible string. I went looking for extra
changes - but I see we only need a compatible addition.
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Still, the change looks accurate to me - and at the moment I can't think
of a better description so:
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> index 5a4e379bb414..13af7e2ac7e8 100644
> --- a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> @@ -15,6 +15,7 @@ Required properties:
> - "renesas,r8a7796-lvds" for R8A7796 (R-Car M3-W) compatible LVDS encoders
> - "renesas,r8a77970-lvds" for R8A77970 (R-Car V3M) compatible LVDS encoders
> - "renesas,r8a77980-lvds" for R8A77980 (R-Car V3H) compatible LVDS encoders
> + - "renesas,r8a77990-lvds" for R8A77990 (R-Car E3) compatible LVDS encoders
> - "renesas,r8a77995-lvds" for R8A77995 (R-Car D3) compatible LVDS encoders
>
> - reg: Base address and length for the memory-mapped registers
>
--
Regards
--
Kieran
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-09-24 17:37 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 9:10 [PATCH v2 00/16] R-Car D3/E3 display support (with LVDS PLL) Laurent Pinchart
2018-09-14 9:10 ` Laurent Pinchart
2018-09-14 9:10 ` [PATCH v2 01/16] dt-bindings: display: renesas: du: Document r8a77990 bindings Laurent Pinchart
2018-09-14 9:10 ` Laurent Pinchart
2018-09-17 10:53 ` Ulrich Hecht
2018-09-17 10:53 ` Ulrich Hecht
2018-09-14 9:10 ` [PATCH v2 02/16] dt-bindings: display: renesas: lvds: " Laurent Pinchart
2018-09-14 9:10 ` Laurent Pinchart
2018-09-17 10:53 ` Ulrich Hecht
2018-09-17 10:53 ` Ulrich Hecht
2018-09-24 11:36 ` Kieran Bingham [this message]
2018-09-24 11:36 ` Kieran Bingham
2018-09-14 9:10 ` [PATCH v2 03/16] dt-bindings: display: renesas: lvds: Add EXTAL and DU_DOTCLKIN clocks Laurent Pinchart
2018-09-14 9:10 ` Laurent Pinchart
2018-09-17 10:53 ` Ulrich Hecht
2018-09-17 10:53 ` Ulrich Hecht
2018-09-24 19:04 ` Kieran Bingham
2018-09-24 19:04 ` Kieran Bingham
2018-09-14 9:10 ` [PATCH v2 04/16] drm: bridge: thc63: Restrict modes based on hardware operating frequency Laurent Pinchart
2018-09-14 9:10 ` Laurent Pinchart
2018-09-17 10:53 ` Ulrich Hecht
2018-09-17 10:53 ` Ulrich Hecht
2018-09-17 12:23 ` Laurent Pinchart
2018-09-17 12:23 ` Laurent Pinchart
2018-09-14 9:10 ` [PATCH v2 05/16] drm: rcar-du: lvds: D3/E3 support Laurent Pinchart
2018-09-14 9:10 ` Laurent Pinchart
2018-09-17 10:53 ` Ulrich Hecht
2018-09-17 10:53 ` Ulrich Hecht
2018-09-17 12:41 ` Laurent Pinchart
2018-09-17 12:41 ` Laurent Pinchart
2018-09-17 12:49 ` jacopo mondi
2018-09-17 12:49 ` jacopo mondi
2018-09-14 9:10 ` [PATCH v2 06/16] drm: rcar-du: Perform the initial CRTC setup from rcar_du_crtc_get() Laurent Pinchart
2018-09-14 9:10 ` Laurent Pinchart
2018-09-17 12:50 ` jacopo mondi
2018-09-17 12:50 ` jacopo mondi
2018-09-26 15:55 ` Ulrich Hecht
2018-09-26 15:55 ` Ulrich Hecht
2018-09-28 15:14 ` Laurent Pinchart
2018-09-28 15:14 ` Laurent Pinchart
2018-09-14 9:10 ` [PATCH v2 07/16] drm: rcar-du: Use LVDS PLL clock as dot clock when possible Laurent Pinchart
2018-09-14 9:10 ` Laurent Pinchart
2018-09-17 12:55 ` jacopo mondi
2018-09-17 12:55 ` jacopo mondi
2018-09-26 15:55 ` Ulrich Hecht
2018-09-26 15:55 ` Ulrich Hecht
2018-11-27 0:44 ` Kuninori Morimoto
2018-11-27 0:44 ` Kuninori Morimoto
2018-12-06 9:50 ` Laurent Pinchart
2018-12-06 9:50 ` Laurent Pinchart
2018-12-07 1:25 ` Kuninori Morimoto
2018-12-07 1:25 ` Kuninori Morimoto
2018-09-14 9:10 ` [PATCH v2 08/16] drm: rcar-du: Enable configurable DPAD0 routing on Gen3 Laurent Pinchart
2018-09-14 9:10 ` Laurent Pinchart
2018-09-17 12:56 ` jacopo mondi
2018-09-17 12:56 ` jacopo mondi
2018-09-26 15:55 ` Ulrich Hecht
2018-09-26 15:55 ` Ulrich Hecht
2018-09-14 9:10 ` [PATCH v2 09/16] drm: rcar-du: Cache DSYSR value to ensure known initial value Laurent Pinchart
2018-09-14 9:10 ` Laurent Pinchart
2018-09-24 11:18 ` Kieran Bingham
2018-09-24 11:18 ` Kieran Bingham
2018-09-26 15:55 ` Ulrich Hecht
2018-09-26 15:55 ` Ulrich Hecht
2018-09-14 9:10 ` [PATCH v2 10/16] drm: rcar-du: Don't use TV sync mode when not supported by the hardware Laurent Pinchart
2018-09-14 9:10 ` Laurent Pinchart
2018-09-24 11:26 ` Kieran Bingham
2018-09-24 11:26 ` Kieran Bingham
2018-09-26 15:55 ` Ulrich Hecht
2018-09-26 15:55 ` Ulrich Hecht
2018-09-14 9:10 ` [PATCH v2 11/16] drm: rcar-du: Add r8a77990 and r8a77995 device support Laurent Pinchart
2018-09-14 9:10 ` Laurent Pinchart
2018-09-24 11:41 ` Kieran Bingham
2018-09-24 11:41 ` Kieran Bingham
2018-09-14 9:10 ` [PATCH v2 12/16] arm64: dts: renesas: r8a77990: Add I2C device nodes Laurent Pinchart
2018-09-14 9:10 ` Laurent Pinchart
2018-09-17 7:33 ` Simon Horman
2018-09-17 7:33 ` Simon Horman
2018-09-17 8:08 ` Laurent Pinchart
2018-09-17 8:08 ` Laurent Pinchart
2018-09-14 9:10 ` [PATCH v2 13/16] arm64: dts: renesas: r8a77990: Add display output support Laurent Pinchart
2018-09-14 9:10 ` Laurent Pinchart
2018-09-17 7:50 ` Simon Horman
2018-09-17 7:50 ` Simon Horman
2018-09-17 8:14 ` Simon Horman
2018-09-17 8:14 ` Simon Horman
2018-09-17 8:47 ` Laurent Pinchart
2018-09-17 8:47 ` Laurent Pinchart
2018-09-17 8:54 ` Laurent Pinchart
2018-09-17 8:54 ` Laurent Pinchart
2018-09-17 8:59 ` Laurent Pinchart
2018-09-17 8:59 ` Laurent Pinchart
2018-09-19 8:35 ` Simon Horman
2018-09-19 8:35 ` Simon Horman
2018-09-19 13:11 ` Laurent Pinchart
2018-09-19 13:11 ` Laurent Pinchart
2018-09-21 7:16 ` Simon Horman
2018-09-21 7:16 ` Simon Horman
2018-09-21 8:41 ` Laurent Pinchart
2018-09-21 8:41 ` Laurent Pinchart
2018-09-17 8:38 ` Laurent Pinchart
2018-09-17 8:38 ` Laurent Pinchart
2018-09-17 8:51 ` Simon Horman
2018-09-17 8:51 ` Simon Horman
2018-09-17 9:08 ` Laurent Pinchart
2018-09-17 9:08 ` Laurent Pinchart
2018-09-17 9:48 ` Geert Uytterhoeven
2018-09-17 9:48 ` Geert Uytterhoeven
2018-09-17 10:01 ` Laurent Pinchart
2018-09-17 10:01 ` Laurent Pinchart
2018-09-14 9:10 ` [PATCH v2 14/16] arm64: dts: renesas: r8a77995: Add LVDS support Laurent Pinchart
2018-09-14 9:10 ` Laurent Pinchart
2018-09-14 9:10 ` [PATCH v2 15/16] arm64: dts: renesas: r8a77990: ebisu: Enable VGA and HDMI outputs Laurent Pinchart
2018-09-14 9:10 ` Laurent Pinchart
2018-09-26 15:55 ` Ulrich Hecht
2018-09-26 15:55 ` Ulrich Hecht
2018-09-14 9:10 ` [PATCH v2 16/16] arm64: dts: renesas: r8a77995: draak: Enable HDMI display output Laurent Pinchart
2018-09-14 9:10 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ed87630-2f54-6ace-30b1-5a5667911aa2@ideasonboard.com \
--to=kieran.bingham@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=uli@fpond.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.