All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH ethtool v3 0/2] Adding downshift support to ethtool
@ 2016-11-17 12:07 Allan W. Nielsen
  2016-11-17 12:07 ` [PATCH ethtool v3 1/2] ethtool-copy.h:sync with net Allan W. Nielsen
  2016-11-17 12:08 ` [PATCH ethtool v3 2/2] Ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE and PHY downshift Allan W. Nielsen
  0 siblings, 2 replies; 6+ messages in thread
From: Allan W. Nielsen @ 2016-11-17 12:07 UTC (permalink / raw)
  To: netdev; +Cc: andrew, f.fainelli, raju.lakkaraju, allan.nielsen

Hi All,

(This is a re-post of the v3 patch set with a new cover letter - I was not
aware that the cover letters was used as commit comments in merge commits).

This patch implements for set/get downshifting.

Downshifting can either be turned on/off, or it can be configured to a
specifc count.

"count" is optional.

Tested on Beaglebone Black with VSC 8531 PHY.

Change set:
v1:
- Initial version of set/get phy tunable with downshift feature.
v2:
- (ethtool) Syntax is changed from "--set-phy-tunable downshift on|off|%d"
  to "--set-phy-tunable [downshift on|off [count N]]" - as requested by
  Andrew.
v3:
- Fixed Spelling in "ethtool-copy.h:sync with net" 
- Fixed "if send_ioctl() returns an error, print the error message and then
  still print th value of count".

Raju Lakkaraju (2):
  ethtool-copy.h:sync with net
  Ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE and PHY
    downshift

 ethtool-copy.h |  18 +++++++-
 ethtool.8.in   |  39 ++++++++++++++++
 ethtool.c      | 144 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 200 insertions(+), 1 deletion(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH ethtool v3 0/2] Adding downshift support to ethtool
@ 2016-11-15 10:21 Allan W. Nielsen
  2016-11-15 10:21 ` [PATCH ethtool v3 1/2] ethtool-copy.h:sync with net Allan W. Nielsen
  0 siblings, 1 reply; 6+ messages in thread
From: Allan W. Nielsen @ 2016-11-15 10:21 UTC (permalink / raw)
  To: netdev; +Cc: andrew, raju.lakkaraju, allan.nielsen

Hi All,

This is a follow-up on the v2 patch series.

Following is updated:

- Spelling
- consistent spaces
- error handling of send_ioctl()

Old cover letters included below.

Please review.

Best regards
Allan and Raju


Raju Lakkaraju (2):
  ethtool-copy.h:sync with net
  Ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE and PHY
    downshift

 ethtool-copy.h |  18 +++++++-
 ethtool.8.in   |  39 ++++++++++++++++
 ethtool.c      | 144 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 200 insertions(+), 1 deletion(-)

> From c235004654ee0212b6cf6ca7af14eb6ef8a04dee Mon Sep 17 00:00:00 2001
> From: "Allan W. Nielsen" <allan.nielsen@microsemi.com>
> Date: Mon, 14 Nov 2016 10:22:03 +0100
> Subject: [PATCH ethtool v2 0/2] Adding downshift support to ethtool
> 
> This is a follow-up on the patch series posted at Fri, 4 Nov 2016 11:27:31 +0100
> (old cover letter included below).
> 
> The following is changed/added/addressed:
> - Syntax is changed from "--set-phy-tunable downshift on|off|%d" to
>   "--set-phy-tunable [downshift on|off [count N]]" - as requested by Andrew.
> - Short description of downshifting is added to the man page.
>
> Old cover letter:
> > From 5d926ca56f13e283aaa98e820d4720305be4da8f Mon Sep 17 00:00:00 2001
> > From: "Allan W. Nielsen" <allan.nielsen@microsemi.com>
> > Date: Fri, 4 Nov 2016 11:27:31 +0100
> > Subject: [PATCH ethtool 0/2] Adding downshift support to ethtool
> > 
> > Hi All,
> > 
> > This patch implements for set/get downshifting.
> > 
> > Downshifting can either be turned on/off, or it can be configured to a
> > specifc count.
> > 
> > If no "count" are provided, then it is up to the individual PHY driver to
> > configure a default count.

-- 
2.7.3

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-11-22  1:51 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-17 12:07 [PATCH ethtool v3 0/2] Adding downshift support to ethtool Allan W. Nielsen
2016-11-17 12:07 ` [PATCH ethtool v3 1/2] ethtool-copy.h:sync with net Allan W. Nielsen
2016-11-22  1:03   ` Florian Fainelli
2016-11-17 12:08 ` [PATCH ethtool v3 2/2] Ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE and PHY downshift Allan W. Nielsen
2016-11-22  1:51   ` Florian Fainelli
  -- strict thread matches above, loose matches on Subject: below --
2016-11-15 10:21 [PATCH ethtool v3 0/2] Adding downshift support to ethtool Allan W. Nielsen
2016-11-15 10:21 ` [PATCH ethtool v3 1/2] ethtool-copy.h:sync with net Allan W. Nielsen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.