* [PATCH] gpio: tb10x: Use the right include
@ 2018-08-06 14:23 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2018-08-06 14:23 UTC (permalink / raw)
To: linux-gpio; +Cc: Linus Walleij, linux-snps-arc, Christian Ruppert
This driver includes the legacy <linux/gpio.h> and
<linux/of_gpio.h> but all it needs is really <linux/gpio/driver.h>.
Cc: linux-snps-arc@lists.infradead.org
Cc: Christian Ruppert <christian.ruppert@alitech.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/gpio/gpio-tb10x.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c
index ac6f2a9841e5..a12cd0b5c972 100644
--- a/drivers/gpio/gpio-tb10x.c
+++ b/drivers/gpio/gpio-tb10x.c
@@ -22,7 +22,7 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/platform_device.h>
-#include <linux/gpio.h>
+#include <linux/gpio/driver.h>
#include <linux/slab.h>
#include <linux/irq.h>
#include <linux/irqdomain.h>
@@ -30,7 +30,6 @@
#include <linux/io.h>
#include <linux/of.h>
#include <linux/of_platform.h>
-#include <linux/of_gpio.h>
#include <linux/spinlock.h>
#include <linux/bitops.h>
#include <linux/pinctrl/consumer.h>
--
2.17.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] gpio: tb10x: Use the right include
@ 2018-08-06 14:23 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2018-08-06 14:23 UTC (permalink / raw)
To: linux-snps-arc
This driver includes the legacy <linux/gpio.h> and
<linux/of_gpio.h> but all it needs is really <linux/gpio/driver.h>.
Cc: linux-snps-arc at lists.infradead.org
Cc: Christian Ruppert <christian.ruppert at alitech.com>
Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
---
drivers/gpio/gpio-tb10x.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c
index ac6f2a9841e5..a12cd0b5c972 100644
--- a/drivers/gpio/gpio-tb10x.c
+++ b/drivers/gpio/gpio-tb10x.c
@@ -22,7 +22,7 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/platform_device.h>
-#include <linux/gpio.h>
+#include <linux/gpio/driver.h>
#include <linux/slab.h>
#include <linux/irq.h>
#include <linux/irqdomain.h>
@@ -30,7 +30,6 @@
#include <linux/io.h>
#include <linux/of.h>
#include <linux/of_platform.h>
-#include <linux/of_gpio.h>
#include <linux/spinlock.h>
#include <linux/bitops.h>
#include <linux/pinctrl/consumer.h>
--
2.17.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio: tb10x: Use the right include
2018-08-06 14:23 ` Linus Walleij
@ 2018-08-20 14:51 ` Christian Ruppert
-1 siblings, 0 replies; 4+ messages in thread
From: Christian Ruppert @ 2018-08-20 14:51 UTC (permalink / raw)
To: Linus Walleij, linux-gpio; +Cc: linux-snps-arc
Acked-by: Christian Ruppert <christian.ruppert@alitech.com>
On 06.08.2018 16:23, Linus Walleij wrote:
> This driver includes the legacy <linux/gpio.h> and
> <linux/of_gpio.h> but all it needs is really <linux/gpio/driver.h>.
>
> Cc: linux-snps-arc@lists.infradead.org
> Cc: Christian Ruppert <christian.ruppert@alitech.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/gpio/gpio-tb10x.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c
> index ac6f2a9841e5..a12cd0b5c972 100644
> --- a/drivers/gpio/gpio-tb10x.c
> +++ b/drivers/gpio/gpio-tb10x.c
> @@ -22,7 +22,7 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/driver.h>
> #include <linux/slab.h>
> #include <linux/irq.h>
> #include <linux/irqdomain.h>
> @@ -30,7 +30,6 @@
> #include <linux/io.h>
> #include <linux/of.h>
> #include <linux/of_platform.h>
> -#include <linux/of_gpio.h>
> #include <linux/spinlock.h>
> #include <linux/bitops.h>
> #include <linux/pinctrl/consumer.h>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] gpio: tb10x: Use the right include
@ 2018-08-20 14:51 ` Christian Ruppert
0 siblings, 0 replies; 4+ messages in thread
From: Christian Ruppert @ 2018-08-20 14:51 UTC (permalink / raw)
To: linux-snps-arc
Acked-by: Christian Ruppert <christian.ruppert at alitech.com>
On 06.08.2018 16:23, Linus Walleij wrote:
> This driver includes the legacy <linux/gpio.h> and
> <linux/of_gpio.h> but all it needs is really <linux/gpio/driver.h>.
>
> Cc: linux-snps-arc at lists.infradead.org
> Cc: Christian Ruppert <christian.ruppert at alitech.com>
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> ---
> drivers/gpio/gpio-tb10x.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c
> index ac6f2a9841e5..a12cd0b5c972 100644
> --- a/drivers/gpio/gpio-tb10x.c
> +++ b/drivers/gpio/gpio-tb10x.c
> @@ -22,7 +22,7 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/driver.h>
> #include <linux/slab.h>
> #include <linux/irq.h>
> #include <linux/irqdomain.h>
> @@ -30,7 +30,6 @@
> #include <linux/io.h>
> #include <linux/of.h>
> #include <linux/of_platform.h>
> -#include <linux/of_gpio.h>
> #include <linux/spinlock.h>
> #include <linux/bitops.h>
> #include <linux/pinctrl/consumer.h>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-20 14:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-06 14:23 [PATCH] gpio: tb10x: Use the right include Linus Walleij
2018-08-06 14:23 ` Linus Walleij
2018-08-20 14:51 ` Christian Ruppert
2018-08-20 14:51 ` Christian Ruppert
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.