From: Michal Simek <michal.simek@xilinx.com>
To: Moritz Fischer <mdf@kernel.org>, <linux-fpga@vger.kernel.org>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"Michal Simek" <michal.simek@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Devicetree List" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/2] fpga: Add support for Xilinx LogiCORE PR Decoupler
Date: Mon, 13 Mar 2017 11:27:36 +0100 [thread overview]
Message-ID: <2f21aeb3-dd4e-e170-729a-a785077b6f28@xilinx.com> (raw)
In-Reply-To: <CAAtXAHe-AMq9Ux2LZZEWLcg8Dk6jTiHhrot4RhEVrxTBhnLE0g@mail.gmail.com>
Hi Moritz,
On 10.3.2017 23:42, Moritz Fischer wrote:
> On Fri, Mar 10, 2017 at 1:30 PM, Moritz Fischer <mdf@kernel.org> wrote:
>> This adds support for the Xilinx LogiCORE PR Decoupler
>> soft-ip that does decoupling of PR regions in the FPGA
>> fabric during partial reconfiguration.
>>
>> Signed-off-by: Moritz Fischer <mdf@kernel.org>
>> Cc: Michal Simek <michal.simek@xilinx.com>
>> Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
>> Cc: linux-kernel@vger.kernel.org
>> Cc: devicetree@vger.kernel.org
>> ---
>> drivers/fpga/Kconfig | 9 +++
>> drivers/fpga/Makefile | 1 +
>> drivers/fpga/xilinx-pr-decoupler.c | 156 +++++++++++++++++++++++++++++++++++++
>> 3 files changed, 166 insertions(+)
>> create mode 100644 drivers/fpga/xilinx-pr-decoupler.c
I have written very similar driver some week ago but didn't sent it out.
Here it is.
https://github.com/Xilinx/linux-xlnx/blob/master/drivers/fpga/xilinx-pr-decoupler.c
Your clk handling is better and my enable_show is better.
You shouldn't rely on setting status before. It is better to read that
reg again. The reason is you can connect status signal from one PR
decoupler to decouple input which can change status
There is another topic I wanted to open in connection to this. There
should be gpio based bridge because this pr decoupler can be without axi
interface and for that gpio driver would be useful.
Thanks,
Michal
WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
To: Moritz Fischer <mdf-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-fpga-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: "Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"Michal Simek"
<michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
"Sören Brinkmann"
<soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
"Linux Kernel Mailing List"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Devicetree List"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/2] fpga: Add support for Xilinx LogiCORE PR Decoupler
Date: Mon, 13 Mar 2017 11:27:36 +0100 [thread overview]
Message-ID: <2f21aeb3-dd4e-e170-729a-a785077b6f28@xilinx.com> (raw)
In-Reply-To: <CAAtXAHe-AMq9Ux2LZZEWLcg8Dk6jTiHhrot4RhEVrxTBhnLE0g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi Moritz,
On 10.3.2017 23:42, Moritz Fischer wrote:
> On Fri, Mar 10, 2017 at 1:30 PM, Moritz Fischer <mdf-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
>> This adds support for the Xilinx LogiCORE PR Decoupler
>> soft-ip that does decoupling of PR regions in the FPGA
>> fabric during partial reconfiguration.
>>
>> Signed-off-by: Moritz Fischer <mdf-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>> Cc: Michal Simek <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
>> Cc: Sören Brinkmann <soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
>> Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> ---
>> drivers/fpga/Kconfig | 9 +++
>> drivers/fpga/Makefile | 1 +
>> drivers/fpga/xilinx-pr-decoupler.c | 156 +++++++++++++++++++++++++++++++++++++
>> 3 files changed, 166 insertions(+)
>> create mode 100644 drivers/fpga/xilinx-pr-decoupler.c
I have written very similar driver some week ago but didn't sent it out.
Here it is.
https://github.com/Xilinx/linux-xlnx/blob/master/drivers/fpga/xilinx-pr-decoupler.c
Your clk handling is better and my enable_show is better.
You shouldn't rely on setting status before. It is better to read that
reg again. The reason is you can connect status signal from one PR
decoupler to decouple input which can change status
There is another topic I wanted to open in connection to this. There
should be gpio based bridge because this pr decoupler can be without axi
interface and for that gpio driver would be useful.
Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <michal.simek@xilinx.com>
To: Moritz Fischer <mdf@kernel.org>, linux-fpga@vger.kernel.org
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"Michal Simek" <michal.simek@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Devicetree List" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/2] fpga: Add support for Xilinx LogiCORE PR Decoupler
Date: Mon, 13 Mar 2017 11:27:36 +0100 [thread overview]
Message-ID: <2f21aeb3-dd4e-e170-729a-a785077b6f28@xilinx.com> (raw)
In-Reply-To: <CAAtXAHe-AMq9Ux2LZZEWLcg8Dk6jTiHhrot4RhEVrxTBhnLE0g@mail.gmail.com>
Hi Moritz,
On 10.3.2017 23:42, Moritz Fischer wrote:
> On Fri, Mar 10, 2017 at 1:30 PM, Moritz Fischer <mdf@kernel.org> wrote:
>> This adds support for the Xilinx LogiCORE PR Decoupler
>> soft-ip that does decoupling of PR regions in the FPGA
>> fabric during partial reconfiguration.
>>
>> Signed-off-by: Moritz Fischer <mdf@kernel.org>
>> Cc: Michal Simek <michal.simek@xilinx.com>
>> Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
>> Cc: linux-kernel@vger.kernel.org
>> Cc: devicetree@vger.kernel.org
>> ---
>> drivers/fpga/Kconfig | 9 +++
>> drivers/fpga/Makefile | 1 +
>> drivers/fpga/xilinx-pr-decoupler.c | 156 +++++++++++++++++++++++++++++++++++++
>> 3 files changed, 166 insertions(+)
>> create mode 100644 drivers/fpga/xilinx-pr-decoupler.c
I have written very similar driver some week ago but didn't sent it out.
Here it is.
https://github.com/Xilinx/linux-xlnx/blob/master/drivers/fpga/xilinx-pr-decoupler.c
Your clk handling is better and my enable_show is better.
You shouldn't rely on setting status before. It is better to read that
reg again. The reason is you can connect status signal from one PR
decoupler to decouple input which can change status
There is another topic I wanted to open in connection to this. There
should be gpio based bridge because this pr decoupler can be without axi
interface and for that gpio driver would be useful.
Thanks,
Michal
WARNING: multiple messages have this Message-ID (diff)
From: michal.simek@xilinx.com (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] fpga: Add support for Xilinx LogiCORE PR Decoupler
Date: Mon, 13 Mar 2017 11:27:36 +0100 [thread overview]
Message-ID: <2f21aeb3-dd4e-e170-729a-a785077b6f28@xilinx.com> (raw)
In-Reply-To: <CAAtXAHe-AMq9Ux2LZZEWLcg8Dk6jTiHhrot4RhEVrxTBhnLE0g@mail.gmail.com>
Hi Moritz,
On 10.3.2017 23:42, Moritz Fischer wrote:
> On Fri, Mar 10, 2017 at 1:30 PM, Moritz Fischer <mdf@kernel.org> wrote:
>> This adds support for the Xilinx LogiCORE PR Decoupler
>> soft-ip that does decoupling of PR regions in the FPGA
>> fabric during partial reconfiguration.
>>
>> Signed-off-by: Moritz Fischer <mdf@kernel.org>
>> Cc: Michal Simek <michal.simek@xilinx.com>
>> Cc: S?ren Brinkmann <soren.brinkmann@xilinx.com>
>> Cc: linux-kernel at vger.kernel.org
>> Cc: devicetree at vger.kernel.org
>> ---
>> drivers/fpga/Kconfig | 9 +++
>> drivers/fpga/Makefile | 1 +
>> drivers/fpga/xilinx-pr-decoupler.c | 156 +++++++++++++++++++++++++++++++++++++
>> 3 files changed, 166 insertions(+)
>> create mode 100644 drivers/fpga/xilinx-pr-decoupler.c
I have written very similar driver some week ago but didn't sent it out.
Here it is.
https://github.com/Xilinx/linux-xlnx/blob/master/drivers/fpga/xilinx-pr-decoupler.c
Your clk handling is better and my enable_show is better.
You shouldn't rely on setting status before. It is better to read that
reg again. The reason is you can connect status signal from one PR
decoupler to decouple input which can change status
There is another topic I wanted to open in connection to this. There
should be gpio based bridge because this pr decoupler can be without axi
interface and for that gpio driver would be useful.
Thanks,
Michal
next prev parent reply other threads:[~2017-03-13 10:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 21:30 [PATCH 1/2] doc: Add bindings document for Xilinx LogiCore PR Decoupler Moritz Fischer
2017-03-10 21:30 ` Moritz Fischer
2017-03-10 21:30 ` Moritz Fischer
2017-03-10 21:30 ` [PATCH 2/2] fpga: Add support for Xilinx LogiCORE " Moritz Fischer
2017-03-10 21:30 ` Moritz Fischer
2017-03-10 22:42 ` Moritz Fischer
2017-03-10 22:42 ` Moritz Fischer
2017-03-10 22:42 ` Moritz Fischer
2017-03-13 10:27 ` Michal Simek [this message]
2017-03-13 10:27 ` Michal Simek
2017-03-13 10:27 ` Michal Simek
2017-03-13 10:27 ` Michal Simek
2017-03-13 16:18 ` Moritz Fischer
2017-03-13 16:18 ` Moritz Fischer
2017-03-13 16:18 ` Moritz Fischer
2017-03-14 6:40 ` Michal Simek
2017-03-14 6:40 ` Michal Simek
2017-03-14 6:40 ` Michal Simek
2017-03-14 6:40 ` Michal Simek
2017-03-13 10:29 ` [PATCH 1/2] doc: Add bindings document for Xilinx LogiCore " Michal Simek
2017-03-13 10:29 ` Michal Simek
2017-03-13 10:29 ` Michal Simek
2017-03-13 10:29 ` Michal Simek
2017-03-24 15:33 [PATCH 0/2] fpga: " Alan Tull
2017-03-24 15:33 ` [PATCH 2/2] fpga: Add support for Xilinx LogiCORE " Alan Tull
2017-03-24 15:33 ` Alan Tull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f21aeb3-dd4e-e170-729a-a785077b6f28@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mdf@kernel.org \
--cc=robh+dt@kernel.org \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.