All of lore.kernel.org
 help / color / mirror / Atom feed
From: Byungchul Park <byungchul.park@lge.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: peterz@infradead.org, tglx@linutronix.de,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-block@vger.kernel.org, kernel-team@lge.com
Subject: Re: [PATCH v2] locking/lockdep: Revise Documentation/locking/crossrelease.txt
Date: Fri, 10 Nov 2017 16:41:18 +0900	[thread overview]
Message-ID: <2f2de6c8-ef4b-070d-a81d-eed677bcce35@lge.com> (raw)
In-Reply-To: <20171110073053.qh4nhpl26i47gbiv@gmail.com>

On 11/10/2017 4:30 PM, Ingo Molnar wrote:
> 
> * Byungchul Park <byungchul.park@lge.com> wrote:
> 
>>      Event C depends on event A.
>>      Event A depends on event B.
>>      Event B depends on event C.
>>   
>> -   NOTE: Precisely speaking, a dependency is one between whether a
>> -   waiter for an event can be woken up and whether another waiter for
>> -   another event can be woken up. However from now on, we will describe
>> -   a dependency as if it's one between an event and another event for
>> -   simplicity.
> 
> Why was this explanation removed?
> 
>> -Lockdep tries to detect a deadlock by checking dependencies created by
>> -lock operations, acquire and release. Waiting for a lock corresponds to
>> -waiting for an event, and releasing a lock corresponds to triggering an
>> -event in the previous section.
>> +Lockdep tries to detect a deadlock by checking circular dependencies
>> +created by lock operations, acquire and release, which are wait and
>> +event respectively.
> 
> What? You changed a readable paragraph into an unreadable one.
> 
> Sorry, this text needs to be acked by someone with good English skills, and I
> don't have the time right now to fix it all up. Please send minimal, obvious
> typo/grammar fixes only.

I will send one including minimal fixes at the next spin.

-- 
Thanks,
Byungchul

WARNING: multiple messages have this Message-ID (diff)
From: Byungchul Park <byungchul.park@lge.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: peterz@infradead.org, tglx@linutronix.de,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-block@vger.kernel.org, kernel-team@lge.com
Subject: Re: [PATCH v2] locking/lockdep: Revise Documentation/locking/crossrelease.txt
Date: Fri, 10 Nov 2017 16:41:18 +0900	[thread overview]
Message-ID: <2f2de6c8-ef4b-070d-a81d-eed677bcce35@lge.com> (raw)
In-Reply-To: <20171110073053.qh4nhpl26i47gbiv@gmail.com>

On 11/10/2017 4:30 PM, Ingo Molnar wrote:
> 
> * Byungchul Park <byungchul.park@lge.com> wrote:
> 
>>      Event C depends on event A.
>>      Event A depends on event B.
>>      Event B depends on event C.
>>   
>> -   NOTE: Precisely speaking, a dependency is one between whether a
>> -   waiter for an event can be woken up and whether another waiter for
>> -   another event can be woken up. However from now on, we will describe
>> -   a dependency as if it's one between an event and another event for
>> -   simplicity.
> 
> Why was this explanation removed?
> 
>> -Lockdep tries to detect a deadlock by checking dependencies created by
>> -lock operations, acquire and release. Waiting for a lock corresponds to
>> -waiting for an event, and releasing a lock corresponds to triggering an
>> -event in the previous section.
>> +Lockdep tries to detect a deadlock by checking circular dependencies
>> +created by lock operations, acquire and release, which are wait and
>> +event respectively.
> 
> What? You changed a readable paragraph into an unreadable one.
> 
> Sorry, this text needs to be acked by someone with good English skills, and I
> don't have the time right now to fix it all up. Please send minimal, obvious
> typo/grammar fixes only.

I will send one including minimal fixes at the next spin.

-- 
Thanks,
Byungchul

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-11-10  7:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-09  7:20 [PATCH v2] locking/lockdep: Revise Documentation/locking/crossrelease.txt Byungchul Park
2017-11-09  7:20 ` Byungchul Park
2017-11-09  7:41 ` Byungchul Park
2017-11-09  7:41   ` Byungchul Park
2017-11-10  7:30 ` Ingo Molnar
2017-11-10  7:30   ` Ingo Molnar
2017-11-10  7:41   ` Byungchul Park [this message]
2017-11-10  7:41     ` Byungchul Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f2de6c8-ef4b-070d-a81d-eed677bcce35@lge.com \
    --to=byungchul.park@lge.com \
    --cc=kernel-team@lge.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.