All of lore.kernel.org
 help / color / mirror / Atom feed
From: sathyanarayanan.kuppuswamy@linux.intel.com
To: gnurou@gmail.com, linus.walleij@linaro.org, edubezval@gmail.com,
	dvhart@infradead.org, rui.zhang@intel.com, lee.jones@linaro.org,
	andy@infradead.org
Cc: linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, sathyaosid@gmail.com,
	Kuppuswamy Sathyanarayanan
	<sathyanarayanan.kuppuswamy@linux.intel.com>
Subject: [PATCH v3 4/8] mfd: intel_soc_pmic_bxtwc: remove second level irq for gpio device
Date: Tue, 23 May 2017 10:30:02 -0700	[thread overview]
Message-ID: <2f332f4212ccd9a62344f20c8439a491b2385aaf.1495559980.git.sathyanarayanan.kuppuswamy@linux.intel.com> (raw)
In-Reply-To: <20170523072615.r4widzjc6apwxpwb@dell>
In-Reply-To: <75e12563a835dc4f8e8dab26ecea46822262604b.1495559980.git.sathyanarayanan.kuppuswamy@linux.intel.com>

From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

Currently all PMIC GPIO domain irqs are consumed by the same
device(bxt_wcove_gpio), so there is no need to export them as
separate interrupts. We can just export only the first level
GPIO irq(BXTWC_GPIO_LVL1_IRQ) as an irq resource and let the
GPIO device driver(bxt_wcove_gpio) handle the GPIO sub domain
irqs based on status value of GPIO level2 interrupt status
register. Also, just using only the first level irq will eliminate
the bug involved in requesting only the second level irq and not
explicitly enable the first level irq. For more info on this
issue please read the details at,

https://lkml.org/lkml/2017/2/27/148

Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mfd/intel_soc_pmic_bxtwc.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Changes since v1:
 * None

Changes since v2: 
 * Rebased on top of latest release.

diff --git a/drivers/mfd/intel_soc_pmic_bxtwc.c b/drivers/mfd/intel_soc_pmic_bxtwc.c
index 7c1ed27..af11c43 100644
--- a/drivers/mfd/intel_soc_pmic_bxtwc.c
+++ b/drivers/mfd/intel_soc_pmic_bxtwc.c
@@ -89,8 +89,6 @@ enum bxtwc_irqs_level2 {
 	BXTWC_USBC_IRQ,
 	BXTWC_CHGR0_IRQ,
 	BXTWC_CHGR1_IRQ,
-	BXTWC_GPIO0_IRQ,
-	BXTWC_GPIO1_IRQ,
 	BXTWC_CRIT_IRQ,
 };
 
@@ -116,8 +114,6 @@ static const struct regmap_irq bxtwc_regmap_irqs_level2[] = {
 	REGMAP_IRQ_REG(BXTWC_USBC_IRQ, 2, BIT(5)),
 	REGMAP_IRQ_REG(BXTWC_CHGR0_IRQ, 2, 0x1f),
 	REGMAP_IRQ_REG(BXTWC_CHGR1_IRQ, 3, 0x1f),
-	REGMAP_IRQ_REG(BXTWC_GPIO0_IRQ, 4, 0xff),
-	REGMAP_IRQ_REG(BXTWC_GPIO1_IRQ, 5, 0x3f),
 	REGMAP_IRQ_REG(BXTWC_CRIT_IRQ, 6, 0x03),
 };
 
@@ -153,8 +149,7 @@ static struct regmap_irq_chip bxtwc_regmap_irq_chip_tmu = {
 };
 
 static struct resource gpio_resources[] = {
-	DEFINE_RES_IRQ_NAMED(BXTWC_GPIO0_IRQ, "GPIO0"),
-	DEFINE_RES_IRQ_NAMED(BXTWC_GPIO1_IRQ, "GPIO1"),
+	DEFINE_RES_IRQ_NAMED(BXTWC_GPIO_LVL1_IRQ, "GPIO"),
 };
 
 static struct resource adc_resources[] = {
-- 
2.7.4

  parent reply	other threads:[~2017-05-23 17:30 UTC|newest]

Thread overview: 132+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-14 23:25 [PATCH v2 1/8] mfd: intel_soc_pmic_bxtwc: fix TMU interrupt index sathyanarayanan.kuppuswamy
2017-04-14 23:25 ` sathyanarayanan.kuppuswamy
2017-04-14 23:25 ` [PATCH v2 2/8] mfd: intel_soc_pmic_bxtwc: remove thermal second level irqs sathyanarayanan.kuppuswamy
2017-04-14 23:25   ` sathyanarayanan.kuppuswamy
2017-04-14 23:25 ` [PATCH v2 3/8] thermal: intel_bxt_pmic_thermal: use first level PMIC thermal irq sathyanarayanan.kuppuswamy
2017-04-14 23:25   ` sathyanarayanan.kuppuswamy
2017-05-22 10:17   ` Lee Jones
2017-05-22 19:08     ` sathyanarayanan kuppuswamy
2017-05-22 19:08       ` sathyanarayanan kuppuswamy
2017-05-23  6:24   ` Zhang Rui
2017-05-23  7:26     ` Lee Jones
2017-05-23 17:29       ` [PATCH v3 1/8] mfd: intel_soc_pmic_bxtwc: fix TMU interrupt index sathyanarayanan.kuppuswamy
2017-05-23 17:29         ` sathyanarayanan.kuppuswamy
2017-05-23 17:30         ` [PATCH v3 2/8] mfd: intel_soc_pmic_bxtwc: remove thermal second level irqs sathyanarayanan.kuppuswamy
2017-05-23 17:30           ` sathyanarayanan.kuppuswamy
2017-05-23 17:30         ` [PATCH v3 3/8] thermal: intel_bxt_pmic_thermal: use first level PMIC thermal irq sathyanarayanan.kuppuswamy
2017-05-23 17:30           ` sathyanarayanan.kuppuswamy
2017-05-23 17:30         ` sathyanarayanan.kuppuswamy [this message]
2017-05-23 17:30           ` [PATCH v3 4/8] mfd: intel_soc_pmic_bxtwc: remove second level irq for gpio device sathyanarayanan.kuppuswamy
2017-05-23 17:30         ` [PATCH v3 5/8] gpio: gpio-wcove: use first level PMIC GPIO irq sathyanarayanan.kuppuswamy
2017-05-23 17:30           ` sathyanarayanan.kuppuswamy
2017-05-23 17:30         ` [PATCH v3 6/8] mfd: intel_soc_pmic_bxtwc: utilize devm_* functions in driver probe sathyanarayanan.kuppuswamy
2017-05-23 17:30           ` sathyanarayanan.kuppuswamy
2017-05-23 17:30         ` [PATCH v3 7/8] mfd: intel_soc_pmic_bxtwc: use chained irqs for second level irq chips sathyanarayanan.kuppuswamy
2017-05-23 17:30           ` sathyanarayanan.kuppuswamy
2017-05-23 17:30         ` [PATCH v3 8/8] platform: x86: intel_bxtwc_tmu: remove first level irq unmask sathyanarayanan.kuppuswamy
2017-05-23 17:30           ` sathyanarayanan.kuppuswamy
2017-05-30  8:53         ` [GIT PULL] Immutable branch between MFD, GPIO, Thermal and X86 due for the v4.13 merge window Lee Jones
2017-05-31  3:38           ` Stephen Rothwell
2017-05-31  4:27             ` Sathyanarayanan Kuppuswamy Natarajan
2017-05-31  4:27               ` Sathyanarayanan Kuppuswamy Natarajan
2017-05-31  4:29             ` Sathyanarayanan Kuppuswamy Natarajan
2017-05-31  4:29               ` Sathyanarayanan Kuppuswamy Natarajan
2017-05-31  6:57               ` Lee Jones
2017-05-31  6:57                 ` Lee Jones
2017-05-31 22:33                 ` sathyanarayanan kuppuswamy
2017-05-31 22:33                   ` sathyanarayanan kuppuswamy
2017-06-03 17:01                   ` Darren Hart
2017-06-03 17:01                     ` Darren Hart
2017-05-31  6:50             ` Lee Jones
2017-05-31  7:02           ` Lee Jones
2017-05-31 22:37             ` [PATCH v5 0/8] mfd: intel_soc_pmic_bxtwc: Add chained IRQ support sathyanarayanan.kuppuswamy
2017-05-31 22:37               ` sathyanarayanan.kuppuswamy
2017-05-31 22:37               ` [PATCH v5 1/8] mfd: intel_soc_pmic_bxtwc: Fix TMU interrupt index sathyanarayanan.kuppuswamy
2017-05-31 22:37                 ` sathyanarayanan.kuppuswamy
2017-05-31 22:37               ` [PATCH v5 2/8] mfd: intel_soc_pmic_bxtwc: Remove thermal second level irqs sathyanarayanan.kuppuswamy
2017-05-31 22:37                 ` sathyanarayanan.kuppuswamy
2017-05-31 22:37               ` [PATCH v5 3/8] thermal: intel_bxt_pmic_thermal: Use first level PMIC thermal irq sathyanarayanan.kuppuswamy
2017-05-31 22:37                 ` sathyanarayanan.kuppuswamy
2017-06-03 13:00                 ` Andy Shevchenko
2017-06-03 13:00                   ` Andy Shevchenko
2017-06-03 17:28                   ` Sathyanarayanan Kuppuswamy Natarajan
2017-06-03 17:28                     ` Sathyanarayanan Kuppuswamy Natarajan
2017-06-03 17:32                     ` Andy Shevchenko
2017-06-03 17:32                       ` Andy Shevchenko
2017-06-03 17:53                       ` Sathyanarayanan Kuppuswamy Natarajan
2017-06-03 17:53                         ` Sathyanarayanan Kuppuswamy Natarajan
2017-06-03 18:18                         ` Andy Shevchenko
2017-06-03 18:18                           ` Andy Shevchenko
2017-06-05 19:08                           ` [PATCH v6 0/6] mfd: intel_soc_pmic_bxtwc: Add chained IRQ support sathyanarayanan.kuppuswamy
2017-06-05 19:08                             ` sathyanarayanan.kuppuswamy
2017-06-05 19:08                             ` [PATCH v6 1/6] mfd: intel_soc_pmic_bxtwc: Fix TMU interrupt index sathyanarayanan.kuppuswamy
2017-06-05 19:08                               ` sathyanarayanan.kuppuswamy
2017-06-05 19:08                             ` [PATCH v6 2/6] mfd: intel_soc_pmic_bxtwc: Remove thermal second level IRQs sathyanarayanan.kuppuswamy
2017-06-05 19:08                               ` sathyanarayanan.kuppuswamy
2017-06-05 19:08                             ` [PATCH v6 3/6] mfd: intel_soc_pmic_bxtwc: Remove second level IRQ for gpio device sathyanarayanan.kuppuswamy
2017-06-05 19:08                               ` sathyanarayanan.kuppuswamy
2017-06-05 19:08                             ` [PATCH v6 4/6] mfd: intel_soc_pmic_bxtwc: Utilize devm_* functions in driver probe sathyanarayanan.kuppuswamy
2017-06-05 19:08                               ` sathyanarayanan.kuppuswamy
2017-06-05 19:08                             ` [PATCH v6 5/6] mfd: intel_soc_pmic_bxtwc: Use chained IRQs for second level IRQ chips sathyanarayanan.kuppuswamy
2017-06-05 19:08                               ` sathyanarayanan.kuppuswamy
2017-06-06  9:29                               ` Heikki Krogerus
2017-06-05 19:08                             ` [PATCH v6 6/6] platform/x86: intel_bxtwc_tmu: Remove first level IRQ unmask sathyanarayanan.kuppuswamy
2017-06-05 19:08                               ` sathyanarayanan.kuppuswamy
2017-06-06  9:36                             ` [PATCH v6 0/6] mfd: intel_soc_pmic_bxtwc: Add chained IRQ support Andy Shevchenko
2017-06-06  9:36                               ` Andy Shevchenko
2017-06-19 14:48                             ` [GIT PULL] Immutable branch between MFD and X86 due for the v4.13 merge window Lee Jones
2017-06-19 15:08                               ` Andy Shevchenko
2017-06-19 15:08                                 ` Andy Shevchenko
2017-06-19 19:54                                 ` Darren Hart
2017-06-19 19:54                                   ` Darren Hart
2017-05-31 22:37               ` [PATCH v5 4/8] mfd: intel_soc_pmic_bxtwc: Remove second level irq for gpio device sathyanarayanan.kuppuswamy
2017-05-31 22:37                 ` sathyanarayanan.kuppuswamy
2017-05-31 22:37               ` [PATCH v5 5/8] gpio: gpio-wcove: Use first level PMIC GPIO irq sathyanarayanan.kuppuswamy
2017-05-31 22:37                 ` sathyanarayanan.kuppuswamy
2017-06-03 13:01                 ` Andy Shevchenko
2017-06-03 13:01                   ` Andy Shevchenko
2017-05-31 22:37               ` [PATCH v5 7/8] mfd: intel_soc_pmic_bxtwc: Use chained irqs for second level irq chips sathyanarayanan.kuppuswamy
2017-05-31 22:37                 ` sathyanarayanan.kuppuswamy
2017-06-03 13:26                 ` Andy Shevchenko
2017-06-03 13:26                   ` Andy Shevchenko
2017-05-31 22:37               ` [PATCH v5 8/8] platform/x86: intel_bxtwc_tmu: Remove first level irq unmask sathyanarayanan.kuppuswamy
2017-05-31 22:37                 ` sathyanarayanan.kuppuswamy
2017-06-03 13:27               ` [PATCH v5 0/8] mfd: intel_soc_pmic_bxtwc: Add chained IRQ support Andy Shevchenko
2017-06-03 13:27                 ` Andy Shevchenko
     [not found]             ` <cover.1496266871.git.sathyanarayanan.kuppuswamy-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-05-31 22:37               ` [PATCH v5 6/8] mfd: intel_soc_pmic_bxtwc: Utilize devm_* functions in driver probe sathyanarayanan.kuppuswamy-VuQAYsv1563Yd54FQh9/CA
2017-05-31 22:37                 ` sathyanarayanan.kuppuswamy
2017-06-03 13:03                 ` Andy Shevchenko
2017-06-03 13:03                   ` Andy Shevchenko
2017-04-14 23:25 ` [PATCH v2 4/8] mfd: intel_soc_pmic_bxtwc: remove second level irq for gpio device sathyanarayanan.kuppuswamy
2017-04-14 23:25   ` sathyanarayanan.kuppuswamy
2017-04-14 23:25 ` [PATCH v2 5/8] gpio: gpio-wcove: use first level PMIC GPIO irq sathyanarayanan.kuppuswamy
2017-04-14 23:25   ` sathyanarayanan.kuppuswamy
2017-04-24 13:17   ` Linus Walleij
2017-04-24 13:17     ` Linus Walleij
2017-04-26 15:40     ` Andy Shevchenko
2017-04-26 15:40       ` Andy Shevchenko
2017-04-14 23:25 ` [PATCH v2 6/8] mfd: intel_soc_pmic_bxtwc: utilize devm_* functions in driver probe sathyanarayanan.kuppuswamy
2017-04-14 23:25   ` sathyanarayanan.kuppuswamy
2017-04-24 12:03   ` Lee Jones
2017-04-14 23:25 ` [PATCH v2 7/8] mfd: intel_soc_pmic_bxtwc: use chained irqs for second level irq chips sathyanarayanan.kuppuswamy
2017-04-14 23:25   ` sathyanarayanan.kuppuswamy
2017-04-24 12:04   ` Lee Jones
2017-04-14 23:26 ` [PATCH v2 8/8] platform: x86: intel_bxtwc_tmu: remove first level irq unmask sathyanarayanan.kuppuswamy
2017-04-14 23:26   ` sathyanarayanan.kuppuswamy
2017-04-21 22:00   ` Darren Hart
2017-04-21 22:34     ` sathyanarayanan kuppuswamy
2017-04-21 22:34       ` sathyanarayanan kuppuswamy
2017-04-22  2:52       ` Andy Shevchenko
2017-04-22  2:52         ` Andy Shevchenko
2017-04-24  9:24         ` Lee Jones
2017-04-24  9:24           ` Lee Jones
2017-04-24  9:44           ` Andy Shevchenko
2017-04-24  9:44             ` Andy Shevchenko
2017-04-24 12:24             ` Lee Jones
2017-04-24 12:24               ` Lee Jones
2017-04-26 15:44               ` Andy Shevchenko
2017-04-26 15:44                 ` Andy Shevchenko
2017-04-24  9:26     ` Lee Jones
2017-05-30  8:54 ` [PATCH v2 1/8] mfd: intel_soc_pmic_bxtwc: fix TMU interrupt index Lee Jones
2017-05-30 18:00   ` sathyanarayanan kuppuswamy
2017-05-30 18:00     ` sathyanarayanan kuppuswamy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f332f4212ccd9a62344f20c8439a491b2385aaf.1495559980.git.sathyanarayanan.kuppuswamy@linux.intel.com \
    --to=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=andy@infradead.org \
    --cc=dvhart@infradead.org \
    --cc=edubezval@gmail.com \
    --cc=gnurou@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=sathyaosid@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.