All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	<chunkuang.hu@kernel.org>, <matthias.bgg@gmail.com>,
	<robh+dt@kernel.org>
Cc: <p.zabel@pengutronix.de>, <airlied@linux.ie>, <daniel@ffwll.ch>,
	<jassisinghbrar@gmail.com>, <fparent@baylibre.com>,
	<yongqiang.niu@mediatek.com>, <hsinyi@chromium.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH V8 1/5] dt-bindings: display: mediatek: add aal binding for MT8183
Date: Thu, 17 Mar 2022 12:48:07 +0800	[thread overview]
Message-ID: <2f3c1f4461267644ab8e2b45e21c61591d245b01.camel@mediatek.com> (raw)
In-Reply-To: <cf765199-30c3-f963-4d9b-8f225efd5b32@canonical.com>

On Wed, 2022-03-16 at 16:18 +0100, Krzysztof Kozlowski wrote:
> On 16/03/2022 12:51, Rex-BC Chen wrote:
> > Add aal binding for MT8183.
> > 
> > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> > ---
> >  .../devicetree/bindings/display/mediatek/mediatek,aal.yaml    | 4
> > +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > index 61f0ed1e388f..eb0299b80522 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > @@ -22,7 +22,9 @@ properties:
> >    compatible:
> >      oneOf:
> >        - items:
> > -          - const: mediatek,mt8173-disp-aal
> > +          - enum:
> > +              - mediatek,mt8173-disp-aal
> > +              - mediatek,mt8183-disp-aal
> 
> This should not be under items. You have just one element here, so
> directly "enum" under oneOf.
> 
> 
> Best regards,
> Krzysztof

Hello Krzysztof,

OK, I will do this in next version.
Thanks!

BRs,
Rex


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	<chunkuang.hu@kernel.org>, <matthias.bgg@gmail.com>,
	<robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, airlied@linux.ie,
	jassisinghbrar@gmail.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, yongqiang.niu@mediatek.com,
	Project_Global_Chrome_Upstream_Group@mediatek.com,
	fparent@baylibre.com, linux-mediatek@lists.infradead.org,
	hsinyi@chromium.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V8 1/5] dt-bindings: display: mediatek: add aal binding for MT8183
Date: Thu, 17 Mar 2022 12:48:07 +0800	[thread overview]
Message-ID: <2f3c1f4461267644ab8e2b45e21c61591d245b01.camel@mediatek.com> (raw)
In-Reply-To: <cf765199-30c3-f963-4d9b-8f225efd5b32@canonical.com>

On Wed, 2022-03-16 at 16:18 +0100, Krzysztof Kozlowski wrote:
> On 16/03/2022 12:51, Rex-BC Chen wrote:
> > Add aal binding for MT8183.
> > 
> > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> > ---
> >  .../devicetree/bindings/display/mediatek/mediatek,aal.yaml    | 4
> > +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > index 61f0ed1e388f..eb0299b80522 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > @@ -22,7 +22,9 @@ properties:
> >    compatible:
> >      oneOf:
> >        - items:
> > -          - const: mediatek,mt8173-disp-aal
> > +          - enum:
> > +              - mediatek,mt8173-disp-aal
> > +              - mediatek,mt8183-disp-aal
> 
> This should not be under items. You have just one element here, so
> directly "enum" under oneOf.
> 
> 
> Best regards,
> Krzysztof

Hello Krzysztof,

OK, I will do this in next version.
Thanks!

BRs,
Rex


WARNING: multiple messages have this Message-ID (diff)
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	<chunkuang.hu@kernel.org>, <matthias.bgg@gmail.com>,
	<robh+dt@kernel.org>
Cc: <p.zabel@pengutronix.de>, <airlied@linux.ie>, <daniel@ffwll.ch>,
	<jassisinghbrar@gmail.com>, <fparent@baylibre.com>,
	<yongqiang.niu@mediatek.com>, <hsinyi@chromium.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH V8 1/5] dt-bindings: display: mediatek: add aal binding for MT8183
Date: Thu, 17 Mar 2022 12:48:07 +0800	[thread overview]
Message-ID: <2f3c1f4461267644ab8e2b45e21c61591d245b01.camel@mediatek.com> (raw)
In-Reply-To: <cf765199-30c3-f963-4d9b-8f225efd5b32@canonical.com>

On Wed, 2022-03-16 at 16:18 +0100, Krzysztof Kozlowski wrote:
> On 16/03/2022 12:51, Rex-BC Chen wrote:
> > Add aal binding for MT8183.
> > 
> > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> > ---
> >  .../devicetree/bindings/display/mediatek/mediatek,aal.yaml    | 4
> > +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > index 61f0ed1e388f..eb0299b80522 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > @@ -22,7 +22,9 @@ properties:
> >    compatible:
> >      oneOf:
> >        - items:
> > -          - const: mediatek,mt8173-disp-aal
> > +          - enum:
> > +              - mediatek,mt8173-disp-aal
> > +              - mediatek,mt8183-disp-aal
> 
> This should not be under items. You have just one element here, so
> directly "enum" under oneOf.
> 
> 
> Best regards,
> Krzysztof

Hello Krzysztof,

OK, I will do this in next version.
Thanks!

BRs,
Rex


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	<chunkuang.hu@kernel.org>, <matthias.bgg@gmail.com>,
	<robh+dt@kernel.org>
Cc: <p.zabel@pengutronix.de>, <airlied@linux.ie>, <daniel@ffwll.ch>,
	<jassisinghbrar@gmail.com>, <fparent@baylibre.com>,
	<yongqiang.niu@mediatek.com>, <hsinyi@chromium.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH V8 1/5] dt-bindings: display: mediatek: add aal binding for MT8183
Date: Thu, 17 Mar 2022 12:48:07 +0800	[thread overview]
Message-ID: <2f3c1f4461267644ab8e2b45e21c61591d245b01.camel@mediatek.com> (raw)
In-Reply-To: <cf765199-30c3-f963-4d9b-8f225efd5b32@canonical.com>

On Wed, 2022-03-16 at 16:18 +0100, Krzysztof Kozlowski wrote:
> On 16/03/2022 12:51, Rex-BC Chen wrote:
> > Add aal binding for MT8183.
> > 
> > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> > ---
> >  .../devicetree/bindings/display/mediatek/mediatek,aal.yaml    | 4
> > +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > index 61f0ed1e388f..eb0299b80522 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > @@ -22,7 +22,9 @@ properties:
> >    compatible:
> >      oneOf:
> >        - items:
> > -          - const: mediatek,mt8173-disp-aal
> > +          - enum:
> > +              - mediatek,mt8173-disp-aal
> > +              - mediatek,mt8183-disp-aal
> 
> This should not be under items. You have just one element here, so
> directly "enum" under oneOf.
> 
> 
> Best regards,
> Krzysztof

Hello Krzysztof,

OK, I will do this in next version.
Thanks!

BRs,
Rex


  reply	other threads:[~2022-03-17  4:48 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-16 11:51 [PATCH V8 0/5] add display support for MediaTek SoC MT8186 Rex-BC Chen
2022-03-16 11:51 ` Rex-BC Chen
2022-03-16 11:51 ` Rex-BC Chen
2022-03-16 11:51 ` Rex-BC Chen
2022-03-16 11:51 ` [PATCH V8 1/5] dt-bindings: display: mediatek: add aal binding for MT8183 Rex-BC Chen
2022-03-16 11:51   ` Rex-BC Chen
2022-03-16 11:51   ` Rex-BC Chen
2022-03-16 11:51   ` Rex-BC Chen
2022-03-16 15:18   ` Krzysztof Kozlowski
2022-03-16 15:18     ` Krzysztof Kozlowski
2022-03-16 15:18     ` Krzysztof Kozlowski
2022-03-16 15:18     ` Krzysztof Kozlowski
2022-03-17  4:48     ` Rex-BC Chen [this message]
2022-03-17  4:48       ` Rex-BC Chen
2022-03-17  4:48       ` Rex-BC Chen
2022-03-17  4:48       ` Rex-BC Chen
2022-03-16 11:51 ` [PATCH V8 2/5] dt-bindings: display: mediatek: revise enum to const Rex-BC Chen
2022-03-16 11:51   ` Rex-BC Chen
2022-03-16 11:51   ` Rex-BC Chen
2022-03-16 11:51   ` Rex-BC Chen
2022-03-16 11:51 ` [PATCH V8 3/5] dt-bindings: display: mediatek: change to use enum for mutex Rex-BC Chen
2022-03-16 11:51   ` Rex-BC Chen
2022-03-16 11:51   ` Rex-BC Chen
2022-03-16 11:51   ` Rex-BC Chen
2022-03-16 11:51 ` [PATCH V8 4/5] dt-bindings: display: mediatek: add MT8186 SoC binding Rex-BC Chen
2022-03-16 11:51   ` Rex-BC Chen
2022-03-16 11:51   ` Rex-BC Chen
2022-03-16 11:51   ` Rex-BC Chen
2022-03-16 11:51 ` [PATCH V8 5/5] drm/mediatek: add display support for MT8186 Rex-BC Chen
2022-03-16 11:51   ` Rex-BC Chen
2022-03-16 11:51   ` Rex-BC Chen
2022-03-16 11:51   ` Rex-BC Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f3c1f4461267644ab8e2b45e21c61591d245b01.camel@mediatek.com \
    --to=rex-bc.chen@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=airlied@linux.ie \
    --cc=chunkuang.hu@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fparent@baylibre.com \
    --cc=hsinyi@chromium.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=yongqiang.niu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.