* [PATCH net-next v2] geneve: Get rid of is_all_zero(), streamline is_tnl_info_zero()
@ 2017-10-20 11:31 Stefano Brivio
2017-10-22 1:43 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stefano Brivio @ 2017-10-20 11:31 UTC (permalink / raw)
To: David S . Miller, netdev; +Cc: pravin shelar
No need to re-invent memchr_inv() with !is_all_zero(). While at
it, replace conditional and return clauses with a single return
clause in is_tnl_info_zero().
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
v2: Fix obvious "typos"
drivers/net/geneve.c | 19 +++----------------
1 file changed, 3 insertions(+), 16 deletions(-)
diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
index f6404074b7b0..01f7355ad277 100644
--- a/drivers/net/geneve.c
+++ b/drivers/net/geneve.c
@@ -1140,24 +1140,11 @@ static struct geneve_dev *geneve_find_dev(struct geneve_net *gn,
return t;
}
-static bool is_all_zero(const u8 *fp, size_t size)
-{
- int i;
-
- for (i = 0; i < size; i++)
- if (fp[i])
- return false;
- return true;
-}
-
static bool is_tnl_info_zero(const struct ip_tunnel_info *info)
{
- if (info->key.tun_id || info->key.tun_flags || info->key.tos ||
- info->key.ttl || info->key.label || info->key.tp_src ||
- !is_all_zero((const u8 *)&info->key.u, sizeof(info->key.u)))
- return false;
- else
- return true;
+ return !(info->key.tun_id || info->key.tun_flags || info->key.tos ||
+ info->key.ttl || info->key.label || info->key.tp_src ||
+ memchr_inv(&info->key.u, 0, sizeof(info->key.u)));
}
static bool geneve_dst_addr_equal(struct ip_tunnel_info *a,
--
2.9.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next v2] geneve: Get rid of is_all_zero(), streamline is_tnl_info_zero()
2017-10-20 11:31 [PATCH net-next v2] geneve: Get rid of is_all_zero(), streamline is_tnl_info_zero() Stefano Brivio
@ 2017-10-22 1:43 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-10-22 1:43 UTC (permalink / raw)
To: sbrivio; +Cc: netdev, pshelar
From: Stefano Brivio <sbrivio@redhat.com>
Date: Fri, 20 Oct 2017 13:31:36 +0200
> No need to re-invent memchr_inv() with !is_all_zero(). While at
> it, replace conditional and return clauses with a single return
> clause in is_tnl_info_zero().
>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-22 1:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-20 11:31 [PATCH net-next v2] geneve: Get rid of is_all_zero(), streamline is_tnl_info_zero() Stefano Brivio
2017-10-22 1:43 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.