From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jeff LaBundy <jeff@labundy.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: input: use generic node names
Date: Tue, 24 May 2022 13:28:24 +0200 [thread overview]
Message-ID: <2f49aa26-23f7-833c-b01d-9dfb2603603c@linaro.org> (raw)
In-Reply-To: <20220524131152.3d749a9d@aktux>
On 24/05/2022 13:11, Andreas Kemnade wrote:
> Hi,
>
> On Tue, 24 May 2022 11:31:36 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>
>> diff --git a/Documentation/devicetree/bindings/input/gpio-keys.yaml b/Documentation/devicetree/bindings/input/gpio-keys.yaml
>> index 7fe1966ea28a..93f601c58984 100644
>> --- a/Documentation/devicetree/bindings/input/gpio-keys.yaml
>> +++ b/Documentation/devicetree/bindings/input/gpio-keys.yaml
>> @@ -127,13 +127,13 @@ examples:
>> compatible = "gpio-keys";
>> autorepeat;
>>
>> - up {
>> + key-up {
>> label = "GPIO Key UP";
>> linux,code = <103>;
>> gpios = <&gpio1 0 1>;
>> };
>>
>> - down {
>> + key-down {
>> label = "GPIO Key DOWN";
>> linux,code = <108>;
>> interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> hmm, what about changing
> patternProperties:
> ".*":
>
> to enforce this format instead of allowing anything?
It will cause a lot, a lot of warnings, so first these would need to be
fixed in every DTS. That's also doable, might help if these gpio-keys
bindings need any other object like property.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-24 11:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 9:31 [PATCH] dt-bindings: input: use generic node names Krzysztof Kozlowski
2022-05-24 11:11 ` Andreas Kemnade
2022-05-24 11:28 ` Krzysztof Kozlowski [this message]
2022-05-26 2:20 ` Rob Herring
2022-05-27 22:44 ` Jeff LaBundy
2022-05-29 14:21 ` Krzysztof Kozlowski
2022-05-28 20:41 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f49aa26-23f7-833c-b01d-9dfb2603603c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jeff@labundy.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.