* [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'
@ 2022-11-16 13:17 Vaibhav Jain
2022-11-16 15:20 ` Greg Kurz
` (3 more replies)
0 siblings, 4 replies; 15+ messages in thread
From: Vaibhav Jain @ 2022-11-16 13:17 UTC (permalink / raw)
To: qemu-devel, qemu-ppc
Cc: Vaibhav Jain, david, clg, Daniel Henrique Barboza, groug,
Kowshik Jois B S
Kowshik reported that building qemu with GCC 12.2.1 for 'ppc64-softmmu'
target is failing due to following build warnings:
<snip>
../target/ppc/cpu_init.c:7018:13: error: 'ppc_restore_state_to_opc' defined but not used [-Werror=unused-function]
7018 | static void ppc_restore_state_to_opc(CPUState *cs,
<snip>
Fix this by wrapping these function definitions in 'ifdef CONFIG_TCG' so that
they are only defined if qemu is compiled with '--enable-tcg'
Reported-by: Kowshik Jois B S <kowsjois@linux.ibm.com>
Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
---
target/ppc/cpu_init.c | 2 ++
target/ppc/excp_helper.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c
index 32e94153d1..cbf0081374 100644
--- a/target/ppc/cpu_init.c
+++ b/target/ppc/cpu_init.c
@@ -7015,6 +7015,7 @@ static vaddr ppc_cpu_get_pc(CPUState *cs)
return cpu->env.nip;
}
+#ifdef CONFIG_TCG
static void ppc_restore_state_to_opc(CPUState *cs,
const TranslationBlock *tb,
const uint64_t *data)
@@ -7023,6 +7024,7 @@ static void ppc_restore_state_to_opc(CPUState *cs,
cpu->env.nip = data[0];
}
+#endif /* CONFIG_TCG */
static bool ppc_cpu_has_work(CPUState *cs)
{
diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index a05a2ed595..94adcb766b 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -2842,6 +2842,7 @@ void helper_td(CPUPPCState *env, target_ulong arg1, target_ulong arg2,
#endif
#endif
+#ifdef CONFIG_TCG
static uint32_t helper_SIMON_LIKE_32_64(uint32_t x, uint64_t key, uint32_t lane)
{
const uint16_t c = 0xfffc;
@@ -2924,6 +2925,7 @@ HELPER_HASH(HASHST, env->spr[SPR_HASHKEYR], true)
HELPER_HASH(HASHCHK, env->spr[SPR_HASHKEYR], false)
HELPER_HASH(HASHSTP, env->spr[SPR_HASHPKEYR], true)
HELPER_HASH(HASHCHKP, env->spr[SPR_HASHPKEYR], false)
+#endif /* CONFIG_TCG */
#if !defined(CONFIG_USER_ONLY)
--
2.38.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'
2022-11-16 13:17 [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg' Vaibhav Jain
@ 2022-11-16 15:20 ` Greg Kurz
2022-11-16 15:30 ` Philippe Mathieu-Daudé
2022-11-17 2:13 ` Vaibhav Jain
2022-11-16 15:27 ` [PATCH-for-7.2] " Philippe Mathieu-Daudé
` (2 subsequent siblings)
3 siblings, 2 replies; 15+ messages in thread
From: Greg Kurz @ 2022-11-16 15:20 UTC (permalink / raw)
To: Vaibhav Jain
Cc: qemu-devel, qemu-ppc, david, clg, Daniel Henrique Barboza,
Kowshik Jois B S
Hi Vaibhav,
Nice to see some people are still building QEMU at IBM ;-)
On Wed, 16 Nov 2022 18:47:43 +0530
Vaibhav Jain <vaibhav@linux.ibm.com> wrote:
> Kowshik reported that building qemu with GCC 12.2.1 for 'ppc64-softmmu'
> target is failing due to following build warnings:
>
> <snip>
> ../target/ppc/cpu_init.c:7018:13: error: 'ppc_restore_state_to_opc' defined but not used [-Werror=unused-function]
> 7018 | static void ppc_restore_state_to_opc(CPUState *cs,
> <snip>
>
> Fix this by wrapping these function definitions in 'ifdef CONFIG_TCG' so that
> they are only defined if qemu is compiled with '--enable-tcg'
>
> Reported-by: Kowshik Jois B S <kowsjois@linux.ibm.com>
> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
> ---
Reviewed-by: Greg Kurz <groug@kaod.org>
This was introduced by a recent commit.
Fixes: 61bd1d29421a ("target/ppc: Convert to tcg_ops restore_state_to_opc")
Vaibhav,
This is serious enough it should get fixed in 7.2. Please fill up an
issue as explain in [1].
Cheers,
--
Greg
[1] https://lists.nongnu.org/archive/html/qemu-devel/2022-11/msg00137.html
> target/ppc/cpu_init.c | 2 ++
> target/ppc/excp_helper.c | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c
> index 32e94153d1..cbf0081374 100644
> --- a/target/ppc/cpu_init.c
> +++ b/target/ppc/cpu_init.c
> @@ -7015,6 +7015,7 @@ static vaddr ppc_cpu_get_pc(CPUState *cs)
> return cpu->env.nip;
> }
>
> +#ifdef CONFIG_TCG
> static void ppc_restore_state_to_opc(CPUState *cs,
> const TranslationBlock *tb,
> const uint64_t *data)
> @@ -7023,6 +7024,7 @@ static void ppc_restore_state_to_opc(CPUState *cs,
>
> cpu->env.nip = data[0];
> }
> +#endif /* CONFIG_TCG */
>
> static bool ppc_cpu_has_work(CPUState *cs)
> {
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index a05a2ed595..94adcb766b 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -2842,6 +2842,7 @@ void helper_td(CPUPPCState *env, target_ulong arg1, target_ulong arg2,
> #endif
> #endif
>
> +#ifdef CONFIG_TCG
> static uint32_t helper_SIMON_LIKE_32_64(uint32_t x, uint64_t key, uint32_t lane)
> {
> const uint16_t c = 0xfffc;
> @@ -2924,6 +2925,7 @@ HELPER_HASH(HASHST, env->spr[SPR_HASHKEYR], true)
> HELPER_HASH(HASHCHK, env->spr[SPR_HASHKEYR], false)
> HELPER_HASH(HASHSTP, env->spr[SPR_HASHPKEYR], true)
> HELPER_HASH(HASHCHKP, env->spr[SPR_HASHPKEYR], false)
> +#endif /* CONFIG_TCG */
>
> #if !defined(CONFIG_USER_ONLY)
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH-for-7.2] target/ppc: Fix build warnings when building with 'disable-tcg'
2022-11-16 13:17 [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg' Vaibhav Jain
2022-11-16 15:20 ` Greg Kurz
@ 2022-11-16 15:27 ` Philippe Mathieu-Daudé
2022-11-17 2:23 ` Vaibhav Jain
2022-11-17 7:34 ` [PATCH] " Kowshik Jois B S
2022-11-17 10:11 ` Daniel Henrique Barboza
3 siblings, 1 reply; 15+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-11-16 15:27 UTC (permalink / raw)
To: Vaibhav Jain, qemu-devel, qemu-ppc, Richard Henderson
Cc: david, clg, Daniel Henrique Barboza, groug, Kowshik Jois B S
On 16/11/22 14:17, Vaibhav Jain wrote:
> Kowshik reported that building qemu with GCC 12.2.1 for 'ppc64-softmmu'
> target is failing due to following build warnings:
>
> <snip>
> ../target/ppc/cpu_init.c:7018:13: error: 'ppc_restore_state_to_opc' defined but not used [-Werror=unused-function]
> 7018 | static void ppc_restore_state_to_opc(CPUState *cs,
> <snip>
>
> Fix this by wrapping these function definitions in 'ifdef CONFIG_TCG' so that
> they are only defined if qemu is compiled with '--enable-tcg'
>
> Reported-by: Kowshik Jois B S <kowsjois@linux.ibm.com>
> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
> ---
> target/ppc/cpu_init.c | 2 ++
> target/ppc/excp_helper.c | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c
> index 32e94153d1..cbf0081374 100644
> --- a/target/ppc/cpu_init.c
> +++ b/target/ppc/cpu_init.c
> @@ -7015,6 +7015,7 @@ static vaddr ppc_cpu_get_pc(CPUState *cs)
> return cpu->env.nip;
> }
>
> +#ifdef CONFIG_TCG
> static void ppc_restore_state_to_opc(CPUState *cs,
> const TranslationBlock *tb,
> const uint64_t *data)
> @@ -7023,6 +7024,7 @@ static void ppc_restore_state_to_opc(CPUState *cs,
>
> cpu->env.nip = data[0];
> }
> +#endif /* CONFIG_TCG */
Oops sorry.
Fixes: 61bd1d2942 ("target/ppc: Convert to tcg_ops restore_state_to_opc")
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index a05a2ed595..94adcb766b 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -2842,6 +2842,7 @@ void helper_td(CPUPPCState *env, target_ulong arg1, target_ulong arg2,
> #endif
> #endif
>
> +#ifdef CONFIG_TCG
> static uint32_t helper_SIMON_LIKE_32_64(uint32_t x, uint64_t key, uint32_t lane)
> {
> const uint16_t c = 0xfffc;
> @@ -2924,6 +2925,7 @@ HELPER_HASH(HASHST, env->spr[SPR_HASHKEYR], true)
> HELPER_HASH(HASHCHK, env->spr[SPR_HASHKEYR], false)
> HELPER_HASH(HASHSTP, env->spr[SPR_HASHPKEYR], true)
> HELPER_HASH(HASHCHKP, env->spr[SPR_HASHPKEYR], false)
> +#endif /* CONFIG_TCG */
Fixes: 670f1da374 ("target/ppc: Implement hashst and hashchk")
Hmm this is another fix... You could split your patch in 2,
but not a big deal. Regardless:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'
2022-11-16 15:20 ` Greg Kurz
@ 2022-11-16 15:30 ` Philippe Mathieu-Daudé
2022-11-17 8:24 ` Thomas Huth
2022-11-17 2:13 ` Vaibhav Jain
1 sibling, 1 reply; 15+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-11-16 15:30 UTC (permalink / raw)
To: Greg Kurz, Vaibhav Jain
Cc: qemu-devel, qemu-ppc, david, clg, Daniel Henrique Barboza,
Kowshik Jois B S
On 16/11/22 16:20, Greg Kurz wrote:
> Hi Vaibhav,
>
> Nice to see some people are still building QEMU at IBM ;-)
>
> On Wed, 16 Nov 2022 18:47:43 +0530
> Vaibhav Jain <vaibhav@linux.ibm.com> wrote:
>
>> Kowshik reported that building qemu with GCC 12.2.1 for 'ppc64-softmmu'
>> target is failing due to following build warnings:
>>
>> <snip>
>> ../target/ppc/cpu_init.c:7018:13: error: 'ppc_restore_state_to_opc' defined but not used [-Werror=unused-function]
>> 7018 | static void ppc_restore_state_to_opc(CPUState *cs,
>> <snip>
>>
>> Fix this by wrapping these function definitions in 'ifdef CONFIG_TCG' so that
>> they are only defined if qemu is compiled with '--enable-tcg'
Interestingly this config isn't covered in
.gitlab-ci.d/custom-runners/ubuntu-20.04-s390x.yml.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'
2022-11-16 15:20 ` Greg Kurz
2022-11-16 15:30 ` Philippe Mathieu-Daudé
@ 2022-11-17 2:13 ` Vaibhav Jain
2022-11-17 6:49 ` Cédric Le Goater
1 sibling, 1 reply; 15+ messages in thread
From: Vaibhav Jain @ 2022-11-17 2:13 UTC (permalink / raw)
To: Greg Kurz
Cc: qemu-devel, qemu-ppc, david, clg, Daniel Henrique Barboza,
Kowshik Jois B S
Greg Kurz <groug@kaod.org> writes:
> Hi Vaibhav,
>
Hey Greg,
Good to see you,
> Nice to see some people are still building QEMU at IBM ;-)
Yeah, and will hopefully continue to do this in future :-)
<snip>
>> Reported-by: Kowshik Jois B S <kowsjois@linux.ibm.com>
>> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
>> ---
>
> Reviewed-by: Greg Kurz <groug@kaod.org>
>
Thanks
> This was introduced by a recent commit.
>
> Fixes: 61bd1d29421a ("target/ppc: Convert to tcg_ops restore_state_to_opc")
Thanks again for pointing out the commit that caused this.
>
>
> Vaibhav,
>
> This is serious enough it should get fixed in 7.2. Please fill up an
> issue as explain in [1].
I have raised an issue on gitlab at
https://gitlab.com/qemu-project/qemu/-/issues/1319
--
Cheers
~ Vaibhav
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH-for-7.2] target/ppc: Fix build warnings when building with 'disable-tcg'
2022-11-16 15:27 ` [PATCH-for-7.2] " Philippe Mathieu-Daudé
@ 2022-11-17 2:23 ` Vaibhav Jain
0 siblings, 0 replies; 15+ messages in thread
From: Vaibhav Jain @ 2022-11-17 2:23 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel, qemu-ppc, Richard Henderson
Cc: david, clg, Daniel Henrique Barboza, groug, Kowshik Jois B S
Hi Philippe,
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
>
> Oops sorry.
>
> Fixes: 61bd1d2942 ("target/ppc: Convert to tcg_ops restore_state_to_opc")
Thanks for figuring and pointing this out
>
>> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
>> index a05a2ed595..94adcb766b 100644
>> --- a/target/ppc/excp_helper.c
>> +++ b/target/ppc/excp_helper.c
>> @@ -2842,6 +2842,7 @@ void helper_td(CPUPPCState *env, target_ulong arg1, target_ulong arg2,
>> #endif
>> #endif
>>
>> +#ifdef CONFIG_TCG
>> static uint32_t helper_SIMON_LIKE_32_64(uint32_t x, uint64_t key, uint32_t lane)
>> {
>> const uint16_t c = 0xfffc;
>> @@ -2924,6 +2925,7 @@ HELPER_HASH(HASHST, env->spr[SPR_HASHKEYR], true)
>> HELPER_HASH(HASHCHK, env->spr[SPR_HASHKEYR], false)
>> HELPER_HASH(HASHSTP, env->spr[SPR_HASHPKEYR], true)
>> HELPER_HASH(HASHCHKP, env->spr[SPR_HASHPKEYR], false)
>> +#endif /* CONFIG_TCG */
>
> Fixes: 670f1da374 ("target/ppc: Implement hashst and hashchk")
>
Thanks
> Hmm this is another fix... You could split your patch in 2,
> but not a big deal. Regardless:
This being a trivial patch, descided against splitting it in 2.
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Thanks,
--
Cheers
~ Vaibhav
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'
2022-11-17 2:13 ` Vaibhav Jain
@ 2022-11-17 6:49 ` Cédric Le Goater
0 siblings, 0 replies; 15+ messages in thread
From: Cédric Le Goater @ 2022-11-17 6:49 UTC (permalink / raw)
To: Vaibhav Jain, Greg Kurz
Cc: qemu-devel, qemu-ppc, david, Daniel Henrique Barboza, Kowshik Jois B S
On 11/17/22 03:13, Vaibhav Jain wrote:
> Greg Kurz <groug@kaod.org> writes:
>
>> Hi Vaibhav,
>>
> Hey Greg,
>
> Good to see you,
>
>> Nice to see some people are still building QEMU at IBM ;-)
> Yeah, and will hopefully continue to do this in future :-)
>
> <snip>
>>> Reported-by: Kowshik Jois B S <kowsjois@linux.ibm.com>
>>> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
>>> ---
>>
>> Reviewed-by: Greg Kurz <groug@kaod.org>
>>
> Thanks
>
>> This was introduced by a recent commit.
>>
>> Fixes: 61bd1d29421a ("target/ppc: Convert to tcg_ops restore_state_to_opc")
> Thanks again for pointing out the commit that caused this.
>
>>
>>
>> Vaibhav,
>>
>> This is serious enough it should get fixed in 7.2. Please fill up an
>> issue as explain in [1].
> I have raised an issue on gitlab at
> https://gitlab.com/qemu-project/qemu/-/issues/1319
>
And so,
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/377
Thanks,
C.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'
2022-11-16 13:17 [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg' Vaibhav Jain
2022-11-16 15:20 ` Greg Kurz
2022-11-16 15:27 ` [PATCH-for-7.2] " Philippe Mathieu-Daudé
@ 2022-11-17 7:34 ` Kowshik Jois B S
2022-11-17 10:11 ` Daniel Henrique Barboza
3 siblings, 0 replies; 15+ messages in thread
From: Kowshik Jois B S @ 2022-11-17 7:34 UTC (permalink / raw)
To: Vaibhav Jain, qemu-devel, qemu-ppc
Cc: david, clg, Daniel Henrique Barboza, groug
Hello Vaibhav,
Thanks for the quick resolution. I have applied and tested the patch.
Everything is smooth. Thank you.
Regards,
Kowshik Jois
On 16/11/22 18:47, Vaibhav Jain wrote:
> Kowshik reported that building qemu with GCC 12.2.1 for 'ppc64-softmmu'
> target is failing due to following build warnings:
>
> <snip>
> ../target/ppc/cpu_init.c:7018:13: error: 'ppc_restore_state_to_opc' defined but not used [-Werror=unused-function]
> 7018 | static void ppc_restore_state_to_opc(CPUState *cs,
> <snip>
>
> Fix this by wrapping these function definitions in 'ifdef CONFIG_TCG' so that
> they are only defined if qemu is compiled with '--enable-tcg'
>
> Reported-by: Kowshik Jois B S <kowsjois@linux.ibm.com>
> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
> ---
> target/ppc/cpu_init.c | 2 ++
> target/ppc/excp_helper.c | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c
> index 32e94153d1..cbf0081374 100644
> --- a/target/ppc/cpu_init.c
> +++ b/target/ppc/cpu_init.c
> @@ -7015,6 +7015,7 @@ static vaddr ppc_cpu_get_pc(CPUState *cs)
> return cpu->env.nip;
> }
>
> +#ifdef CONFIG_TCG
> static void ppc_restore_state_to_opc(CPUState *cs,
> const TranslationBlock *tb,
> const uint64_t *data)
> @@ -7023,6 +7024,7 @@ static void ppc_restore_state_to_opc(CPUState *cs,
>
> cpu->env.nip = data[0];
> }
> +#endif /* CONFIG_TCG */
>
> static bool ppc_cpu_has_work(CPUState *cs)
> {
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index a05a2ed595..94adcb766b 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -2842,6 +2842,7 @@ void helper_td(CPUPPCState *env, target_ulong arg1, target_ulong arg2,
> #endif
> #endif
>
> +#ifdef CONFIG_TCG
> static uint32_t helper_SIMON_LIKE_32_64(uint32_t x, uint64_t key, uint32_t lane)
> {
> const uint16_t c = 0xfffc;
> @@ -2924,6 +2925,7 @@ HELPER_HASH(HASHST, env->spr[SPR_HASHKEYR], true)
> HELPER_HASH(HASHCHK, env->spr[SPR_HASHKEYR], false)
> HELPER_HASH(HASHSTP, env->spr[SPR_HASHPKEYR], true)
> HELPER_HASH(HASHCHKP, env->spr[SPR_HASHPKEYR], false)
> +#endif /* CONFIG_TCG */
>
> #if !defined(CONFIG_USER_ONLY)
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'
2022-11-16 15:30 ` Philippe Mathieu-Daudé
@ 2022-11-17 8:24 ` Thomas Huth
0 siblings, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2022-11-17 8:24 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Greg Kurz, Vaibhav Jain
Cc: qemu-devel, qemu-ppc, david, clg, Daniel Henrique Barboza,
Kowshik Jois B S
On 16/11/2022 16.30, Philippe Mathieu-Daudé wrote:
> On 16/11/22 16:20, Greg Kurz wrote:
>> Hi Vaibhav,
>>
>> Nice to see some people are still building QEMU at IBM ;-)
>>
>> On Wed, 16 Nov 2022 18:47:43 +0530
>> Vaibhav Jain <vaibhav@linux.ibm.com> wrote:
>>
>>> Kowshik reported that building qemu with GCC 12.2.1 for 'ppc64-softmmu'
>>> target is failing due to following build warnings:
>>>
>>> <snip>
>>> ../target/ppc/cpu_init.c:7018:13: error: 'ppc_restore_state_to_opc'
>>> defined but not used [-Werror=unused-function]
>>> 7018 | static void ppc_restore_state_to_opc(CPUState *cs,
>>> <snip>
>>>
>>> Fix this by wrapping these function definitions in 'ifdef CONFIG_TCG' so
>>> that
>>> they are only defined if qemu is compiled with '--enable-tcg'
>
> Interestingly this config isn't covered in
> .gitlab-ci.d/custom-runners/ubuntu-20.04-s390x.yml.
Why should it be tested there? s390x is not ppc64.
If you want to test this, you either have to do it with a cross compiler (in
.gitlab-ci.d/crossbuilds.yml) or in .travis.yml on a ppc64 host.
Thomas
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'
2022-11-16 13:17 [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg' Vaibhav Jain
` (2 preceding siblings ...)
2022-11-17 7:34 ` [PATCH] " Kowshik Jois B S
@ 2022-11-17 10:11 ` Daniel Henrique Barboza
2022-11-17 10:35 ` Vaibhav Jain
2022-11-17 10:50 ` Greg Kurz
3 siblings, 2 replies; 15+ messages in thread
From: Daniel Henrique Barboza @ 2022-11-17 10:11 UTC (permalink / raw)
To: Vaibhav Jain, qemu-devel, qemu-ppc; +Cc: david, clg, groug, Kowshik Jois B S
Queued in gitlab.com/danielhb/qemu/tree/ppc-next with the following tags:
Reported-by: Kowshik Jois B S <kowsjois@linux.ibm.com>
Fixes: 61bd1d2942 ("target/ppc: Convert to tcg_ops restore_state_to_opc")
Fixes: 670f1da374 ("target/ppc: Implement hashst and hashchk")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/377
Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Kowshik Jois B S <kowsjois@linux.vnet.ibm.com>
Thanks,
Daniel
On 11/16/22 10:17, Vaibhav Jain wrote:
> Kowshik reported that building qemu with GCC 12.2.1 for 'ppc64-softmmu'
> target is failing due to following build warnings:
>
> <snip>
> ../target/ppc/cpu_init.c:7018:13: error: 'ppc_restore_state_to_opc' defined but not used [-Werror=unused-function]
> 7018 | static void ppc_restore_state_to_opc(CPUState *cs,
> <snip>
>
> Fix this by wrapping these function definitions in 'ifdef CONFIG_TCG' so that
> they are only defined if qemu is compiled with '--enable-tcg'
>
> Reported-by: Kowshik Jois B S <kowsjois@linux.ibm.com>
> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
> ---
> target/ppc/cpu_init.c | 2 ++
> target/ppc/excp_helper.c | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c
> index 32e94153d1..cbf0081374 100644
> --- a/target/ppc/cpu_init.c
> +++ b/target/ppc/cpu_init.c
> @@ -7015,6 +7015,7 @@ static vaddr ppc_cpu_get_pc(CPUState *cs)
> return cpu->env.nip;
> }
>
> +#ifdef CONFIG_TCG
> static void ppc_restore_state_to_opc(CPUState *cs,
> const TranslationBlock *tb,
> const uint64_t *data)
> @@ -7023,6 +7024,7 @@ static void ppc_restore_state_to_opc(CPUState *cs,
>
> cpu->env.nip = data[0];
> }
> +#endif /* CONFIG_TCG */
>
> static bool ppc_cpu_has_work(CPUState *cs)
> {
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index a05a2ed595..94adcb766b 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -2842,6 +2842,7 @@ void helper_td(CPUPPCState *env, target_ulong arg1, target_ulong arg2,
> #endif
> #endif
>
> +#ifdef CONFIG_TCG
> static uint32_t helper_SIMON_LIKE_32_64(uint32_t x, uint64_t key, uint32_t lane)
> {
> const uint16_t c = 0xfffc;
> @@ -2924,6 +2925,7 @@ HELPER_HASH(HASHST, env->spr[SPR_HASHKEYR], true)
> HELPER_HASH(HASHCHK, env->spr[SPR_HASHKEYR], false)
> HELPER_HASH(HASHSTP, env->spr[SPR_HASHPKEYR], true)
> HELPER_HASH(HASHCHKP, env->spr[SPR_HASHPKEYR], false)
> +#endif /* CONFIG_TCG */
>
> #if !defined(CONFIG_USER_ONLY)
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'
2022-11-17 10:11 ` Daniel Henrique Barboza
@ 2022-11-17 10:35 ` Vaibhav Jain
2022-11-17 14:23 ` Daniel Henrique Barboza
2022-11-17 10:50 ` Greg Kurz
1 sibling, 1 reply; 15+ messages in thread
From: Vaibhav Jain @ 2022-11-17 10:35 UTC (permalink / raw)
To: Daniel Henrique Barboza, qemu-devel, qemu-ppc
Cc: david, clg, groug, Kowshik Jois B S
Hi Daniel,
Thanks for quick turnaround on this,
Minor correction to the commit tags below:
Daniel Henrique Barboza <danielhb413@gmail.com> writes:
> Queued in gitlab.com/danielhb/qemu/tree/ppc-next with the following tags:
>
>
> Reported-by: Kowshik Jois B S <kowsjois@linux.ibm.com>
> Fixes: 61bd1d2942 ("target/ppc: Convert to tcg_ops restore_state_to_opc")
> Fixes: 670f1da374 ("target/ppc: Implement hashst and hashchk")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/377
This should be
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1319
> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
> Reviewed-by: Greg Kurz <groug@kaod.org>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Tested-by: Kowshik Jois B S <kowsjois@linux.vnet.ibm.com>
>
--
Cheers
~ Vaibhav
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'
2022-11-17 10:11 ` Daniel Henrique Barboza
2022-11-17 10:35 ` Vaibhav Jain
@ 2022-11-17 10:50 ` Greg Kurz
2022-11-17 13:08 ` Cédric Le Goater
2022-11-17 14:27 ` Daniel Henrique Barboza
1 sibling, 2 replies; 15+ messages in thread
From: Greg Kurz @ 2022-11-17 10:50 UTC (permalink / raw)
To: Daniel Henrique Barboza
Cc: Vaibhav Jain, qemu-devel, qemu-ppc, david, clg, Kowshik Jois B S
On Thu, 17 Nov 2022 07:11:51 -0300
Daniel Henrique Barboza <danielhb413@gmail.com> wrote:
> Queued in gitlab.com/danielhb/qemu/tree/ppc-next with the following tags:
>
You are planning a PR before 7.2-rc2, right ?
>
> Reported-by: Kowshik Jois B S <kowsjois@linux.ibm.com>
> Fixes: 61bd1d2942 ("target/ppc: Convert to tcg_ops restore_state_to_opc")
> Fixes: 670f1da374 ("target/ppc: Implement hashst and hashchk")
The guard macro also covers the following two, introduced by yet another commit.
HELPER_HASH(HASHSTP, env->spr[SPR_HASHPKEYR], true)
HELPER_HASH(HASHCHKP, env->spr[SPR_HASHPKEYR], false)
Fixes: 53ae2aeb9407 ("target/ppc: Implement hashstp and hashchkp")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/377
Err... I don't see any relation with this issue.
Cedric ?
But this resolves the issue created by Vaibhav for 7.2 :
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1319
> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
> Reviewed-by: Greg Kurz <groug@kaod.org>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Tested-by: Kowshik Jois B S <kowsjois@linux.vnet.ibm.com>
>
>
> Thanks,
>
>
> Daniel
>
> On 11/16/22 10:17, Vaibhav Jain wrote:
> > Kowshik reported that building qemu with GCC 12.2.1 for 'ppc64-softmmu'
> > target is failing due to following build warnings:
> >
> > <snip>
> > ../target/ppc/cpu_init.c:7018:13: error: 'ppc_restore_state_to_opc' defined but not used [-Werror=unused-function]
> > 7018 | static void ppc_restore_state_to_opc(CPUState *cs,
> > <snip>
> >
> > Fix this by wrapping these function definitions in 'ifdef CONFIG_TCG' so that
> > they are only defined if qemu is compiled with '--enable-tcg'
> >
> > Reported-by: Kowshik Jois B S <kowsjois@linux.ibm.com>
> > Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
> > ---
> > target/ppc/cpu_init.c | 2 ++
> > target/ppc/excp_helper.c | 2 ++
> > 2 files changed, 4 insertions(+)
> >
> > diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c
> > index 32e94153d1..cbf0081374 100644
> > --- a/target/ppc/cpu_init.c
> > +++ b/target/ppc/cpu_init.c
> > @@ -7015,6 +7015,7 @@ static vaddr ppc_cpu_get_pc(CPUState *cs)
> > return cpu->env.nip;
> > }
> >
> > +#ifdef CONFIG_TCG
> > static void ppc_restore_state_to_opc(CPUState *cs,
> > const TranslationBlock *tb,
> > const uint64_t *data)
> > @@ -7023,6 +7024,7 @@ static void ppc_restore_state_to_opc(CPUState *cs,
> >
> > cpu->env.nip = data[0];
> > }
> > +#endif /* CONFIG_TCG */
> >
> > static bool ppc_cpu_has_work(CPUState *cs)
> > {
> > diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> > index a05a2ed595..94adcb766b 100644
> > --- a/target/ppc/excp_helper.c
> > +++ b/target/ppc/excp_helper.c
> > @@ -2842,6 +2842,7 @@ void helper_td(CPUPPCState *env, target_ulong arg1, target_ulong arg2,
> > #endif
> > #endif
> >
> > +#ifdef CONFIG_TCG
> > static uint32_t helper_SIMON_LIKE_32_64(uint32_t x, uint64_t key, uint32_t lane)
> > {
> > const uint16_t c = 0xfffc;
> > @@ -2924,6 +2925,7 @@ HELPER_HASH(HASHST, env->spr[SPR_HASHKEYR], true)
> > HELPER_HASH(HASHCHK, env->spr[SPR_HASHKEYR], false)
> > HELPER_HASH(HASHSTP, env->spr[SPR_HASHPKEYR], true)
> > HELPER_HASH(HASHCHKP, env->spr[SPR_HASHPKEYR], false)
> > +#endif /* CONFIG_TCG */
> >
> > #if !defined(CONFIG_USER_ONLY)
> >
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'
2022-11-17 10:50 ` Greg Kurz
@ 2022-11-17 13:08 ` Cédric Le Goater
2022-11-17 14:27 ` Daniel Henrique Barboza
1 sibling, 0 replies; 15+ messages in thread
From: Cédric Le Goater @ 2022-11-17 13:08 UTC (permalink / raw)
To: Greg Kurz, Daniel Henrique Barboza
Cc: Vaibhav Jain, qemu-devel, qemu-ppc, david, Kowshik Jois B S
On 11/17/22 11:50, Greg Kurz wrote:
> On Thu, 17 Nov 2022 07:11:51 -0300
> Daniel Henrique Barboza <danielhb413@gmail.com> wrote:
>
>> Queued in gitlab.com/danielhb/qemu/tree/ppc-next with the following tags:
>>
>
> You are planning a PR before 7.2-rc2, right ?
>
>>
>> Reported-by: Kowshik Jois B S <kowsjois@linux.ibm.com>
>> Fixes: 61bd1d2942 ("target/ppc: Convert to tcg_ops restore_state_to_opc")
>> Fixes: 670f1da374 ("target/ppc: Implement hashst and hashchk")
>
> The guard macro also covers the following two, introduced by yet another commit.
>
> HELPER_HASH(HASHSTP, env->spr[SPR_HASHPKEYR], true)
> HELPER_HASH(HASHCHKP, env->spr[SPR_HASHPKEYR], false)
>
> Fixes: 53ae2aeb9407 ("target/ppc: Implement hashstp and hashchkp")
>
>> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/377
>
> Err... I don't see any relation with this issue.
>
> Cedric ?
bad copy paste. Sorry about that.
> But this resolves the issue created by Vaibhav for 7.2 :
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1319
yes.
C.
>
>> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
>> Reviewed-by: Greg Kurz <groug@kaod.org>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> Tested-by: Kowshik Jois B S <kowsjois@linux.vnet.ibm.com>
>>
>>
>> Thanks,
>>
>>
>> Daniel
>>
>> On 11/16/22 10:17, Vaibhav Jain wrote:
>>> Kowshik reported that building qemu with GCC 12.2.1 for 'ppc64-softmmu'
>>> target is failing due to following build warnings:
>>>
>>> <snip>
>>> ../target/ppc/cpu_init.c:7018:13: error: 'ppc_restore_state_to_opc' defined but not used [-Werror=unused-function]
>>> 7018 | static void ppc_restore_state_to_opc(CPUState *cs,
>>> <snip>
>>>
>>> Fix this by wrapping these function definitions in 'ifdef CONFIG_TCG' so that
>>> they are only defined if qemu is compiled with '--enable-tcg'
>>>
>>> Reported-by: Kowshik Jois B S <kowsjois@linux.ibm.com>
>>> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
>>> ---
>>> target/ppc/cpu_init.c | 2 ++
>>> target/ppc/excp_helper.c | 2 ++
>>> 2 files changed, 4 insertions(+)
>>>
>>> diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c
>>> index 32e94153d1..cbf0081374 100644
>>> --- a/target/ppc/cpu_init.c
>>> +++ b/target/ppc/cpu_init.c
>>> @@ -7015,6 +7015,7 @@ static vaddr ppc_cpu_get_pc(CPUState *cs)
>>> return cpu->env.nip;
>>> }
>>>
>>> +#ifdef CONFIG_TCG
>>> static void ppc_restore_state_to_opc(CPUState *cs,
>>> const TranslationBlock *tb,
>>> const uint64_t *data)
>>> @@ -7023,6 +7024,7 @@ static void ppc_restore_state_to_opc(CPUState *cs,
>>>
>>> cpu->env.nip = data[0];
>>> }
>>> +#endif /* CONFIG_TCG */
>>>
>>> static bool ppc_cpu_has_work(CPUState *cs)
>>> {
>>> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
>>> index a05a2ed595..94adcb766b 100644
>>> --- a/target/ppc/excp_helper.c
>>> +++ b/target/ppc/excp_helper.c
>>> @@ -2842,6 +2842,7 @@ void helper_td(CPUPPCState *env, target_ulong arg1, target_ulong arg2,
>>> #endif
>>> #endif
>>>
>>> +#ifdef CONFIG_TCG
>>> static uint32_t helper_SIMON_LIKE_32_64(uint32_t x, uint64_t key, uint32_t lane)
>>> {
>>> const uint16_t c = 0xfffc;
>>> @@ -2924,6 +2925,7 @@ HELPER_HASH(HASHST, env->spr[SPR_HASHKEYR], true)
>>> HELPER_HASH(HASHCHK, env->spr[SPR_HASHKEYR], false)
>>> HELPER_HASH(HASHSTP, env->spr[SPR_HASHPKEYR], true)
>>> HELPER_HASH(HASHCHKP, env->spr[SPR_HASHPKEYR], false)
>>> +#endif /* CONFIG_TCG */
>>>
>>> #if !defined(CONFIG_USER_ONLY)
>>>
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'
2022-11-17 10:35 ` Vaibhav Jain
@ 2022-11-17 14:23 ` Daniel Henrique Barboza
0 siblings, 0 replies; 15+ messages in thread
From: Daniel Henrique Barboza @ 2022-11-17 14:23 UTC (permalink / raw)
To: Vaibhav Jain, qemu-devel, qemu-ppc; +Cc: david, clg, groug, Kowshik Jois B S
On 11/17/22 07:35, Vaibhav Jain wrote:
>
> Hi Daniel,
>
> Thanks for quick turnaround on this,
>
> Minor correction to the commit tags below:
>
> Daniel Henrique Barboza <danielhb413@gmail.com> writes:
>
>> Queued in gitlab.com/danielhb/qemu/tree/ppc-next with the following tags:
>>
>>
>> Reported-by: Kowshik Jois B S <kowsjois@linux.ibm.com>
>> Fixes: 61bd1d2942 ("target/ppc: Convert to tcg_ops restore_state_to_opc")
>> Fixes: 670f1da374 ("target/ppc: Implement hashst and hashchk")
>> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/377
> This should be
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1319
Ops! Fixed in tree.
Daniel
>
>> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
>> Reviewed-by: Greg Kurz <groug@kaod.org>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> Tested-by: Kowshik Jois B S <kowsjois@linux.vnet.ibm.com>
>>
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'
2022-11-17 10:50 ` Greg Kurz
2022-11-17 13:08 ` Cédric Le Goater
@ 2022-11-17 14:27 ` Daniel Henrique Barboza
1 sibling, 0 replies; 15+ messages in thread
From: Daniel Henrique Barboza @ 2022-11-17 14:27 UTC (permalink / raw)
To: Greg Kurz
Cc: Vaibhav Jain, qemu-devel, qemu-ppc, david, clg, Kowshik Jois B S
On 11/17/22 07:50, Greg Kurz wrote:
> On Thu, 17 Nov 2022 07:11:51 -0300
> Daniel Henrique Barboza <danielhb413@gmail.com> wrote:
>
>> Queued in gitlab.com/danielhb/qemu/tree/ppc-next with the following tags:
>>
>
> You are planning a PR before 7.2-rc2, right ?
I'll send it today.
>
>>
>> Reported-by: Kowshik Jois B S <kowsjois@linux.ibm.com>
>> Fixes: 61bd1d2942 ("target/ppc: Convert to tcg_ops restore_state_to_opc")
>> Fixes: 670f1da374 ("target/ppc: Implement hashst and hashchk")
>
> The guard macro also covers the following two, introduced by yet another commit.
>
> HELPER_HASH(HASHSTP, env->spr[SPR_HASHPKEYR], true)
> HELPER_HASH(HASHCHKP, env->spr[SPR_HASHPKEYR], false)
>
> Fixes: 53ae2aeb9407 ("target/ppc: Implement hashstp and hashchkp")
Added this tag in-tree as well:
Reported-by: Kowshik Jois B S <kowsjois@linux.ibm.com>
Fixes: 61bd1d2942 ("target/ppc: Convert to tcg_ops restore_state_to_opc")
Fixes: 670f1da374 ("target/ppc: Implement hashst and hashchk")
Fixes: 53ae2aeb94 ("target/ppc: Implement hashstp and hashchkp")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1319
Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Kowshik Jois B S <kowsjois@linux.vnet.ibm.com>
Daniel
>
>> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/377
>
> Err... I don't see any relation with this issue.
>
> Cedric ?
>
> But this resolves the issue created by Vaibhav for 7.2 :
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1319
>
>> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
>> Reviewed-by: Greg Kurz <groug@kaod.org>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> Tested-by: Kowshik Jois B S <kowsjois@linux.vnet.ibm.com>
>>
>>
>> Thanks,
>>
>>
>> Daniel
>>
>> On 11/16/22 10:17, Vaibhav Jain wrote:
>>> Kowshik reported that building qemu with GCC 12.2.1 for 'ppc64-softmmu'
>>> target is failing due to following build warnings:
>>>
>>> <snip>
>>> ../target/ppc/cpu_init.c:7018:13: error: 'ppc_restore_state_to_opc' defined but not used [-Werror=unused-function]
>>> 7018 | static void ppc_restore_state_to_opc(CPUState *cs,
>>> <snip>
>>>
>>> Fix this by wrapping these function definitions in 'ifdef CONFIG_TCG' so that
>>> they are only defined if qemu is compiled with '--enable-tcg'
>>>
>>> Reported-by: Kowshik Jois B S <kowsjois@linux.ibm.com>
>>> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
>>> ---
>>> target/ppc/cpu_init.c | 2 ++
>>> target/ppc/excp_helper.c | 2 ++
>>> 2 files changed, 4 insertions(+)
>>>
>>> diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c
>>> index 32e94153d1..cbf0081374 100644
>>> --- a/target/ppc/cpu_init.c
>>> +++ b/target/ppc/cpu_init.c
>>> @@ -7015,6 +7015,7 @@ static vaddr ppc_cpu_get_pc(CPUState *cs)
>>> return cpu->env.nip;
>>> }
>>>
>>> +#ifdef CONFIG_TCG
>>> static void ppc_restore_state_to_opc(CPUState *cs,
>>> const TranslationBlock *tb,
>>> const uint64_t *data)
>>> @@ -7023,6 +7024,7 @@ static void ppc_restore_state_to_opc(CPUState *cs,
>>>
>>> cpu->env.nip = data[0];
>>> }
>>> +#endif /* CONFIG_TCG */
>>>
>>> static bool ppc_cpu_has_work(CPUState *cs)
>>> {
>>> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
>>> index a05a2ed595..94adcb766b 100644
>>> --- a/target/ppc/excp_helper.c
>>> +++ b/target/ppc/excp_helper.c
>>> @@ -2842,6 +2842,7 @@ void helper_td(CPUPPCState *env, target_ulong arg1, target_ulong arg2,
>>> #endif
>>> #endif
>>>
>>> +#ifdef CONFIG_TCG
>>> static uint32_t helper_SIMON_LIKE_32_64(uint32_t x, uint64_t key, uint32_t lane)
>>> {
>>> const uint16_t c = 0xfffc;
>>> @@ -2924,6 +2925,7 @@ HELPER_HASH(HASHST, env->spr[SPR_HASHKEYR], true)
>>> HELPER_HASH(HASHCHK, env->spr[SPR_HASHKEYR], false)
>>> HELPER_HASH(HASHSTP, env->spr[SPR_HASHPKEYR], true)
>>> HELPER_HASH(HASHCHKP, env->spr[SPR_HASHPKEYR], false)
>>> +#endif /* CONFIG_TCG */
>>>
>>> #if !defined(CONFIG_USER_ONLY)
>>>
>
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2022-11-17 14:29 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-16 13:17 [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg' Vaibhav Jain
2022-11-16 15:20 ` Greg Kurz
2022-11-16 15:30 ` Philippe Mathieu-Daudé
2022-11-17 8:24 ` Thomas Huth
2022-11-17 2:13 ` Vaibhav Jain
2022-11-17 6:49 ` Cédric Le Goater
2022-11-16 15:27 ` [PATCH-for-7.2] " Philippe Mathieu-Daudé
2022-11-17 2:23 ` Vaibhav Jain
2022-11-17 7:34 ` [PATCH] " Kowshik Jois B S
2022-11-17 10:11 ` Daniel Henrique Barboza
2022-11-17 10:35 ` Vaibhav Jain
2022-11-17 14:23 ` Daniel Henrique Barboza
2022-11-17 10:50 ` Greg Kurz
2022-11-17 13:08 ` Cédric Le Goater
2022-11-17 14:27 ` Daniel Henrique Barboza
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.