Re: [bitbake-devel] [master][zeus][PATCH 3/3] fetch2: Allow ${AUTOREV} to be used when BB_SRCREV_POLICY is "cache"

["Peter Kjellerstedt" <peter.kjellerstedt@axis.com>]

> -----Original Message-----
> From: Khem Raj <raj.khem@gmail.com>
> Sent: den 22 mars 2020 00:59
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> Cc: bitbake-devel@lists.openembedded.org
> Subject: Re: [bitbake-devel] [master][zeus][PATCH 3/3] fetch2: Allow
> ${AUTOREV} to be used when BB_SRCREV_POLICY is "cache"
> 
> On Sat, Mar 21, 2020 at 4:50 PM Peter Kjellerstedt
> <peter.kjellerstedt@axis.com> wrote:
> >
> > Rather than blindly reverting, can’t we update the documentation
> > instead? If you use ${AUTOREV} you obviously do it because you always want
> > the latest revision.
>  
> Autorev + clear srcrev policy if you want that

Well, obviously ${AUTOREV} works with BB_SRCREV_POLICY = "clear". But 
BB_SRCREV_POLICY is a distro configuration and it is not possible to override 
it per recipe. Which means that if it is set to "cache", it is not possible 
to use ${AUTOREV}. This is not documented, and to the developers it will look 
as if it is working, since it fetches the very first time the recipe is built.
But there will be no updates, so it is as useful as setting SRCREV = "master" 
(which some of our developers also have tried before being educated to how 
BitBake works)...

> > Before this change, using ${AUTOREV} in combination with
> > BB_SRCREV_POLICY = "cache" didn’t work, which also wasn’t documented.
> 
> It could be interpreted also that cache also caches AUTOREVs
> this will break downstream projects. Its equivalent of ABI change,
> that perhaps will do more harm then what it fixes.

I fail to see how it will break stuff as it was not possible to use ${AUTOREV} 
before in a meaningful way together with BB_SRCREV_POLICY = "cache".

> > //Peter

//Peter

> > From: bitbake-devel@lists.openembedded.org <bitbake-
> devel@lists.openembedded.org> On Behalf Of Khem Raj
> > Sent: den 21 mars 2020 22:44
> > To: bitbake-devel@lists.openembedded.org
> > Subject: Re: [bitbake-devel] [master][zeus][PATCH 3/3] fetch2: Allow
> ${AUTOREV} to be used when BB_SRCREV_POLICY is "cache"
> >
> >
> >
> > removing
> >
> > if d.getVar('BB_SRCREV_POLICY') != "cache":
> >
> > Will cause autorevs to be excluded from policy and its not documented
> >
> > https://www.yoctoproject.org/docs/2.1/bitbake-user-manual/bitbake-user-
> manual.html#var-BB_SRCREV_POLICY
> >
> > did not state that AUTOREVs plus BB_SRCREV_POLICY behavior, this patch
> is regressing the case
> > where we rely on this behavior to use externalsrc on AUTOREVed recipes.