From: "Khem Raj" <raj.khem@gmail.com>
To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Cc: "bitbake-devel@lists.openembedded.org"
<bitbake-devel@lists.openembedded.org>
Subject: Re: [bitbake-devel] [master][zeus][PATCH 3/3] fetch2: Allow ${AUTOREV} to be used when BB_SRCREV_POLICY is "cache"
Date: Sat, 21 Mar 2020 16:58:38 -0700 [thread overview]
Message-ID: <CAMKF1srOQVRW8n9bzr9GXiA3NBOX=cE5EV-W9S_dq+JFRqNjMQ@mail.gmail.com> (raw)
In-Reply-To: <1cdd50184c1f4af488baee9ee691b495@XBOX03.axis.com>
On Sat, Mar 21, 2020 at 4:50 PM Peter Kjellerstedt
<peter.kjellerstedt@axis.com> wrote:
>
> Rather than blindly reverting, can’t we update the documentation instead? If you use ${AUTOREV} you obviously do it because you always want the latest revision.
>
Autorev + clear srcrev policy if you want that
>
>
> Before this change, using ${AUTOREV} in combination with BB_SRCREV_POLICY = “cache” didn’t work, which also wasn’t documented.
>
It could be interpreted also that cache also caches AUTOREVs
this will break downstream projects. Its equivalent of ABI change,
that perhaps will do more harm then what it fixes.
>
>
> //Peter
>
>
>
> From: bitbake-devel@lists.openembedded.org <bitbake-devel@lists.openembedded.org> On Behalf Of Khem Raj
> Sent: den 21 mars 2020 22:44
> To: bitbake-devel@lists.openembedded.org
> Subject: Re: [bitbake-devel] [master][zeus][PATCH 3/3] fetch2: Allow ${AUTOREV} to be used when BB_SRCREV_POLICY is "cache"
>
>
>
> removing
>
> if d.getVar('BB_SRCREV_POLICY') != "cache":
>
> Will cause autorevs to be excluded from policy and its not documented
>
> https://www.yoctoproject.org/docs/2.1/bitbake-user-manual/bitbake-user-manual.html#var-BB_SRCREV_POLICY
>
> did not state that AUTOREVs plus BB_SRCREV_POLICY behavior, this patch is regressing the case
> where we rely on this behavior to use externalsrc on AUTOREVed recipes.
next prev parent reply other threads:[~2020-03-21 23:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 3:29 [master][zeus][PATCH 1/3] knotty: Make the bb.command.CommandExit event terminate bitbake Peter Kjellerstedt
2020-02-15 3:29 ` [master][zeus][PATCH 2/3] fetch2: Make fetcher_compare_revisions() work Peter Kjellerstedt
2020-02-15 3:29 ` [master][zeus][PATCH 3/3] fetch2: Allow ${AUTOREV} to be used when BB_SRCREV_POLICY is "cache" Peter Kjellerstedt
2020-03-21 21:44 ` Khem Raj
2020-03-21 23:50 ` [bitbake-devel] " Peter Kjellerstedt
2020-03-21 23:58 ` Khem Raj [this message]
2020-03-22 0:38 ` Peter Kjellerstedt
2020-03-22 1:27 ` Khem Raj
2020-03-22 6:19 ` Peter Kjellerstedt
2020-03-22 8:58 ` Richard Purdie
2020-03-22 8:56 ` Richard Purdie
2020-03-22 18:54 ` Khem Raj
2020-03-22 8:50 ` Richard Purdie
2020-03-16 11:19 ` [master][zeus][PATCH 1/3] knotty: Make the bb.command.CommandExit event terminate bitbake Peter Kjellerstedt
2020-03-19 14:24 ` akuster808
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMKF1srOQVRW8n9bzr9GXiA3NBOX=cE5EV-W9S_dq+JFRqNjMQ@mail.gmail.com' \
--to=raj.khem@gmail.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=peter.kjellerstedt@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.