All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] drm/tegra: gr2d: Explicitly control module reset
Date: Thu, 8 Jul 2021 22:40:57 +0300	[thread overview]
Message-ID: <2f9a6188-6e72-7353-2133-60230c02d6d2@gmail.com> (raw)
In-Reply-To: <d9112247-ce69-9281-75e6-6cb3296d19a7@gmail.com>

08.07.2021 18:13, Dmitry Osipenko пишет:
>> +assert_rst:
>> +	(void)reset_control_assert(gr2d->rst);
> (void)?

I forgot that the 2d reset shouldn't be asserted. See comment in
gr2d_runtime_suspend() [1].

[1] https://lore.kernel.org/lkml/20210701232728.23591-15-digetx@gmail.com/

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/tegra: gr2d: Explicitly control module reset
Date: Thu, 8 Jul 2021 22:40:57 +0300	[thread overview]
Message-ID: <2f9a6188-6e72-7353-2133-60230c02d6d2@gmail.com> (raw)
In-Reply-To: <d9112247-ce69-9281-75e6-6cb3296d19a7@gmail.com>

08.07.2021 18:13, Dmitry Osipenko пишет:
>> +assert_rst:
>> +	(void)reset_control_assert(gr2d->rst);
> (void)?

I forgot that the 2d reset shouldn't be asserted. See comment in
gr2d_runtime_suspend() [1].

[1] https://lore.kernel.org/lkml/20210701232728.23591-15-digetx@gmail.com/

  parent reply	other threads:[~2021-07-08 19:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08 14:37 [PATCH] drm/tegra: gr2d: Explicitly control module reset Thierry Reding
2021-07-08 14:37 ` Thierry Reding
2021-07-08 15:13 ` Dmitry Osipenko
2021-07-08 15:13   ` Dmitry Osipenko
2021-07-08 15:19   ` Dmitry Osipenko
2021-07-08 15:19     ` Dmitry Osipenko
2021-07-08 19:40   ` Dmitry Osipenko [this message]
2021-07-08 19:40     ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f9a6188-6e72-7353-2133-60230c02d6d2@gmail.com \
    --to=digetx@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.