* [PATCH] Add fdtfile for Marvell Armada 37xx default environment
@ 2020-11-25 9:14 Matwey V. Kornilov
2020-11-25 10:00 ` Stefan Roese
2020-11-26 3:44 ` Andre Heider
0 siblings, 2 replies; 7+ messages in thread
From: Matwey V. Kornilov @ 2020-11-25 9:14 UTC (permalink / raw)
To: u-boot
Signed-off-by: Matwey V. Kornilov <matwey.kornilov@gmail.com>
---
configs/mvebu_db-88f3720_defconfig | 1 +
configs/mvebu_espressobin-88f3720_defconfig | 1 +
include/configs/mvebu_armada-37xx.h | 1 +
3 files changed, 3 insertions(+)
diff --git a/configs/mvebu_db-88f3720_defconfig b/configs/mvebu_db-88f3720_defconfig
index a6bbe1a7af..1a3a267890 100644
--- a/configs/mvebu_db-88f3720_defconfig
+++ b/configs/mvebu_db-88f3720_defconfig
@@ -12,6 +12,7 @@ CONFIG_DM_GPIO=y
CONFIG_DEBUG_UART_BASE=0xd0012000
CONFIG_DEBUG_UART_CLOCK=25804800
CONFIG_DEFAULT_DEVICE_TREE="armada-3720-db"
+CONFIG_DEFAULT_FDT_FILE="marvell/armada-3720-db.dtb"
CONFIG_DEBUG_UART=y
CONFIG_AHCI=y
CONFIG_DISTRO_DEFAULTS=y
diff --git a/configs/mvebu_espressobin-88f3720_defconfig b/configs/mvebu_espressobin-88f3720_defconfig
index 8a859cba2e..56ec482794 100644
--- a/configs/mvebu_espressobin-88f3720_defconfig
+++ b/configs/mvebu_espressobin-88f3720_defconfig
@@ -12,6 +12,7 @@ CONFIG_DM_GPIO=y
CONFIG_DEBUG_UART_BASE=0xd0012000
CONFIG_DEBUG_UART_CLOCK=25804800
CONFIG_DEFAULT_DEVICE_TREE="armada-3720-espressobin"
+CONFIG_DEFAULT_FDT_FILE="marvell/armada-3720-espressobin.dtb"
CONFIG_DEBUG_UART=y
CONFIG_AHCI=y
CONFIG_DISTRO_DEFAULTS=y
diff --git a/include/configs/mvebu_armada-37xx.h b/include/configs/mvebu_armada-37xx.h
index 0d585606a7..377ac60def 100644
--- a/include/configs/mvebu_armada-37xx.h
+++ b/include/configs/mvebu_armada-37xx.h
@@ -96,6 +96,7 @@
"kernel_addr=0x7000000\0" \
"kernel_addr_r=0x7000000\0" \
"ramdisk_addr_r=0xa000000\0" \
+ "fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \
BOOTENV
#endif /* _CONFIG_MVEBU_ARMADA_37XX_H */
--
2.26.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] Add fdtfile for Marvell Armada 37xx default environment
2020-11-25 9:14 [PATCH] Add fdtfile for Marvell Armada 37xx default environment Matwey V. Kornilov
@ 2020-11-25 10:00 ` Stefan Roese
2020-11-26 3:44 ` Andre Heider
1 sibling, 0 replies; 7+ messages in thread
From: Stefan Roese @ 2020-11-25 10:00 UTC (permalink / raw)
To: u-boot
On 25.11.20 10:14, Matwey V. Kornilov wrote:
> Signed-off-by: Matwey V. Kornilov <matwey.kornilov@gmail.com>
Nitpicking:
An empty commit message is frowned upon. Please add a small sentence in
the commit text as well.
Thanks,
Stefan
> ---
> configs/mvebu_db-88f3720_defconfig | 1 +
> configs/mvebu_espressobin-88f3720_defconfig | 1 +
> include/configs/mvebu_armada-37xx.h | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/configs/mvebu_db-88f3720_defconfig b/configs/mvebu_db-88f3720_defconfig
> index a6bbe1a7af..1a3a267890 100644
> --- a/configs/mvebu_db-88f3720_defconfig
> +++ b/configs/mvebu_db-88f3720_defconfig
> @@ -12,6 +12,7 @@ CONFIG_DM_GPIO=y
> CONFIG_DEBUG_UART_BASE=0xd0012000
> CONFIG_DEBUG_UART_CLOCK=25804800
> CONFIG_DEFAULT_DEVICE_TREE="armada-3720-db"
> +CONFIG_DEFAULT_FDT_FILE="marvell/armada-3720-db.dtb"
> CONFIG_DEBUG_UART=y
> CONFIG_AHCI=y
> CONFIG_DISTRO_DEFAULTS=y
> diff --git a/configs/mvebu_espressobin-88f3720_defconfig b/configs/mvebu_espressobin-88f3720_defconfig
> index 8a859cba2e..56ec482794 100644
> --- a/configs/mvebu_espressobin-88f3720_defconfig
> +++ b/configs/mvebu_espressobin-88f3720_defconfig
> @@ -12,6 +12,7 @@ CONFIG_DM_GPIO=y
> CONFIG_DEBUG_UART_BASE=0xd0012000
> CONFIG_DEBUG_UART_CLOCK=25804800
> CONFIG_DEFAULT_DEVICE_TREE="armada-3720-espressobin"
> +CONFIG_DEFAULT_FDT_FILE="marvell/armada-3720-espressobin.dtb"
> CONFIG_DEBUG_UART=y
> CONFIG_AHCI=y
> CONFIG_DISTRO_DEFAULTS=y
> diff --git a/include/configs/mvebu_armada-37xx.h b/include/configs/mvebu_armada-37xx.h
> index 0d585606a7..377ac60def 100644
> --- a/include/configs/mvebu_armada-37xx.h
> +++ b/include/configs/mvebu_armada-37xx.h
> @@ -96,6 +96,7 @@
> "kernel_addr=0x7000000\0" \
> "kernel_addr_r=0x7000000\0" \
> "ramdisk_addr_r=0xa000000\0" \
> + "fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \
> BOOTENV
>
> #endif /* _CONFIG_MVEBU_ARMADA_37XX_H */
>
Viele Gr??e,
Stefan
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Add fdtfile for Marvell Armada 37xx default environment
2020-11-25 9:14 [PATCH] Add fdtfile for Marvell Armada 37xx default environment Matwey V. Kornilov
2020-11-25 10:00 ` Stefan Roese
@ 2020-11-26 3:44 ` Andre Heider
2020-11-26 9:04 ` Matwey V. Kornilov
1 sibling, 1 reply; 7+ messages in thread
From: Andre Heider @ 2020-11-26 3:44 UTC (permalink / raw)
To: u-boot
On 25/11/2020 10:14, Matwey V. Kornilov wrote:
> Signed-off-by: Matwey V. Kornilov <matwey.kornilov@gmail.com>
> ---
> configs/mvebu_db-88f3720_defconfig | 1 +
> configs/mvebu_espressobin-88f3720_defconfig | 1 +
> include/configs/mvebu_armada-37xx.h | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/configs/mvebu_db-88f3720_defconfig b/configs/mvebu_db-88f3720_defconfig
> index a6bbe1a7af..1a3a267890 100644
> --- a/configs/mvebu_db-88f3720_defconfig
> +++ b/configs/mvebu_db-88f3720_defconfig
> @@ -12,6 +12,7 @@ CONFIG_DM_GPIO=y
> CONFIG_DEBUG_UART_BASE=0xd0012000
> CONFIG_DEBUG_UART_CLOCK=25804800
> CONFIG_DEFAULT_DEVICE_TREE="armada-3720-db"
> +CONFIG_DEFAULT_FDT_FILE="marvell/armada-3720-db.dtb"
> CONFIG_DEBUG_UART=y
> CONFIG_AHCI=y
> CONFIG_DISTRO_DEFAULTS=y
> diff --git a/configs/mvebu_espressobin-88f3720_defconfig b/configs/mvebu_espressobin-88f3720_defconfig
> index 8a859cba2e..56ec482794 100644
> --- a/configs/mvebu_espressobin-88f3720_defconfig
> +++ b/configs/mvebu_espressobin-88f3720_defconfig
> @@ -12,6 +12,7 @@ CONFIG_DM_GPIO=y
> CONFIG_DEBUG_UART_BASE=0xd0012000
> CONFIG_DEBUG_UART_CLOCK=25804800
> CONFIG_DEFAULT_DEVICE_TREE="armada-3720-espressobin"
> +CONFIG_DEFAULT_FDT_FILE="marvell/armada-3720-espressobin.dtb"
No, that doesn't work for this board, see
68e32e344 "arm: mvebu: Espressobin: Set environment variable fdtfile"
> CONFIG_DEBUG_UART=y
> CONFIG_AHCI=y
> CONFIG_DISTRO_DEFAULTS=y
> diff --git a/include/configs/mvebu_armada-37xx.h b/include/configs/mvebu_armada-37xx.h
> index 0d585606a7..377ac60def 100644
> --- a/include/configs/mvebu_armada-37xx.h
> +++ b/include/configs/mvebu_armada-37xx.h
> @@ -96,6 +96,7 @@
> "kernel_addr=0x7000000\0" \
> "kernel_addr_r=0x7000000\0" \
> "ramdisk_addr_r=0xa000000\0" \
> + "fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \
> BOOTENV
>
> #endif /* _CONFIG_MVEBU_ARMADA_37XX_H */
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Add fdtfile for Marvell Armada 37xx default environment
2020-11-26 3:44 ` Andre Heider
@ 2020-11-26 9:04 ` Matwey V. Kornilov
2020-11-26 9:40 ` Andre Heider
0 siblings, 1 reply; 7+ messages in thread
From: Matwey V. Kornilov @ 2020-11-26 9:04 UTC (permalink / raw)
To: u-boot
??, 26 ????. 2020 ?. ? 06:45, Andre Heider <a.heider@gmail.com>:
> On 25/11/2020 10:14, Matwey V. Kornilov wrote:
> > Signed-off-by: Matwey V. Kornilov <matwey.kornilov@gmail.com>
> > ---
> > configs/mvebu_db-88f3720_defconfig | 1 +
> > configs/mvebu_espressobin-88f3720_defconfig | 1 +
> > include/configs/mvebu_armada-37xx.h | 1 +
> > 3 files changed, 3 insertions(+)
> >
> > diff --git a/configs/mvebu_db-88f3720_defconfig
> b/configs/mvebu_db-88f3720_defconfig
> > index a6bbe1a7af..1a3a267890 100644
> > --- a/configs/mvebu_db-88f3720_defconfig
> > +++ b/configs/mvebu_db-88f3720_defconfig
> > @@ -12,6 +12,7 @@ CONFIG_DM_GPIO=y
> > CONFIG_DEBUG_UART_BASE=0xd0012000
> > CONFIG_DEBUG_UART_CLOCK=25804800
> > CONFIG_DEFAULT_DEVICE_TREE="armada-3720-db"
> > +CONFIG_DEFAULT_FDT_FILE="marvell/armada-3720-db.dtb"
> > CONFIG_DEBUG_UART=y
> > CONFIG_AHCI=y
> > CONFIG_DISTRO_DEFAULTS=y
> > diff --git a/configs/mvebu_espressobin-88f3720_defconfig
> b/configs/mvebu_espressobin-88f3720_defconfig
> > index 8a859cba2e..56ec482794 100644
> > --- a/configs/mvebu_espressobin-88f3720_defconfig
> > +++ b/configs/mvebu_espressobin-88f3720_defconfig
> > @@ -12,6 +12,7 @@ CONFIG_DM_GPIO=y
> > CONFIG_DEBUG_UART_BASE=0xd0012000
> > CONFIG_DEBUG_UART_CLOCK=25804800
> > CONFIG_DEFAULT_DEVICE_TREE="armada-3720-espressobin"
> > +CONFIG_DEFAULT_FDT_FILE="marvell/armada-3720-espressobin.dtb"
>
> No, that doesn't work for this board, see
> 68e32e344 "arm: mvebu: Espressobin: Set environment variable fdtfile"
>
>
Good point.
But why does this autodetection not work for me?
> > CONFIG_DEBUG_UART=y
> > CONFIG_AHCI=y
> > CONFIG_DISTRO_DEFAULTS=y
> > diff --git a/include/configs/mvebu_armada-37xx.h
> b/include/configs/mvebu_armada-37xx.h
> > index 0d585606a7..377ac60def 100644
> > --- a/include/configs/mvebu_armada-37xx.h
> > +++ b/include/configs/mvebu_armada-37xx.h
> > @@ -96,6 +96,7 @@
> > "kernel_addr=0x7000000\0" \
> > "kernel_addr_r=0x7000000\0" \
> > "ramdisk_addr_r=0xa000000\0" \
> > + "fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \
> > BOOTENV
> >
> > #endif /* _CONFIG_MVEBU_ARMADA_37XX_H */
> >
>
>
--
With best regards,
Matwey V. Kornilov
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Add fdtfile for Marvell Armada 37xx default environment
2020-11-26 9:04 ` Matwey V. Kornilov
@ 2020-11-26 9:40 ` Andre Heider
2020-11-29 8:32 ` Matwey V. Kornilov
0 siblings, 1 reply; 7+ messages in thread
From: Andre Heider @ 2020-11-26 9:40 UTC (permalink / raw)
To: u-boot
On 26/11/2020 10:04, Matwey V. Kornilov wrote:
>
>
> ??, 26 ????. 2020 ?. ? 06:45, Andre Heider <a.heider@gmail.com
> <mailto:a.heider@gmail.com>>:
>
> On 25/11/2020 10:14, Matwey V. Kornilov wrote:
> > Signed-off-by: Matwey V. Kornilov <matwey.kornilov@gmail.com
> <mailto:matwey.kornilov@gmail.com>>
> > ---
> >? ?configs/mvebu_db-88f3720_defconfig? ? ? ? ? | 1 +
> >? ?configs/mvebu_espressobin-88f3720_defconfig | 1 +
> >? ?include/configs/mvebu_armada-37xx.h? ? ? ? ?| 1 +
> >? ?3 files changed, 3 insertions(+)
> >
> > diff --git a/configs/mvebu_db-88f3720_defconfig
> b/configs/mvebu_db-88f3720_defconfig
> > index a6bbe1a7af..1a3a267890 100644
> > --- a/configs/mvebu_db-88f3720_defconfig
> > +++ b/configs/mvebu_db-88f3720_defconfig
> > @@ -12,6 +12,7 @@ CONFIG_DM_GPIO=y
> >? ?CONFIG_DEBUG_UART_BASE=0xd0012000
> >? ?CONFIG_DEBUG_UART_CLOCK=25804800
> >? ?CONFIG_DEFAULT_DEVICE_TREE="armada-3720-db"
> > +CONFIG_DEFAULT_FDT_FILE="marvell/armada-3720-db.dtb"
> >? ?CONFIG_DEBUG_UART=y
> >? ?CONFIG_AHCI=y
> >? ?CONFIG_DISTRO_DEFAULTS=y
> > diff --git a/configs/mvebu_espressobin-88f3720_defconfig
> b/configs/mvebu_espressobin-88f3720_defconfig
> > index 8a859cba2e..56ec482794 100644
> > --- a/configs/mvebu_espressobin-88f3720_defconfig
> > +++ b/configs/mvebu_espressobin-88f3720_defconfig
> > @@ -12,6 +12,7 @@ CONFIG_DM_GPIO=y
> >? ?CONFIG_DEBUG_UART_BASE=0xd0012000
> >? ?CONFIG_DEBUG_UART_CLOCK=25804800
> >? ?CONFIG_DEFAULT_DEVICE_TREE="armada-3720-espressobin"
> > +CONFIG_DEFAULT_FDT_FILE="marvell/armada-3720-espressobin.dtb"
>
> No, that doesn't work for this board, see
> 68e32e344 "arm: mvebu: Espressobin: Set environment variable fdtfile"
>
>
> Good point.
> But why does this autodetection not work for me?
I guess that can only happen if:
- the commit isn't part of you tree
- you disabled CONFIG_BOARD_LATE_INIT or didn't refresh from the defconfig
- you already have the envvar set/saved
>
> >? ?CONFIG_DEBUG_UART=y
> >? ?CONFIG_AHCI=y
> >? ?CONFIG_DISTRO_DEFAULTS=y
> > diff --git a/include/configs/mvebu_armada-37xx.h
> b/include/configs/mvebu_armada-37xx.h
> > index 0d585606a7..377ac60def 100644
> > --- a/include/configs/mvebu_armada-37xx.h
> > +++ b/include/configs/mvebu_armada-37xx.h
> > @@ -96,6 +96,7 @@
> >? ? ? ?"kernel_addr=0x7000000\0"? ? ? ?\
> >? ? ? ?"kernel_addr_r=0x7000000\0"? ? ?\
> >? ? ? ?"ramdisk_addr_r=0xa000000\0"? ? \
> > +? ? ?"fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \
> >? ? ? ?BOOTENV
> >
> >? ?#endif /* _CONFIG_MVEBU_ARMADA_37XX_H */
> >
>
>
>
> --
> With best regards,
> Matwey V. Kornilov
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Add fdtfile for Marvell Armada 37xx default environment
2020-11-26 9:40 ` Andre Heider
@ 2020-11-29 8:32 ` Matwey V. Kornilov
2020-11-29 18:29 ` Andre Heider
0 siblings, 1 reply; 7+ messages in thread
From: Matwey V. Kornilov @ 2020-11-29 8:32 UTC (permalink / raw)
To: u-boot
??, 26 ????. 2020 ?. ? 12:40, Andre Heider <a.heider@gmail.com>:
> On 26/11/2020 10:04, Matwey V. Kornilov wrote:
> >
> >
> > ??, 26 ????. 2020 ?. ? 06:45, Andre Heider <a.heider@gmail.com
> > <mailto:a.heider@gmail.com>>:
> >
> > On 25/11/2020 10:14, Matwey V. Kornilov wrote:
> > > Signed-off-by: Matwey V. Kornilov <matwey.kornilov@gmail.com
> > <mailto:matwey.kornilov@gmail.com>>
> > > ---
> > > configs/mvebu_db-88f3720_defconfig | 1 +
> > > configs/mvebu_espressobin-88f3720_defconfig | 1 +
> > > include/configs/mvebu_armada-37xx.h | 1 +
> > > 3 files changed, 3 insertions(+)
> > >
> > > diff --git a/configs/mvebu_db-88f3720_defconfig
> > b/configs/mvebu_db-88f3720_defconfig
> > > index a6bbe1a7af..1a3a267890 100644
> > > --- a/configs/mvebu_db-88f3720_defconfig
> > > +++ b/configs/mvebu_db-88f3720_defconfig
> > > @@ -12,6 +12,7 @@ CONFIG_DM_GPIO=y
> > > CONFIG_DEBUG_UART_BASE=0xd0012000
> > > CONFIG_DEBUG_UART_CLOCK=25804800
> > > CONFIG_DEFAULT_DEVICE_TREE="armada-3720-db"
> > > +CONFIG_DEFAULT_FDT_FILE="marvell/armada-3720-db.dtb"
> > > CONFIG_DEBUG_UART=y
> > > CONFIG_AHCI=y
> > > CONFIG_DISTRO_DEFAULTS=y
> > > diff --git a/configs/mvebu_espressobin-88f3720_defconfig
> > b/configs/mvebu_espressobin-88f3720_defconfig
> > > index 8a859cba2e..56ec482794 100644
> > > --- a/configs/mvebu_espressobin-88f3720_defconfig
> > > +++ b/configs/mvebu_espressobin-88f3720_defconfig
> > > @@ -12,6 +12,7 @@ CONFIG_DM_GPIO=y
> > > CONFIG_DEBUG_UART_BASE=0xd0012000
> > > CONFIG_DEBUG_UART_CLOCK=25804800
> > > CONFIG_DEFAULT_DEVICE_TREE="armada-3720-espressobin"
> > > +CONFIG_DEFAULT_FDT_FILE="marvell/armada-3720-espressobin.dtb"
> >
> > No, that doesn't work for this board, see
> > 68e32e344 "arm: mvebu: Espressobin: Set environment variable fdtfile"
> >
> >
> > Good point.
> > But why does this autodetection not work for me?
>
> I guess that can only happen if:
> - the commit isn't part of you tree
> - you disabled CONFIG_BOARD_LATE_INIT or didn't refresh from the defconfig
> - you already have the envvar set/saved
>
>
Hi,
I've double checked, and you are right.
It seems that I did "env default" and fdtfile disappeared until the next
reset.
What do you think? If the patch still needed for 3720-DB?
> >
> > > CONFIG_DEBUG_UART=y
> > > CONFIG_AHCI=y
> > > CONFIG_DISTRO_DEFAULTS=y
> > > diff --git a/include/configs/mvebu_armada-37xx.h
> > b/include/configs/mvebu_armada-37xx.h
> > > index 0d585606a7..377ac60def 100644
> > > --- a/include/configs/mvebu_armada-37xx.h
> > > +++ b/include/configs/mvebu_armada-37xx.h
> > > @@ -96,6 +96,7 @@
> > > "kernel_addr=0x7000000\0" \
> > > "kernel_addr_r=0x7000000\0" \
> > > "ramdisk_addr_r=0xa000000\0" \
> > > + "fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \
> > > BOOTENV
> > >
> > > #endif /* _CONFIG_MVEBU_ARMADA_37XX_H */
> > >
> >
> >
> >
> > --
> > With best regards,
> > Matwey V. Kornilov
>
>
--
With best regards,
Matwey V. Kornilov
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Add fdtfile for Marvell Armada 37xx default environment
2020-11-29 8:32 ` Matwey V. Kornilov
@ 2020-11-29 18:29 ` Andre Heider
0 siblings, 0 replies; 7+ messages in thread
From: Andre Heider @ 2020-11-29 18:29 UTC (permalink / raw)
To: u-boot
On 29/11/2020 09:32, Matwey V. Kornilov wrote:
>
>
> ??, 26 ????. 2020 ?. ? 12:40, Andre Heider <a.heider@gmail.com
> <mailto:a.heider@gmail.com>>:
>
> On 26/11/2020 10:04, Matwey V. Kornilov wrote:
> >
> >
> > ??, 26 ????. 2020 ?. ? 06:45, Andre Heider <a.heider@gmail.com
> <mailto:a.heider@gmail.com>
> > <mailto:a.heider at gmail.com <mailto:a.heider@gmail.com>>>:
> >
> >? ? ?On 25/11/2020 10:14, Matwey V. Kornilov wrote:
> >? ? ? > Signed-off-by: Matwey V. Kornilov
> <matwey.kornilov at gmail.com <mailto:matwey.kornilov@gmail.com>
> >? ? ?<mailto:matwey.kornilov@gmail.com
> <mailto:matwey.kornilov@gmail.com>>>
> >? ? ? > ---
> >? ? ? >? ?configs/mvebu_db-88f3720_defconfig? ? ? ? ? | 1 +
> >? ? ? >? ?configs/mvebu_espressobin-88f3720_defconfig | 1 +
> >? ? ? >? ?include/configs/mvebu_armada-37xx.h? ? ? ? ?| 1 +
> >? ? ? >? ?3 files changed, 3 insertions(+)
> >? ? ? >
> >? ? ? > diff --git a/configs/mvebu_db-88f3720_defconfig
> >? ? ?b/configs/mvebu_db-88f3720_defconfig
> >? ? ? > index a6bbe1a7af..1a3a267890 100644
> >? ? ? > --- a/configs/mvebu_db-88f3720_defconfig
> >? ? ? > +++ b/configs/mvebu_db-88f3720_defconfig
> >? ? ? > @@ -12,6 +12,7 @@ CONFIG_DM_GPIO=y
> >? ? ? >? ?CONFIG_DEBUG_UART_BASE=0xd0012000
> >? ? ? >? ?CONFIG_DEBUG_UART_CLOCK=25804800
> >? ? ? >? ?CONFIG_DEFAULT_DEVICE_TREE="armada-3720-db"
> >? ? ? > +CONFIG_DEFAULT_FDT_FILE="marvell/armada-3720-db.dtb"
> >? ? ? >? ?CONFIG_DEBUG_UART=y
> >? ? ? >? ?CONFIG_AHCI=y
> >? ? ? >? ?CONFIG_DISTRO_DEFAULTS=y
> >? ? ? > diff --git a/configs/mvebu_espressobin-88f3720_defconfig
> >? ? ?b/configs/mvebu_espressobin-88f3720_defconfig
> >? ? ? > index 8a859cba2e..56ec482794 100644
> >? ? ? > --- a/configs/mvebu_espressobin-88f3720_defconfig
> >? ? ? > +++ b/configs/mvebu_espressobin-88f3720_defconfig
> >? ? ? > @@ -12,6 +12,7 @@ CONFIG_DM_GPIO=y
> >? ? ? >? ?CONFIG_DEBUG_UART_BASE=0xd0012000
> >? ? ? >? ?CONFIG_DEBUG_UART_CLOCK=25804800
> >? ? ? >? ?CONFIG_DEFAULT_DEVICE_TREE="armada-3720-espressobin"
> >? ? ? > +CONFIG_DEFAULT_FDT_FILE="marvell/armada-3720-espressobin.dtb"
> >
> >? ? ?No, that doesn't work for this board, see
> >? ? ?68e32e344 "arm: mvebu: Espressobin: Set environment variable
> fdtfile"
> >
> >
> > Good point.
> > But why does this autodetection not work for me?
>
> I guess that can only happen if:
> - the commit isn't part of you tree
> - you disabled CONFIG_BOARD_LATE_INIT or didn't refresh from the
> defconfig
> - you already have the envvar set/saved
>
>
> Hi,
>
> I've double checked, and you are right.
> It seems that I did "env default" and fdtfile disappeared until the next
> reset.
>
> What do you think? If the patch still needed for 3720-DB?
I'm not so sure anybody cares about that board anymore, but it's not up
to me ;)
You would need to wrap setting `fdtfile` for the default env with
"#ifdef CONFIG_DEFAULT_FDT_FILE" then though.
>
> >
> >? ? ? >? ?CONFIG_DEBUG_UART=y
> >? ? ? >? ?CONFIG_AHCI=y
> >? ? ? >? ?CONFIG_DISTRO_DEFAULTS=y
> >? ? ? > diff --git a/include/configs/mvebu_armada-37xx.h
> >? ? ?b/include/configs/mvebu_armada-37xx.h
> >? ? ? > index 0d585606a7..377ac60def 100644
> >? ? ? > --- a/include/configs/mvebu_armada-37xx.h
> >? ? ? > +++ b/include/configs/mvebu_armada-37xx.h
> >? ? ? > @@ -96,6 +96,7 @@
> >? ? ? >? ? ? ?"kernel_addr=0x7000000\0"? ? ? ?\
> >? ? ? >? ? ? ?"kernel_addr_r=0x7000000\0"? ? ?\
> >? ? ? >? ? ? ?"ramdisk_addr_r=0xa000000\0"? ? \
> >? ? ? > +? ? ?"fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \
> >? ? ? >? ? ? ?BOOTENV
> >? ? ? >
> >? ? ? >? ?#endif /* _CONFIG_MVEBU_ARMADA_37XX_H */
> >? ? ? >
> >
> >
> >
> > --
> > With best regards,
> > Matwey V. Kornilov
>
>
>
> --
> With best regards,
> Matwey V. Kornilov
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-11-29 18:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-25 9:14 [PATCH] Add fdtfile for Marvell Armada 37xx default environment Matwey V. Kornilov
2020-11-25 10:00 ` Stefan Roese
2020-11-26 3:44 ` Andre Heider
2020-11-26 9:04 ` Matwey V. Kornilov
2020-11-26 9:40 ` Andre Heider
2020-11-29 8:32 ` Matwey V. Kornilov
2020-11-29 18:29 ` Andre Heider
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.