All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] powerpc: warn on emulation of dcbz instruction
@ 2021-09-15 14:31 ` Christophe Leroy
  0 siblings, 0 replies; 12+ messages in thread
From: Christophe Leroy @ 2021-09-15 14:31 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman
  Cc: Christophe Leroy, linux-kernel, linuxppc-dev, Stan Johnson, Finn Thain

dcbz instruction shouldn't be used on non-cached memory. Using
it on non-cached memory can result in alignment exception and
implies a heavy handling.

Instead of silentely emulating the instruction and resulting in high
performance degradation, warn whenever an alignment exception is
taken due to dcbz, so that the user is made aware that dcbz
instruction has been used unexpectedly.

Reported-by: Stan Johnson <userm57@yahoo.com>
Cc: Finn Thain <fthain@linux-m68k.org>
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
---
 arch/powerpc/kernel/align.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/kernel/align.c b/arch/powerpc/kernel/align.c
index bbb4181621dd..adc3a4a9c6e4 100644
--- a/arch/powerpc/kernel/align.c
+++ b/arch/powerpc/kernel/align.c
@@ -349,6 +349,7 @@ int fix_alignment(struct pt_regs *regs)
 		if (op.type != CACHEOP + DCBZ)
 			return -EINVAL;
 		PPC_WARN_ALIGNMENT(dcbz, regs);
+		WARN_ON_ONCE(1);
 		r = emulate_dcbz(op.ea, regs);
 	} else {
 		if (type == LARX || type == STCX)
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2021-09-17 12:39 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-15 14:31 [PATCH] powerpc: warn on emulation of dcbz instruction Christophe Leroy
2021-09-15 14:31 ` Christophe Leroy
2021-09-16  7:15 ` Benjamin Herrenschmidt
2021-09-16  7:15   ` Benjamin Herrenschmidt
2021-09-16  7:16   ` Benjamin Herrenschmidt
2021-09-16  7:16     ` Benjamin Herrenschmidt
2021-09-16  7:23     ` Christophe Leroy
2021-09-16  7:23       ` Christophe Leroy
2021-09-16 14:36       ` David Laight
2021-09-16 14:36         ` David Laight
2021-09-17 12:33         ` Benjamin Herrenschmidt
2021-09-17 12:33           ` Benjamin Herrenschmidt

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.