From: "Jiang, YuX" <yux.jiang@intel.com>
To: "Sun, GuinanX" <guinanx.sun@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Sun, GuinanX" <guinanx.sun@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode
Date: Sat, 9 May 2020 03:13:14 +0000 [thread overview]
Message-ID: <2fd507e9d5774171b14792c6fa3b8d62@intel.com> (raw)
In-Reply-To: <20200508082939.32525-1-guinanx.sun@intel.com>
Tested-by: Jiang, YuX <yux.jiang@intel.com>
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Guinan Sun
Sent: Friday, May 8, 2020 4:30 PM
To: dev@dpdk.org
Cc: Sun, GuinanX <guinanx.sun@intel.com>; stable@dpdk.org
Subject: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode
The register autoneg can't be updated synchronously with flow control mode setting in the state of port start , so NIC statistics error occurs. The patch fixes the issue.
Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
Cc: stable@dpdk.org
Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index cf5f1fe70..e6c747aef 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev, struct ixgbe_hw *hw)
int err;
uint32_t mflcn;
+ hw->mac.ops.setup_fc(hw);
+
err = ixgbe_fc_enable(hw);
/* Not negotiated is not an error case */
--
2.17.1
next prev parent reply other threads:[~2020-05-09 3:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 8:29 [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode Guinan Sun
2020-05-09 3:13 ` Jiang, YuX [this message]
2020-05-11 1:03 ` Zhao1, Wei
2020-05-12 8:28 ` Sun, GuinanX
2020-05-12 8:13 ` [dpdk-dev] [PATCH v2] " Guinan Sun
2020-05-12 8:39 ` Zhao1, Wei
2020-05-13 0:59 ` [dpdk-dev] [dpdk-stable] " Ye Xiaolong
2020-05-13 7:03 ` Jiang, YuX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fd507e9d5774171b14792c6fa3b8d62@intel.com \
--to=yux.jiang@intel.com \
--cc=dev@dpdk.org \
--cc=guinanx.sun@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.