Re: [PATCH v4 2/9] virt: geniezone: Add GenieZone hypervisor support

From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yi-De Wu <yi-de.wu@mediatek.com>,
	Yingshiuan Pan <yingshiuan.pan@mediatek.com>,
	Ze-Yu Wang <ze-yu.wang@mediatek.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Conor Dooley <conor.dooley@microchip.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Trilok Soni <quic_tsoni@quicinc.com>,
	David Bradil <dbrazdil@google.com>,
	Jade Shih <jades.shih@mediatek.com>,
	Miles Chen <miles.chen@mediatek.com>,
	Ivan Tseng <ivan.tseng@mediatek.com>,
	My Chuang <my.chuang@mediatek.com>,
	Shawn Hsiao <shawn.hsiao@mediatek.com>,
	PeiLun Suei <peilun.suei@mediatek.com>,
	Liju Chen <liju-clr.chen@mediatek.com>,
	Willix Yeh <chi-shen.yeh@mediatek.com>
Subject: Re: [PATCH v4 2/9] virt: geniezone: Add GenieZone hypervisor support
Date: Fri, 9 Jun 2023 17:22:23 +0200	[thread overview]
Message-ID: <2fe0c7f9-55fc-ae63-3631-8526a0212ccd@linaro.org> (raw)
In-Reply-To: <20230609085214.31071-3-yi-de.wu@mediatek.com>

On 09/06/2023 10:52, Yi-De Wu wrote:
> From: "Yingshiuan Pan" <yingshiuan.pan@mediatek.com>
> 
> GenieZone is MediaTek hypervisor solution, and it is running in EL2
> stand alone as a type-I hypervisor. This patch exports a set of ioctl
> interfaces for userspace VMM (e.g., crosvm) to operate guest VMs
> lifecycle (creation and destroy) on GenieZone.

...

> +static int gzvm_drv_probe(void)
> +{
> +	int ret;
> +
> +	if (gzvm_arch_probe() != 0) {
> +		pr_err("Not found available conduit\n");
> +		return -ENODEV;
> +	}
> +
> +	ret = misc_register(&gzvm_dev);
> +	if (ret)
> +		return ret;
> +	gzvm_debug_dev = &gzvm_dev;
> +
> +	return 0;
> +}
> +
> +static int gzvm_drv_remove(void)
> +{
> +	destroy_all_vm();
> +	misc_deregister(&gzvm_dev);
> +	return 0;
> +}
> +
> +static int gzvm_dev_init(void)
> +{
> +	return gzvm_drv_probe();

So for every system and architecture you want to: probe, run some SMC
and then print error that it is not othe system you wanted.

I don't think this is what we want. You basically pollute all of other
users just to have your hypervisor guest additions...

Best regards,
Krzysztof