* [U-Boot] [PATCH] spl: Add missing line ending to SPL print
@ 2017-01-16 12:06 Michal Simek
2017-01-16 15:37 ` Lokesh Vutla
2017-01-21 3:38 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 5+ messages in thread
From: Michal Simek @ 2017-01-16 12:06 UTC (permalink / raw)
To: u-boot
One print requires line ending to be aligned with SW running
after it. Prints look weird without it.
For example:
U-Boot SPL 2017.01-01801-g1fb1292c7b9d (Jan 16 2017 - 12:50:53)
EL Level: EL3
Trying to boot from SPINOTICE: ATF running on XCZU15EG/silicon
v2/RTL5.1 at 0xfffe5000, with PMU firmware
NOTICE: BL31: Secure code at 0x0
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
common/spl/spl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/spl/spl.c b/common/spl/spl.c
index a76ea3a60342..efe8b7710034 100644
--- a/common/spl/spl.c
+++ b/common/spl/spl.c
@@ -316,7 +316,7 @@ static int boot_from_devices(struct spl_image_info *spl_image,
loader = spl_ll_find_loader(spl_boot_list[i]);
#if defined(CONFIG_SPL_SERIAL_SUPPORT) && defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
if (loader)
- printf("Trying to boot from %s", loader->name);
+ printf("Trying to boot from %s\n", loader->name);
else
puts("SPL: Unsupported Boot Device!\n");
#endif
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] spl: Add missing line ending to SPL print
2017-01-16 12:06 [U-Boot] [PATCH] spl: Add missing line ending to SPL print Michal Simek
@ 2017-01-16 15:37 ` Lokesh Vutla
2017-01-16 15:49 ` Michal Simek
2017-01-21 3:38 ` [U-Boot] " Tom Rini
1 sibling, 1 reply; 5+ messages in thread
From: Lokesh Vutla @ 2017-01-16 15:37 UTC (permalink / raw)
To: u-boot
On Monday 16 January 2017 05:36 PM, Michal Simek wrote:
> One print requires line ending to be aligned with SW running
> after it. Prints look weird without it.
>
> For example:
> U-Boot SPL 2017.01-01801-g1fb1292c7b9d (Jan 16 2017 - 12:50:53)
> EL Level: EL3
> Trying to boot from SPINOTICE: ATF running on XCZU15EG/silicon
> v2/RTL5.1 at 0xfffe5000, with PMU firmware
> NOTICE: BL31: Secure code at 0x0
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
A similar patches posted sometime back
http://patchwork.ozlabs.org/patch/714521/
Thanks and regards,
Lokesh
> ---
>
> common/spl/spl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/spl/spl.c b/common/spl/spl.c
> index a76ea3a60342..efe8b7710034 100644
> --- a/common/spl/spl.c
> +++ b/common/spl/spl.c
> @@ -316,7 +316,7 @@ static int boot_from_devices(struct spl_image_info *spl_image,
> loader = spl_ll_find_loader(spl_boot_list[i]);
> #if defined(CONFIG_SPL_SERIAL_SUPPORT) && defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
> if (loader)
> - printf("Trying to boot from %s", loader->name);
> + printf("Trying to boot from %s\n", loader->name);
> else
> puts("SPL: Unsupported Boot Device!\n");
> #endif
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] spl: Add missing line ending to SPL print
2017-01-16 15:37 ` Lokesh Vutla
@ 2017-01-16 15:49 ` Michal Simek
2017-01-21 3:51 ` Simon Glass
0 siblings, 1 reply; 5+ messages in thread
From: Michal Simek @ 2017-01-16 15:49 UTC (permalink / raw)
To: u-boot
On 16.1.2017 16:37, Lokesh Vutla wrote:
>
>
> On Monday 16 January 2017 05:36 PM, Michal Simek wrote:
>> One print requires line ending to be aligned with SW running
>> after it. Prints look weird without it.
>>
>> For example:
>> U-Boot SPL 2017.01-01801-g1fb1292c7b9d (Jan 16 2017 - 12:50:53)
>> EL Level: EL3
>> Trying to boot from SPINOTICE: ATF running on XCZU15EG/silicon
>> v2/RTL5.1 at 0xfffe5000, with PMU firmware
>> NOTICE: BL31: Secure code at 0x0
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>
> A similar patches posted sometime back
> http://patchwork.ozlabs.org/patch/714521/
wonderful. Please ignore this patch and take origin one.
Thanks,
Michal
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] spl: Add missing line ending to SPL print
2017-01-16 15:49 ` Michal Simek
@ 2017-01-21 3:51 ` Simon Glass
0 siblings, 0 replies; 5+ messages in thread
From: Simon Glass @ 2017-01-21 3:51 UTC (permalink / raw)
To: u-boot
On 16 January 2017 at 08:49, Michal Simek <michal.simek@xilinx.com> wrote:
> On 16.1.2017 16:37, Lokesh Vutla wrote:
>>
>>
>> On Monday 16 January 2017 05:36 PM, Michal Simek wrote:
>>> One print requires line ending to be aligned with SW running
>>> after it. Prints look weird without it.
>>>
>>> For example:
>>> U-Boot SPL 2017.01-01801-g1fb1292c7b9d (Jan 16 2017 - 12:50:53)
>>> EL Level: EL3
>>> Trying to boot from SPINOTICE: ATF running on XCZU15EG/silicon
>>> v2/RTL5.1 at 0xfffe5000, with PMU firmware
>>> NOTICE: BL31: Secure code at 0x0
>>>
>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>
>> A similar patches posted sometime back
>> http://patchwork.ozlabs.org/patch/714521/
>
> wonderful. Please ignore this patch and take origin one.
Reviewed-by: Simon Glass <sjg@chromium.org>
I prefer this patch :-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] spl: Add missing line ending to SPL print
2017-01-16 12:06 [U-Boot] [PATCH] spl: Add missing line ending to SPL print Michal Simek
2017-01-16 15:37 ` Lokesh Vutla
@ 2017-01-21 3:38 ` Tom Rini
1 sibling, 0 replies; 5+ messages in thread
From: Tom Rini @ 2017-01-21 3:38 UTC (permalink / raw)
To: u-boot
On Mon, Jan 16, 2017 at 01:06:48PM +0100, Michal Simek wrote:
> One print requires line ending to be aligned with SW running
> after it. Prints look weird without it.
>
> For example:
> U-Boot SPL 2017.01-01801-g1fb1292c7b9d (Jan 16 2017 - 12:50:53)
> EL Level: EL3
> Trying to boot from SPINOTICE: ATF running on XCZU15EG/silicon
> v2/RTL5.1 at 0xfffe5000, with PMU firmware
> NOTICE: BL31: Secure code at 0x0
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170120/81917eea/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-01-21 3:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-16 12:06 [U-Boot] [PATCH] spl: Add missing line ending to SPL print Michal Simek
2017-01-16 15:37 ` Lokesh Vutla
2017-01-16 15:49 ` Michal Simek
2017-01-21 3:51 ` Simon Glass
2017-01-21 3:38 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.