All of lore.kernel.org
 help / color / mirror / Atom feed
From: In-Ki Dae <inki.dae@samsung.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "kmpark@infradead.org" <kmpark@infradead.org>,
	"linux-fbdev-devel@lists.sourceforge.net"
	<linux-fbdev-devel@lists.sourceforge.net>,
	Ben Dooks <ben-linux@fluff.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: Re: [PATCH 1/3] FB: Add some members for CPU Interface.
Date: Fri, 02 Jul 2010 02:35:26 +0000 (GMT)	[thread overview]
Message-ID: <30082026.20641278038126412.JavaMail.weblogic@epml12> (raw)

Ok, andrew

I will add descriptions to these variables also apply commends of other developers.

Thank you.
------- Original Message -------
Sender : Andrew Morton<akpm@linux-foundation.org> 
Date   : 2010-07-02 10:46 (GMT+09:00)
Title  : Re: [PATCH 1/3] FB: Add some members for CPU Interface.

On Fri, 02 Jul 2010 01:21:12 +0000 (GMT) In-Ki Dae <inki.dae@samsung.com> wrote:

> Hi, Andrew,
> 
> cpu timing variables could be used generically.
> now fb.h and modedb.c file have been considered only for video mode.
> but the way of transfering screen data includes also command mode(cpu mode or i80 mode)
> so I thought it should be added things for it to fb_varscreeninfo struct.
> 
> Could you please tell me why cpu timing variables are specific to s3c-fb?

I dunno - I was just looking at the code.

I don't even know what "cpu timing variables" _are_, in the context of
video drivers.  Look at this:

> > CPU interface needs cs, wr setup, wr act and hold delay.
> > I added some members for them to common framework.

It's gobbledigook!  Please, write patch descriptions which help poor
dumb people who don't have detailed knowledge of the particular
hardware understand your patch?

WARNING: multiple messages have this Message-ID (diff)
From: inki.dae@samsung.com (In-Ki Dae)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] FB: Add some members for CPU Interface.
Date: Fri, 02 Jul 2010 02:35:26 +0000 (GMT)	[thread overview]
Message-ID: <30082026.20641278038126412.JavaMail.weblogic@epml12> (raw)

Ok, andrew

I will add descriptions to these variables also apply commends of other developers.

Thank you.
------- Original Message -------
Sender : Andrew Morton<akpm@linux-foundation.org> 
Date   : 2010-07-02 10:46 (GMT+09:00)
Title  : Re: [PATCH 1/3] FB: Add some members for CPU Interface.

On Fri, 02 Jul 2010 01:21:12 +0000 (GMT) In-Ki Dae <inki.dae@samsung.com> wrote:

> Hi, Andrew,
> 
> cpu timing variables could be used generically.
> now fb.h and modedb.c file have been considered only for video mode.
> but the way of transfering screen data includes also command mode(cpu mode or i80 mode)
> so I thought it should be added things for it to fb_varscreeninfo struct.
> 
> Could you please tell me why cpu timing variables are specific to s3c-fb?

I dunno - I was just looking at the code.

I don't even know what "cpu timing variables" _are_, in the context of
video drivers.  Look at this:

> > CPU interface needs cs, wr setup, wr act and hold delay.
> > I added some members for them to common framework.

It's gobbledigook!  Please, write patch descriptions which help poor
dumb people who don't have detailed knowledge of the particular
hardware understand your patch?

             reply	other threads:[~2010-07-02  2:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-02  2:35 In-Ki Dae [this message]
2010-07-02  2:35 ` [PATCH 1/3] FB: Add some members for CPU Interface In-Ki Dae
  -- strict thread matches above, loose matches on Subject: below --
2010-07-02  1:21 In-Ki Dae
2010-06-30  0:02 Jaya Kumar
2010-07-02  1:51 ` In-Ki Dae
2010-07-02  7:50 ` In-Ki Dae
2010-07-06 16:09   ` James Simmons
2010-07-08  0:52 ` In-Ki Dae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30082026.20641278038126412.JavaMail.weblogic@epml12 \
    --to=inki.dae@samsung.com \
    --cc=akpm@linux-foundation.org \
    --cc=ben-linux@fluff.org \
    --cc=kmpark@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.