Memory leak in BFQ?

Memory leak in BFQ?

[Bart Van Assche]

SGVsbG8gUGFvbG8sDQoNCklmIEkgcnVuIHRoZSBmb2xsb3dpbmcgY29tbWFuZHM6DQoNCiMgZWNo
byBiZnEgPiAvc3lzL2Jsb2NrL3NkYS9xdWV1ZS9zY2hlZHVsZXIgDQojIGVjaG8gMyA+L3Byb2Mv
c3lzL3ZtL2Ryb3BfY2FjaGVzOyBmaW5kIC8gLXhkZXYgPi9kZXYvbnVsbA0KIyBlY2hvIG5vbmUg
PiAvc3lzL2Jsb2NrL3NkYS9xdWV1ZS9zY2hlZHVsZXINCiMgZWNobyBzY2FuID4gL3N5cy9rZXJu
ZWwvZGVidWcva21lbWxlYWsNCg0KVGhlbiBrbWVtbGVhayByZXBvcnRzIHRoZSBmb2xsb3dpbmc6
DQoNCnVucmVmZXJlbmNlZCBvYmplY3QgMHhmZmZmODgwNDA1MTQ5MTU4IChzaXplIDQwOTYpOg0K
ICBjb21tICJiYXNoIiwgcGlkIDE3MTYsIGppZmZpZXMgNDI5NDk2MDM4NiAoYWdlIDc1MjU2Ljk3
MHMpDQogIGhleCBkdW1wIChmaXJzdCAzMiBieXRlcyk6DQogICAgNDggYTUgZjQgYTMgMDQgODgg
ZmYgZmYgMDEgMDAgMDAgMDAgMDAgMDAgMDAgMDAgIEguLi4uLi4uLi4uLi4uLi4NCiAgICAwMCAw
MCAwMCAwMCAwMCAwMCAwMCAwMCAwMCAwMCAwMCAwMCAwMCAwMCAwMCAwMCAgLi4uLi4uLi4uLi4u
Li4uLg0KICBiYWNrdHJhY2U6DQogICAgWzxmZmZmZmZmZjgxNjVhNTBhPl0ga21lbWxlYWtfYWxs
b2MrMHg0YS8weGEwDQogICAgWzxmZmZmZmZmZjgxMWY1MTE0Pl0ga21lbV9jYWNoZV9hbGxvY19u
b2RlX3RyYWNlKzB4MTU0LzB4MzEwDQogICAgWzxmZmZmZmZmZmEwNzA4N2JjPl0gYmZxX3BkX2Fs
bG9jKzB4M2MvMHgzZjAgW2JmcV0NCiAgICBbPGZmZmZmZmZmODEzMGU0YmM+XSBibGtjZ19hY3Rp
dmF0ZV9wb2xpY3krMHhhYy8weDE3MA0KICAgIFs8ZmZmZmZmZmZhMDcwOWI0Yz5dIGJmcV9jcmVh
dGVfZ3JvdXBfaGllcmFyY2h5KzB4MWMvMHg2NiBbYmZxXQ0KICAgIFs8ZmZmZmZmZmZhMDcwMjc3
Yj5dIGJmcV9pbml0X3F1ZXVlKzB4MjhiLzB4MzUwIFtiZnFdDQogICAgWzxmZmZmZmZmZjgxMzAy
MjNiPl0gYmxrX21xX2luaXRfc2NoZWQrMHhiYi8weDE1MA0KICAgIFs8ZmZmZmZmZmY4MTJlNmI0
Mj5dIGVsZXZhdG9yX3N3aXRjaCsweDYyLzB4MjEwDQogICAgWzxmZmZmZmZmZjgxMmU3Y2EyPl0g
ZWx2X2lvc2NoZWRfc3RvcmUrMHhlMi8weDE4MA0KICAgIFs8ZmZmZmZmZmY4MTJmMjNhOT5dIHF1
ZXVlX2F0dHJfc3RvcmUrMHg1OS8weDkwDQogICAgWzxmZmZmZmZmZjgxMmFjNzE1Pl0gc3lzZnNf
a2Zfd3JpdGUrMHg0NS8weDYwDQogICAgWzxmZmZmZmZmZjgxMmFiZmQ0Pl0ga2VybmZzX2ZvcF93
cml0ZSsweDEyNC8weDFjMA0KICAgIFs8ZmZmZmZmZmY4MTIxZDIxOD5dIF9fdmZzX3dyaXRlKzB4
MjgvMHgxNTANCiAgICBbPGZmZmZmZmZmODEyMWU3ZTc+XSB2ZnNfd3JpdGUrMHhjNy8weDFiMA0K
ICAgIFs8ZmZmZmZmZmY4MTIxZmQ2OT5dIFN5U193cml0ZSsweDQ5LzB4YTANCiAgICBbPGZmZmZm
ZmZmODE2NjdjMmE+XSBlbnRyeV9TWVNDQUxMXzY0X2Zhc3RwYXRoKzB4MTgvMHhhZA0KDQpDb3Vs
ZCB0aGlzIGluZGljYXRlIGEgbWVtb3J5IGxlYWsgaW4gdGhlIEJGUSBjb2RlPw0KDQpUaGFua3Ms
DQoNCkJhcnQu

Re: Memory leak in BFQ?

[Paolo Valente]

> Il giorno 31 ago 2017, alle ore 22:42, Bart Van Assche =
<bart.vanassche@wdc.com> ha scritto:
>=20
> Hello Paolo,
>=20
> If I run the following commands:
>=20
> # echo bfq > /sys/block/sda/queue/scheduler=20
> # echo 3 >/proc/sys/vm/drop_caches; find / -xdev >/dev/null
> # echo none > /sys/block/sda/queue/scheduler
> # echo scan > /sys/kernel/debug/kmemleak
>=20
> Then kmemleak reports the following:
>=20
> unreferenced object 0xffff880405149158 (size 4096):
>  comm "bash", pid 1716, jiffies 4294960386 (age 75256.970s)
>  hex dump (first 32 bytes):
>    48 a5 f4 a3 04 88 ff ff 01 00 00 00 00 00 00 00  H...............
>    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>  backtrace:
>    [<ffffffff8165a50a>] kmemleak_alloc+0x4a/0xa0
>    [<ffffffff811f5114>] kmem_cache_alloc_node_trace+0x154/0x310
>    [<ffffffffa07087bc>] bfq_pd_alloc+0x3c/0x3f0 [bfq]
>    [<ffffffff8130e4bc>] blkcg_activate_policy+0xac/0x170
>    [<ffffffffa0709b4c>] bfq_create_group_hierarchy+0x1c/0x66 [bfq]
>    [<ffffffffa070277b>] bfq_init_queue+0x28b/0x350 [bfq]
>    [<ffffffff8130223b>] blk_mq_init_sched+0xbb/0x150
>    [<ffffffff812e6b42>] elevator_switch+0x62/0x210
>    [<ffffffff812e7ca2>] elv_iosched_store+0xe2/0x180
>    [<ffffffff812f23a9>] queue_attr_store+0x59/0x90
>    [<ffffffff812ac715>] sysfs_kf_write+0x45/0x60
>    [<ffffffff812abfd4>] kernfs_fop_write+0x124/0x1c0
>    [<ffffffff8121d218>] __vfs_write+0x28/0x150
>    [<ffffffff8121e7e7>] vfs_write+0xc7/0x1b0
>    [<ffffffff8121fd69>] SyS_write+0x49/0xa0
>    [<ffffffff81667c2a>] entry_SYSCALL_64_fastpath+0x18/0xad
>=20
> Could this indicate a memory leak in the BFQ code?
>=20

I guess so.  But I've been trying to reproduce it at no avail.  Is it
readily reproducible in your system?  If so, did you happen, by chance,
to find also some other way to reproduce it?

Thanks,
Paolo

> Thanks,
>=20
> Bart.