[PATCH 1/2] powerpc/booke64: Add LRAT error exception handler

[PATCH 1/2] powerpc/booke64: Add LRAT error exception handler

[Mihai Caraman]

Add LRAT (Logical to Real Address Translation) error exception handler to
Booke3E 64-bit kernel. LRAT support in KVM will follow afterwards.

Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
---
 arch/powerpc/include/asm/kvm_asm.h   |    1 +
 arch/powerpc/include/asm/reg_booke.h |    1 +
 arch/powerpc/kernel/exceptions-64e.S |   14 ++++++++++++++
 3 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/include/asm/kvm_asm.h b/arch/powerpc/include/asm/kvm_asm.h
index 851bac7..83b91e5 100644
--- a/arch/powerpc/include/asm/kvm_asm.h
+++ b/arch/powerpc/include/asm/kvm_asm.h
@@ -74,6 +74,7 @@
 #define BOOKE_INTERRUPT_GUEST_DBELL_CRIT 39
 #define BOOKE_INTERRUPT_HV_SYSCALL 40
 #define BOOKE_INTERRUPT_HV_PRIV 41
+#define BOOKE_INTERRUPT_LRAT_ERROR 42
 
 /* book3s */
 
diff --git a/arch/powerpc/include/asm/reg_booke.h b/arch/powerpc/include/asm/reg_booke.h
index b417de3..6b113e1 100644
--- a/arch/powerpc/include/asm/reg_booke.h
+++ b/arch/powerpc/include/asm/reg_booke.h
@@ -101,6 +101,7 @@
 #define SPRN_IVOR39	0x1B1	/* Interrupt Vector Offset Register 39 */
 #define SPRN_IVOR40	0x1B2	/* Interrupt Vector Offset Register 40 */
 #define SPRN_IVOR41	0x1B3	/* Interrupt Vector Offset Register 41 */
+#define SPRN_IVOR42	0x1B4	/* Interrupt Vector Offset Register 42 */
 #define SPRN_GIVOR2	0x1B8	/* Guest IVOR2 */
 #define SPRN_GIVOR3	0x1B9	/* Guest IVOR3 */
 #define SPRN_GIVOR4	0x1BA	/* Guest IVOR4 */
diff --git a/arch/powerpc/kernel/exceptions-64e.S b/arch/powerpc/kernel/exceptions-64e.S
index 0c379e9..e08b469 100644
--- a/arch/powerpc/kernel/exceptions-64e.S
+++ b/arch/powerpc/kernel/exceptions-64e.S
@@ -308,6 +308,7 @@ interrupt_base_book3e:					/* fake trap */
 	EXCEPTION_STUB(0x2e0, guest_doorbell_crit)
 	EXCEPTION_STUB(0x300, hypercall)
 	EXCEPTION_STUB(0x320, ehpriv)
+	EXCEPTION_STUB(0x340, lrat_error)
 
 	.globl interrupt_end_book3e
 interrupt_end_book3e:
@@ -676,6 +677,17 @@ kernel_dbg_exc:
 	bl	.unknown_exception
 	b	.ret_from_except
 
+/* LRAT Error interrupt */
+	START_EXCEPTION(lrat_error);
+	NORMAL_EXCEPTION_PROLOG(0x340, BOOKE_INTERRUPT_LRAT_ERROR,
+			        PROLOG_ADDITION_NONE)
+	EXCEPTION_COMMON(0x340, PACA_EXGEN, INTS_KEEP)
+	addi	r3,r1,STACK_FRAME_OVERHEAD
+	bl	.save_nvgprs
+	INTS_RESTORE_HARD
+	bl	.unknown_exception
+	b	.ret_from_except
+
 /*
  * An interrupt came in while soft-disabled; We mark paca->irq_happened
  * accordingly and if the interrupt is level sensitive, we hard disable
@@ -858,6 +870,7 @@ BAD_STACK_TRAMPOLINE(0x2e0)
 BAD_STACK_TRAMPOLINE(0x300)
 BAD_STACK_TRAMPOLINE(0x310)
 BAD_STACK_TRAMPOLINE(0x320)
+BAD_STACK_TRAMPOLINE(0x340)
 BAD_STACK_TRAMPOLINE(0x400)
 BAD_STACK_TRAMPOLINE(0x500)
 BAD_STACK_TRAMPOLINE(0x600)
@@ -1410,6 +1423,7 @@ _GLOBAL(setup_doorbell_ivors)
 _GLOBAL(setup_ehv_ivors)
 	SET_IVOR(40, 0x300) /* Embedded Hypervisor System Call */
 	SET_IVOR(41, 0x320) /* Embedded Hypervisor Privilege */
+	SET_IVOR(42, 0x340) /* LRAT Error */
 	SET_IVOR(38, 0x2c0) /* Guest Processor Doorbell */
 	SET_IVOR(39, 0x2e0) /* Guest Processor Doorbell Crit/MC */
 	blr
-- 
1.7.3.4

[PATCH 1/2] powerpc/booke64: Add LRAT error exception handler

[Mihai Caraman]

Add LRAT (Logical to Real Address Translation) error exception handler to
Booke3E 64-bit kernel. LRAT support in KVM will follow afterwards.

Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
---
 arch/powerpc/include/asm/kvm_asm.h   |    1 +
 arch/powerpc/include/asm/reg_booke.h |    1 +
 arch/powerpc/kernel/exceptions-64e.S |   14 ++++++++++++++
 3 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/include/asm/kvm_asm.h b/arch/powerpc/include/asm/kvm_asm.h
index 851bac7..83b91e5 100644
--- a/arch/powerpc/include/asm/kvm_asm.h
+++ b/arch/powerpc/include/asm/kvm_asm.h
@@ -74,6 +74,7 @@
 #define BOOKE_INTERRUPT_GUEST_DBELL_CRIT 39
 #define BOOKE_INTERRUPT_HV_SYSCALL 40
 #define BOOKE_INTERRUPT_HV_PRIV 41
+#define BOOKE_INTERRUPT_LRAT_ERROR 42
 
 /* book3s */
 
diff --git a/arch/powerpc/include/asm/reg_booke.h b/arch/powerpc/include/asm/reg_booke.h
index b417de3..6b113e1 100644
--- a/arch/powerpc/include/asm/reg_booke.h
+++ b/arch/powerpc/include/asm/reg_booke.h
@@ -101,6 +101,7 @@
 #define SPRN_IVOR39	0x1B1	/* Interrupt Vector Offset Register 39 */
 #define SPRN_IVOR40	0x1B2	/* Interrupt Vector Offset Register 40 */
 #define SPRN_IVOR41	0x1B3	/* Interrupt Vector Offset Register 41 */
+#define SPRN_IVOR42	0x1B4	/* Interrupt Vector Offset Register 42 */
 #define SPRN_GIVOR2	0x1B8	/* Guest IVOR2 */
 #define SPRN_GIVOR3	0x1B9	/* Guest IVOR3 */
 #define SPRN_GIVOR4	0x1BA	/* Guest IVOR4 */
diff --git a/arch/powerpc/kernel/exceptions-64e.S b/arch/powerpc/kernel/exceptions-64e.S
index 0c379e9..e08b469 100644
--- a/arch/powerpc/kernel/exceptions-64e.S
+++ b/arch/powerpc/kernel/exceptions-64e.S
@@ -308,6 +308,7 @@ interrupt_base_book3e:					/* fake trap */
 	EXCEPTION_STUB(0x2e0, guest_doorbell_crit)
 	EXCEPTION_STUB(0x300, hypercall)
 	EXCEPTION_STUB(0x320, ehpriv)
+	EXCEPTION_STUB(0x340, lrat_error)
 
 	.globl interrupt_end_book3e
 interrupt_end_book3e:
@@ -676,6 +677,17 @@ kernel_dbg_exc:
 	bl	.unknown_exception
 	b	.ret_from_except
 
+/* LRAT Error interrupt */
+	START_EXCEPTION(lrat_error);
+	NORMAL_EXCEPTION_PROLOG(0x340, BOOKE_INTERRUPT_LRAT_ERROR,
+			        PROLOG_ADDITION_NONE)
+	EXCEPTION_COMMON(0x340, PACA_EXGEN, INTS_KEEP)
+	addi	r3,r1,STACK_FRAME_OVERHEAD
+	bl	.save_nvgprs
+	INTS_RESTORE_HARD
+	bl	.unknown_exception
+	b	.ret_from_except
+
 /*
  * An interrupt came in while soft-disabled; We mark paca->irq_happened
  * accordingly and if the interrupt is level sensitive, we hard disable
@@ -858,6 +870,7 @@ BAD_STACK_TRAMPOLINE(0x2e0)
 BAD_STACK_TRAMPOLINE(0x300)
 BAD_STACK_TRAMPOLINE(0x310)
 BAD_STACK_TRAMPOLINE(0x320)
+BAD_STACK_TRAMPOLINE(0x340)
 BAD_STACK_TRAMPOLINE(0x400)
 BAD_STACK_TRAMPOLINE(0x500)
 BAD_STACK_TRAMPOLINE(0x600)
@@ -1410,6 +1423,7 @@ _GLOBAL(setup_doorbell_ivors)
 _GLOBAL(setup_ehv_ivors)
 	SET_IVOR(40, 0x300) /* Embedded Hypervisor System Call */
 	SET_IVOR(41, 0x320) /* Embedded Hypervisor Privilege */
+	SET_IVOR(42, 0x340) /* LRAT Error */
 	SET_IVOR(38, 0x2c0) /* Guest Processor Doorbell */
 	SET_IVOR(39, 0x2e0) /* Guest Processor Doorbell Crit/MC */
 	blr
-- 
1.7.3.4

[PATCH 1/2] powerpc/booke64: Add LRAT error exception handler

[Mihai Caraman]

Add LRAT (Logical to Real Address Translation) error exception handler to
Booke3E 64-bit kernel. LRAT support in KVM will follow afterwards.

Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
---
 arch/powerpc/include/asm/kvm_asm.h   |    1 +
 arch/powerpc/include/asm/reg_booke.h |    1 +
 arch/powerpc/kernel/exceptions-64e.S |   14 ++++++++++++++
 3 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/include/asm/kvm_asm.h b/arch/powerpc/include/asm/kvm_asm.h
index 851bac7..83b91e5 100644
--- a/arch/powerpc/include/asm/kvm_asm.h
+++ b/arch/powerpc/include/asm/kvm_asm.h
@@ -74,6 +74,7 @@
 #define BOOKE_INTERRUPT_GUEST_DBELL_CRIT 39
 #define BOOKE_INTERRUPT_HV_SYSCALL 40
 #define BOOKE_INTERRUPT_HV_PRIV 41
+#define BOOKE_INTERRUPT_LRAT_ERROR 42
 
 /* book3s */
 
diff --git a/arch/powerpc/include/asm/reg_booke.h b/arch/powerpc/include/asm/reg_booke.h
index b417de3..6b113e1 100644
--- a/arch/powerpc/include/asm/reg_booke.h
+++ b/arch/powerpc/include/asm/reg_booke.h
@@ -101,6 +101,7 @@
 #define SPRN_IVOR39	0x1B1	/* Interrupt Vector Offset Register 39 */
 #define SPRN_IVOR40	0x1B2	/* Interrupt Vector Offset Register 40 */
 #define SPRN_IVOR41	0x1B3	/* Interrupt Vector Offset Register 41 */
+#define SPRN_IVOR42	0x1B4	/* Interrupt Vector Offset Register 42 */
 #define SPRN_GIVOR2	0x1B8	/* Guest IVOR2 */
 #define SPRN_GIVOR3	0x1B9	/* Guest IVOR3 */
 #define SPRN_GIVOR4	0x1BA	/* Guest IVOR4 */
diff --git a/arch/powerpc/kernel/exceptions-64e.S b/arch/powerpc/kernel/exceptions-64e.S
index 0c379e9..e08b469 100644
--- a/arch/powerpc/kernel/exceptions-64e.S
+++ b/arch/powerpc/kernel/exceptions-64e.S
@@ -308,6 +308,7 @@ interrupt_base_book3e:					/* fake trap */
 	EXCEPTION_STUB(0x2e0, guest_doorbell_crit)
 	EXCEPTION_STUB(0x300, hypercall)
 	EXCEPTION_STUB(0x320, ehpriv)
+	EXCEPTION_STUB(0x340, lrat_error)
 
 	.globl interrupt_end_book3e
 interrupt_end_book3e:
@@ -676,6 +677,17 @@ kernel_dbg_exc:
 	bl	.unknown_exception
 	b	.ret_from_except
 
+/* LRAT Error interrupt */
+	START_EXCEPTION(lrat_error);
+	NORMAL_EXCEPTION_PROLOG(0x340, BOOKE_INTERRUPT_LRAT_ERROR,
+			        PROLOG_ADDITION_NONE)
+	EXCEPTION_COMMON(0x340, PACA_EXGEN, INTS_KEEP)
+	addi	r3,r1,STACK_FRAME_OVERHEAD
+	bl	.save_nvgprs
+	INTS_RESTORE_HARD
+	bl	.unknown_exception
+	b	.ret_from_except
+
 /*
  * An interrupt came in while soft-disabled; We mark paca->irq_happened
  * accordingly and if the interrupt is level sensitive, we hard disable
@@ -858,6 +870,7 @@ BAD_STACK_TRAMPOLINE(0x2e0)
 BAD_STACK_TRAMPOLINE(0x300)
 BAD_STACK_TRAMPOLINE(0x310)
 BAD_STACK_TRAMPOLINE(0x320)
+BAD_STACK_TRAMPOLINE(0x340)
 BAD_STACK_TRAMPOLINE(0x400)
 BAD_STACK_TRAMPOLINE(0x500)
 BAD_STACK_TRAMPOLINE(0x600)
@@ -1410,6 +1423,7 @@ _GLOBAL(setup_doorbell_ivors)
 _GLOBAL(setup_ehv_ivors)
 	SET_IVOR(40, 0x300) /* Embedded Hypervisor System Call */
 	SET_IVOR(41, 0x320) /* Embedded Hypervisor Privilege */
+	SET_IVOR(42, 0x340) /* LRAT Error */
 	SET_IVOR(38, 0x2c0) /* Guest Processor Doorbell */
 	SET_IVOR(39, 0x2e0) /* Guest Processor Doorbell Crit/MC */
 	blr
-- 
1.7.3.4

[PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

[Mihai Caraman]

With LRAT (Logical to Real Address Translation) error exception handler in kernel
KVM needs to add the counterpart otherwise will break the build.

Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
---
 arch/powerpc/kvm/bookehv_interrupts.S |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/kvm/bookehv_interrupts.S b/arch/powerpc/kvm/bookehv_interrupts.S
index e8ed7d6..a0d6929 100644
--- a/arch/powerpc/kvm/bookehv_interrupts.S
+++ b/arch/powerpc/kvm/bookehv_interrupts.S
@@ -319,6 +319,8 @@ kvm_handler BOOKE_INTERRUPT_DEBUG, EX_PARAMS(DBG), \
 	SPRN_DSRR0, SPRN_DSRR1, 0
 kvm_handler BOOKE_INTERRUPT_DEBUG, EX_PARAMS(CRIT), \
 	SPRN_CSRR0, SPRN_CSRR1, 0
+kvm_handler BOOKE_INTERRUPT_LRAT_ERROR, EX_PARAMS(GEN), \
+	SPRN_SRR0, SPRN_SRR1, (NEED_EMU | NEED_DEAR | NEED_ESR)
 #else
 /*
  * For input register values, see arch/powerpc/include/asm/kvm_booke_hv_asm.h
-- 
1.7.3.4

[PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

[Mihai Caraman]

With LRAT (Logical to Real Address Translation) error exception handler in kernel
KVM needs to add the counterpart otherwise will break the build.

Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
---
 arch/powerpc/kvm/bookehv_interrupts.S |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/kvm/bookehv_interrupts.S b/arch/powerpc/kvm/bookehv_interrupts.S
index e8ed7d6..a0d6929 100644
--- a/arch/powerpc/kvm/bookehv_interrupts.S
+++ b/arch/powerpc/kvm/bookehv_interrupts.S
@@ -319,6 +319,8 @@ kvm_handler BOOKE_INTERRUPT_DEBUG, EX_PARAMS(DBG), \
 	SPRN_DSRR0, SPRN_DSRR1, 0
 kvm_handler BOOKE_INTERRUPT_DEBUG, EX_PARAMS(CRIT), \
 	SPRN_CSRR0, SPRN_CSRR1, 0
+kvm_handler BOOKE_INTERRUPT_LRAT_ERROR, EX_PARAMS(GEN), \
+	SPRN_SRR0, SPRN_SRR1, (NEED_EMU | NEED_DEAR | NEED_ESR)
 #else
 /*
  * For input register values, see arch/powerpc/include/asm/kvm_booke_hv_asm.h
-- 
1.7.3.4

[PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

[Mihai Caraman]

With LRAT (Logical to Real Address Translation) error exception handler in kernel
KVM needs to add the counterpart otherwise will break the build.

Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
---
 arch/powerpc/kvm/bookehv_interrupts.S |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/kvm/bookehv_interrupts.S b/arch/powerpc/kvm/bookehv_interrupts.S
index e8ed7d6..a0d6929 100644
--- a/arch/powerpc/kvm/bookehv_interrupts.S
+++ b/arch/powerpc/kvm/bookehv_interrupts.S
@@ -319,6 +319,8 @@ kvm_handler BOOKE_INTERRUPT_DEBUG, EX_PARAMS(DBG), \
 	SPRN_DSRR0, SPRN_DSRR1, 0
 kvm_handler BOOKE_INTERRUPT_DEBUG, EX_PARAMS(CRIT), \
 	SPRN_CSRR0, SPRN_CSRR1, 0
+kvm_handler BOOKE_INTERRUPT_LRAT_ERROR, EX_PARAMS(GEN), \
+	SPRN_SRR0, SPRN_SRR1, (NEED_EMU | NEED_DEAR | NEED_ESR)
 #else
 /*
  * For input register values, see arch/powerpc/include/asm/kvm_booke_hv_asm.h
-- 
1.7.3.4

Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

[Scott Wood]

On 07/03/2013 11:56:06 AM, Mihai Caraman wrote:
> With LRAT (Logical to Real Address Translation) error exception  
> handler in kernel
> KVM needs to add the counterpart otherwise will break the build.
> 
> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
> ---
>  arch/powerpc/kvm/bookehv_interrupts.S |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Please combine these two patches to avoid breaking bisectability.

-Scott

Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

[Scott Wood]

On 07/03/2013 11:56:06 AM, Mihai Caraman wrote:
> With LRAT (Logical to Real Address Translation) error exception =20
> handler in kernel
> KVM needs to add the counterpart otherwise will break the build.
>=20
> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
> ---
>  arch/powerpc/kvm/bookehv_interrupts.S |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Please combine these two patches to avoid breaking bisectability.

-Scott=

Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

[Scott Wood]

On 07/03/2013 11:56:06 AM, Mihai Caraman wrote:
> With LRAT (Logical to Real Address Translation) error exception  
> handler in kernel
> KVM needs to add the counterpart otherwise will break the build.
> 
> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
> ---
>  arch/powerpc/kvm/bookehv_interrupts.S |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Please combine these two patches to avoid breaking bisectability.

-Scott

Re: [PATCH 1/2] powerpc/booke64: Add LRAT error exception handler

[Scott Wood]

On 07/03/2013 11:56:05 AM, Mihai Caraman wrote:
> @@ -1410,6 +1423,7 @@ _GLOBAL(setup_doorbell_ivors)
>  _GLOBAL(setup_ehv_ivors)
>  	SET_IVOR(40, 0x300) /* Embedded Hypervisor System Call */
>  	SET_IVOR(41, 0x320) /* Embedded Hypervisor Privilege */
> +	SET_IVOR(42, 0x340) /* LRAT Error */

What happens if we write to IVOR42 on e5500?  If the answer is no-op,  
is that behavior guaranteed on any CPU with E.HV but not LRAT?

-Scott

Re: [PATCH 1/2] powerpc/booke64: Add LRAT error exception handler

[Scott Wood]

On 07/03/2013 11:56:05 AM, Mihai Caraman wrote:
> @@ -1410,6 +1423,7 @@ _GLOBAL(setup_doorbell_ivors)
>  _GLOBAL(setup_ehv_ivors)
>  	SET_IVOR(40, 0x300) /* Embedded Hypervisor System Call */
>  	SET_IVOR(41, 0x320) /* Embedded Hypervisor Privilege */
> +	SET_IVOR(42, 0x340) /* LRAT Error */

What happens if we write to IVOR42 on e5500?  If the answer is no-op, =20
is that behavior guaranteed on any CPU with E.HV but not LRAT?

-Scott=

Re: [PATCH 1/2] powerpc/booke64: Add LRAT error exception handler

[Scott Wood]

On 07/03/2013 11:56:05 AM, Mihai Caraman wrote:
> @@ -1410,6 +1423,7 @@ _GLOBAL(setup_doorbell_ivors)
>  _GLOBAL(setup_ehv_ivors)
>  	SET_IVOR(40, 0x300) /* Embedded Hypervisor System Call */
>  	SET_IVOR(41, 0x320) /* Embedded Hypervisor Privilege */
> +	SET_IVOR(42, 0x340) /* LRAT Error */

What happens if we write to IVOR42 on e5500?  If the answer is no-op,  
is that behavior guaranteed on any CPU with E.HV but not LRAT?

-Scott

Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

[Alexander Graf]

On 03.07.2013, at 22:16, Scott Wood wrote:

> On 07/03/2013 11:56:06 AM, Mihai Caraman wrote:
>> With LRAT (Logical to Real Address Translation) error exception handler in kernel
>> KVM needs to add the counterpart otherwise will break the build.
>> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
>> ---
>> arch/powerpc/kvm/bookehv_interrupts.S |    2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
> 
> Please combine these two patches to avoid breaking bisectability.

Why does the split break bisectability?


Alex

Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

[Alexander Graf]

On 03.07.2013, at 22:16, Scott Wood wrote:

> On 07/03/2013 11:56:06 AM, Mihai Caraman wrote:
>> With LRAT (Logical to Real Address Translation) error exception =
handler in kernel
>> KVM needs to add the counterpart otherwise will break the build.
>> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
>> ---
>> arch/powerpc/kvm/bookehv_interrupts.S |    2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>=20
> Please combine these two patches to avoid breaking bisectability.

Why does the split break bisectability?


Alex

Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

[Alexander Graf]

On 03.07.2013, at 22:16, Scott Wood wrote:

> On 07/03/2013 11:56:06 AM, Mihai Caraman wrote:
>> With LRAT (Logical to Real Address Translation) error exception handler in kernel
>> KVM needs to add the counterpart otherwise will break the build.
>> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
>> ---
>> arch/powerpc/kvm/bookehv_interrupts.S |    2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
> 
> Please combine these two patches to avoid breaking bisectability.

Why does the split break bisectability?


Alex

Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

[Scott Wood]

On 07/03/2013 04:42:40 PM, Alexander Graf wrote:
> 
> On 03.07.2013, at 22:16, Scott Wood wrote:
> 
> > On 07/03/2013 11:56:06 AM, Mihai Caraman wrote:
> >> With LRAT (Logical to Real Address Translation) error exception  
> handler in kernel
> >> KVM needs to add the counterpart otherwise will break the build.
> >> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
> >> ---
> >> arch/powerpc/kvm/bookehv_interrupts.S |    2 ++
> >> 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > Please combine these two patches to avoid breaking bisectability.
> 
> Why does the split break bisectability?

Same reason as the altivec build breakage from earlier.  If we add a  
new exception type but not a KVM handler for it, the kernel won't link.

-Scott

Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

[Scott Wood]

On 07/03/2013 04:42:40 PM, Alexander Graf wrote:
>=20
> On 03.07.2013, at 22:16, Scott Wood wrote:
>=20
> > On 07/03/2013 11:56:06 AM, Mihai Caraman wrote:
> >> With LRAT (Logical to Real Address Translation) error exception =20
> handler in kernel
> >> KVM needs to add the counterpart otherwise will break the build.
> >> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
> >> ---
> >> arch/powerpc/kvm/bookehv_interrupts.S |    2 ++
> >> 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > Please combine these two patches to avoid breaking bisectability.
>=20
> Why does the split break bisectability?

Same reason as the altivec build breakage from earlier.  If we add a =20
new exception type but not a KVM handler for it, the kernel won't link.

-Scott=

Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

[Scott Wood]

On 07/03/2013 04:42:40 PM, Alexander Graf wrote:
> 
> On 03.07.2013, at 22:16, Scott Wood wrote:
> 
> > On 07/03/2013 11:56:06 AM, Mihai Caraman wrote:
> >> With LRAT (Logical to Real Address Translation) error exception  
> handler in kernel
> >> KVM needs to add the counterpart otherwise will break the build.
> >> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
> >> ---
> >> arch/powerpc/kvm/bookehv_interrupts.S |    2 ++
> >> 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > Please combine these two patches to avoid breaking bisectability.
> 
> Why does the split break bisectability?

Same reason as the altivec build breakage from earlier.  If we add a  
new exception type but not a KVM handler for it, the kernel won't link.

-Scott

RE: [PATCH 1/2] powerpc/booke64: Add LRAT error exception handler

[Caraman Mihai Claudiu-B02008]

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Wednesday, July 03, 2013 11:18 PM
> To: Caraman Mihai Claudiu-B02008
> Cc: linuxppc-dev@lists.ozlabs.org; kvm-ppc@vger.kernel.org;
> kvm@vger.kernel.org; Caraman Mihai Claudiu-B02008
> Subject: Re: [PATCH 1/2] powerpc/booke64: Add LRAT error exception
> handler
> 
> On 07/03/2013 11:56:05 AM, Mihai Caraman wrote:
> > @@ -1410,6 +1423,7 @@ _GLOBAL(setup_doorbell_ivors)
> >  _GLOBAL(setup_ehv_ivors)
> >  	SET_IVOR(40, 0x300) /* Embedded Hypervisor System Call */
> >  	SET_IVOR(41, 0x320) /* Embedded Hypervisor Privilege */
> > +	SET_IVOR(42, 0x340) /* LRAT Error */
> 
> What happens if we write to IVOR42 on e5500?  If the answer is no-op,
> is that behavior guaranteed on any CPU with E.HV but not LRAT?

Oops. I would rather do it __setup_cpu_e6500 in the same way we deal with AltiVec.

-Mike

RE: [PATCH 1/2] powerpc/booke64: Add LRAT error exception handler

[Caraman Mihai Claudiu-B02008]

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Wednesday, July 03, 2013 11:18 PM
> To: Caraman Mihai Claudiu-B02008
> Cc: linuxppc-dev@lists.ozlabs.org; kvm-ppc@vger.kernel.org;
> kvm@vger.kernel.org; Caraman Mihai Claudiu-B02008
> Subject: Re: [PATCH 1/2] powerpc/booke64: Add LRAT error exception
> handler
>=20
> On 07/03/2013 11:56:05 AM, Mihai Caraman wrote:
> > @@ -1410,6 +1423,7 @@ _GLOBAL(setup_doorbell_ivors)
> >  _GLOBAL(setup_ehv_ivors)
> >  	SET_IVOR(40, 0x300) /* Embedded Hypervisor System Call */
> >  	SET_IVOR(41, 0x320) /* Embedded Hypervisor Privilege */
> > +	SET_IVOR(42, 0x340) /* LRAT Error */
>=20
> What happens if we write to IVOR42 on e5500?  If the answer is no-op,
> is that behavior guaranteed on any CPU with E.HV but not LRAT?

Oops. I would rather do it __setup_cpu_e6500 in the same way we deal with A=
ltiVec.

-Mike

RE: [PATCH 1/2] powerpc/booke64: Add LRAT error exception handler

[Caraman Mihai Claudiu-B02008]

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Wednesday, July 03, 2013 11:18 PM
> To: Caraman Mihai Claudiu-B02008
> Cc: linuxppc-dev@lists.ozlabs.org; kvm-ppc@vger.kernel.org;
> kvm@vger.kernel.org; Caraman Mihai Claudiu-B02008
> Subject: Re: [PATCH 1/2] powerpc/booke64: Add LRAT error exception
> handler
> 
> On 07/03/2013 11:56:05 AM, Mihai Caraman wrote:
> > @@ -1410,6 +1423,7 @@ _GLOBAL(setup_doorbell_ivors)
> >  _GLOBAL(setup_ehv_ivors)
> >  	SET_IVOR(40, 0x300) /* Embedded Hypervisor System Call */
> >  	SET_IVOR(41, 0x320) /* Embedded Hypervisor Privilege */
> > +	SET_IVOR(42, 0x340) /* LRAT Error */
> 
> What happens if we write to IVOR42 on e5500?  If the answer is no-op,
> is that behavior guaranteed on any CPU with E.HV but not LRAT?

Oops. I would rather do it __setup_cpu_e6500 in the same way we deal with AltiVec.

-Mike

RE: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

[Caraman Mihai Claudiu-B02008]

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Wednesday, July 03, 2013 11:17 PM
> To: Caraman Mihai Claudiu-B02008
> Cc: linuxppc-dev@lists.ozlabs.org; kvm-ppc@vger.kernel.org;
> kvm@vger.kernel.org; Caraman Mihai Claudiu-B02008
> Subject: Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception
> handler
> 
> On 07/03/2013 11:56:06 AM, Mihai Caraman wrote:
> > With LRAT (Logical to Real Address Translation) error exception
> > handler in kernel
> > KVM needs to add the counterpart otherwise will break the build.
> >
> > Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
> > ---
> >  arch/powerpc/kvm/bookehv_interrupts.S |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> Please combine these two patches to avoid breaking bisectability.
> 
> -Scott

This is a solid reason. Ben it's ok for you to apply the combined patch?
If so I will respin it.

-Mike

RE: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

[Caraman Mihai Claudiu-B02008]

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Wednesday, July 03, 2013 11:17 PM
> To: Caraman Mihai Claudiu-B02008
> Cc: linuxppc-dev@lists.ozlabs.org; kvm-ppc@vger.kernel.org;
> kvm@vger.kernel.org; Caraman Mihai Claudiu-B02008
> Subject: Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception
> handler
>=20
> On 07/03/2013 11:56:06 AM, Mihai Caraman wrote:
> > With LRAT (Logical to Real Address Translation) error exception
> > handler in kernel
> > KVM needs to add the counterpart otherwise will break the build.
> >
> > Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
> > ---
> >  arch/powerpc/kvm/bookehv_interrupts.S |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
>=20
> Please combine these two patches to avoid breaking bisectability.
>=20
> -Scott

This is a solid reason. Ben it's ok for you to apply the combined patch?
If so I will respin it.

-Mike

RE: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

[Caraman Mihai Claudiu-B02008]

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Wednesday, July 03, 2013 11:17 PM
> To: Caraman Mihai Claudiu-B02008
> Cc: linuxppc-dev@lists.ozlabs.org; kvm-ppc@vger.kernel.org;
> kvm@vger.kernel.org; Caraman Mihai Claudiu-B02008
> Subject: Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception
> handler
> 
> On 07/03/2013 11:56:06 AM, Mihai Caraman wrote:
> > With LRAT (Logical to Real Address Translation) error exception
> > handler in kernel
> > KVM needs to add the counterpart otherwise will break the build.
> >
> > Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
> > ---
> >  arch/powerpc/kvm/bookehv_interrupts.S |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> Please combine these two patches to avoid breaking bisectability.
> 
> -Scott

This is a solid reason. Ben it's ok for you to apply the combined patch?
If so I will respin it.

-Mike

Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

[Benjamin Herrenschmidt]

On Thu, 2013-07-04 at 06:47 +0000, Caraman Mihai Claudiu-B02008 wrote:
> This is a solid reason. Ben it's ok for you to apply the combined
> patch? If so I will respin it.

Sure, but nowadays, all that stuff goes via Scott and Alex.

Cheers,
Ben.

Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

[Benjamin Herrenschmidt]

On Thu, 2013-07-04 at 06:47 +0000, Caraman Mihai Claudiu-B02008 wrote:
> This is a solid reason. Ben it's ok for you to apply the combined
> patch? If so I will respin it.

Sure, but nowadays, all that stuff goes via Scott and Alex.

Cheers,
Ben.

Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

[Benjamin Herrenschmidt]

On Thu, 2013-07-04 at 06:47 +0000, Caraman Mihai Claudiu-B02008 wrote:
> This is a solid reason. Ben it's ok for you to apply the combined
> patch? If so I will respin it.

Sure, but nowadays, all that stuff goes via Scott and Alex.

Cheers,
Ben.