All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@systec-electronic.com>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: plagnioj@jcrosoft.com, tomi.valkeinen@ti.com,
	shawn.guo@linaro.org, linux-fbdev@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 1/4] video: fsl-dcfb: Add dcfb framebuffer driver for LS1021A platform
Date: Thu, 04 Dec 2014 10:21:32 +0100	[thread overview]
Message-ID: <3011460.gQ3SqeWtnL@ws-stein> (raw)
In-Reply-To: <1417598162-40433-2-git-send-email-Li.Xiubo@freescale.com>

On Wednesday 03 December 2014 17:15:59, Xiubo Li wrote:
> +	tnp = of_find_node_by_name(dnp, "display-timings");
> +	if (!tnp) {
> +		dev_err(dcfb->dev, "failed to find \"display-timings\" node\n");
> +		return -ENODEV;
> +		goto put_dnp;
> +	}
> +
> +	for (i = 0; i < of_get_child_count(tnp); i++) {
> +		struct videomode vm;
> +
> +		ret = videomode_from_timings(timings, &vm, i);
> +		if (ret < 0)
> +			goto put_tnp;
> +
> +		ret = fb_videomode_from_videomode(&vm, &fb_vm);
> +		if (ret < 0)
> +			goto put_tnp;
> +
> +		fb_add_videomode(&fb_vm, &info->modelist);
> +	}
> +
> +	ret = of_get_fb_videomode(dnp, &fb_vm, OF_USE_NATIVE_MODE);
> +	if (ret)
> +		goto put_dnp;

Souldn't this be put_tnp like in the loop above? 

> +	fb_videomode_to_var(&info->var, &fb_vm);
> +	ret = fsl_dcfb_check_var(&info->var, info);

But picking the native mode per default looks nice to be! :)

Best regards,
Alexander
-- 
Dipl.-Inf. Alexander Stein

SYS TEC electronic GmbH
Am Windrad 2
08468 Heinsdorfergrund
Tel.: 03765 38600-1156
Fax: 03765 38600-4100
Email: alexander.stein@systec-electronic.com
Website: www.systec-electronic.com
 
Managing Director: Dipl.-Phys. Siegmar Schmidt
Commercial registry: Amtsgericht Chemnitz, HRB 28082


WARNING: multiple messages have this Message-ID (diff)
From: Alexander Stein <alexander.stein@systec-electronic.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2 1/4] video: fsl-dcfb: Add dcfb framebuffer driver for LS1021A platform
Date: Thu, 04 Dec 2014 09:21:32 +0000	[thread overview]
Message-ID: <3011460.gQ3SqeWtnL@ws-stein> (raw)
In-Reply-To: <1417598162-40433-2-git-send-email-Li.Xiubo@freescale.com>

On Wednesday 03 December 2014 17:15:59, Xiubo Li wrote:
> +	tnp = of_find_node_by_name(dnp, "display-timings");
> +	if (!tnp) {
> +		dev_err(dcfb->dev, "failed to find \"display-timings\" node\n");
> +		return -ENODEV;
> +		goto put_dnp;
> +	}
> +
> +	for (i = 0; i < of_get_child_count(tnp); i++) {
> +		struct videomode vm;
> +
> +		ret = videomode_from_timings(timings, &vm, i);
> +		if (ret < 0)
> +			goto put_tnp;
> +
> +		ret = fb_videomode_from_videomode(&vm, &fb_vm);
> +		if (ret < 0)
> +			goto put_tnp;
> +
> +		fb_add_videomode(&fb_vm, &info->modelist);
> +	}
> +
> +	ret = of_get_fb_videomode(dnp, &fb_vm, OF_USE_NATIVE_MODE);
> +	if (ret)
> +		goto put_dnp;

Souldn't this be put_tnp like in the loop above? 

> +	fb_videomode_to_var(&info->var, &fb_vm);
> +	ret = fsl_dcfb_check_var(&info->var, info);

But picking the native mode per default looks nice to be! :)

Best regards,
Alexander
-- 
Dipl.-Inf. Alexander Stein

SYS TEC electronic GmbH
Am Windrad 2
08468 Heinsdorfergrund
Tel.: 03765 38600-1156
Fax: 03765 38600-4100
Email: alexander.stein@systec-electronic.com
Website: www.systec-electronic.com
 
Managing Director: Dipl.-Phys. Siegmar Schmidt
Commercial registry: Amtsgericht Chemnitz, HRB 28082


WARNING: multiple messages have this Message-ID (diff)
From: alexander.stein@systec-electronic.com (Alexander Stein)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 1/4] video: fsl-dcfb: Add dcfb framebuffer driver for LS1021A platform
Date: Thu, 04 Dec 2014 10:21:32 +0100	[thread overview]
Message-ID: <3011460.gQ3SqeWtnL@ws-stein> (raw)
In-Reply-To: <1417598162-40433-2-git-send-email-Li.Xiubo@freescale.com>

On Wednesday 03 December 2014 17:15:59, Xiubo Li wrote:
> +	tnp = of_find_node_by_name(dnp, "display-timings");
> +	if (!tnp) {
> +		dev_err(dcfb->dev, "failed to find \"display-timings\" node\n");
> +		return -ENODEV;
> +		goto put_dnp;
> +	}
> +
> +	for (i = 0; i < of_get_child_count(tnp); i++) {
> +		struct videomode vm;
> +
> +		ret = videomode_from_timings(timings, &vm, i);
> +		if (ret < 0)
> +			goto put_tnp;
> +
> +		ret = fb_videomode_from_videomode(&vm, &fb_vm);
> +		if (ret < 0)
> +			goto put_tnp;
> +
> +		fb_add_videomode(&fb_vm, &info->modelist);
> +	}
> +
> +	ret = of_get_fb_videomode(dnp, &fb_vm, OF_USE_NATIVE_MODE);
> +	if (ret)
> +		goto put_dnp;

Souldn't this be put_tnp like in the loop above? 

> +	fb_videomode_to_var(&info->var, &fb_vm);
> +	ret = fsl_dcfb_check_var(&info->var, info);

But picking the native mode per default looks nice to be! :)

Best regards,
Alexander
-- 
Dipl.-Inf. Alexander Stein

SYS TEC electronic GmbH
Am Windrad 2
08468 Heinsdorfergrund
Tel.: 03765 38600-1156
Fax: 03765 38600-4100
Email: alexander.stein at systec-electronic.com
Website: www.systec-electronic.com
 
Managing Director: Dipl.-Phys. Siegmar Schmidt
Commercial registry: Amtsgericht Chemnitz, HRB 28082

  reply	other threads:[~2014-12-04  9:19 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-03  9:15 [PATCHv2 0/4] LS1021A: Add dcfb framebuffer driver support Xiubo Li
2014-12-03  9:15 ` Xiubo Li
2014-12-03  9:15 ` Xiubo Li
2014-12-03  9:15 ` [PATCHv2 1/4] video: fsl-dcfb: Add dcfb framebuffer driver for LS1021A platform Xiubo Li
2014-12-03  9:15   ` Xiubo Li
2014-12-03  9:15   ` Xiubo Li
2014-12-04  9:21   ` Alexander Stein [this message]
2014-12-04  9:21     ` Alexander Stein
2014-12-04  9:21     ` Alexander Stein
2014-12-03  9:16 ` [PATCHv2 2/4] video: fsl-dcfb: Add devicetree binding support Xiubo Li
2014-12-03  9:16   ` Xiubo Li
2014-12-03  9:16   ` Xiubo Li
2014-12-03  9:16 ` [PATCHv2 3/4] ARM: ls1021a: dtsi: Add dt node support for dcfb Xiubo Li
2014-12-03  9:16   ` Xiubo Li
2014-12-03  9:16   ` Xiubo Li
2014-12-03  9:16 ` [PATCHv2 4/4] ARM: ls1021a: dts: Add and enable dt node " Xiubo Li
2014-12-03  9:16   ` Xiubo Li
2014-12-03  9:16   ` Xiubo Li
2014-12-03  9:51 ` [PATCHv2 0/4] LS1021A: Add dcfb framebuffer driver support Arnd Bergmann
2014-12-03  9:51   ` Arnd Bergmann
2014-12-03  9:51   ` Arnd Bergmann
2014-12-04  1:56   ` Li.Xiubo
2014-12-04  1:56     ` Li.Xiubo
2014-12-04  8:10     ` Tomi Valkeinen
2014-12-04  8:10       ` Tomi Valkeinen
2014-12-04  8:30       ` Li.Xiubo
2014-12-04  8:30         ` Li.Xiubo
2014-12-04  9:09         ` Tomi Valkeinen
2014-12-04  9:09           ` Tomi Valkeinen
2014-12-04  9:54           ` Li.Xiubo
2014-12-04  9:54             ` Li.Xiubo
2014-12-04  9:59             ` Tomi Valkeinen
2014-12-04  9:59               ` Tomi Valkeinen
2014-12-04 10:03               ` Li.Xiubo
2014-12-04 10:03                 ` Li.Xiubo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3011460.gQ3SqeWtnL@ws-stein \
    --to=alexander.stein@systec-electronic.com \
    --cc=Li.Xiubo@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=shawn.guo@linaro.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.