* [PATCH] replay: use CF_NOIRQ for special exception-replaying TB
@ 2022-01-31 11:25 Pavel Dovgalyuk
2022-01-31 20:37 ` Richard Henderson
2022-02-01 23:12 ` Richard Henderson
0 siblings, 2 replies; 3+ messages in thread
From: Pavel Dovgalyuk @ 2022-01-31 11:25 UTC (permalink / raw)
To: qemu-devel; +Cc: alex.bennee, pbonzini, pavel.dovgalyuk
Commit aff0e204cb1f1c036a496c94c15f5dfafcd9b4b4 introduced CF_NOIRQ usage,
but one case was forgotten. Record/replay uses one special TB which is not
really executed, but used to cause a correct exception in replay mode.
This patch adds CF_NOIRQ flag for such block.
Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
---
accel/tcg/cpu-exec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
index 6dcff3618c..5962f158dc 100644
--- a/accel/tcg/cpu-exec.c
+++ b/accel/tcg/cpu-exec.c
@@ -648,7 +648,8 @@ static inline bool cpu_handle_exception(CPUState *cpu, int *ret)
if (replay_has_exception()
&& cpu_neg(cpu)->icount_decr.u16.low + cpu->icount_extra == 0) {
/* Execute just one insn to trigger exception pending in the log */
- cpu->cflags_next_tb = (curr_cflags(cpu) & ~CF_USE_ICOUNT) | 1;
+ cpu->cflags_next_tb = (curr_cflags(cpu) & ~CF_USE_ICOUNT)
+ | CF_NOIRQ | 1;
}
#endif
return false;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] replay: use CF_NOIRQ for special exception-replaying TB
2022-01-31 11:25 [PATCH] replay: use CF_NOIRQ for special exception-replaying TB Pavel Dovgalyuk
@ 2022-01-31 20:37 ` Richard Henderson
2022-02-01 23:12 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2022-01-31 20:37 UTC (permalink / raw)
To: Pavel Dovgalyuk, qemu-devel; +Cc: pbonzini, alex.bennee
On 1/31/22 22:25, Pavel Dovgalyuk wrote:
> Commit aff0e204cb1f1c036a496c94c15f5dfafcd9b4b4 introduced CF_NOIRQ usage,
> but one case was forgotten. Record/replay uses one special TB which is not
> really executed, but used to cause a correct exception in replay mode.
> This patch adds CF_NOIRQ flag for such block.
>
> Signed-off-by: Pavel Dovgalyuk<Pavel.Dovgalyuk@ispras.ru>
> ---
> accel/tcg/cpu-exec.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] replay: use CF_NOIRQ for special exception-replaying TB
2022-01-31 11:25 [PATCH] replay: use CF_NOIRQ for special exception-replaying TB Pavel Dovgalyuk
2022-01-31 20:37 ` Richard Henderson
@ 2022-02-01 23:12 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2022-02-01 23:12 UTC (permalink / raw)
To: Pavel Dovgalyuk, qemu-devel; +Cc: pbonzini, alex.bennee
On 1/31/22 22:25, Pavel Dovgalyuk wrote:
> Commit aff0e204cb1f1c036a496c94c15f5dfafcd9b4b4 introduced CF_NOIRQ usage,
> but one case was forgotten. Record/replay uses one special TB which is not
> really executed, but used to cause a correct exception in replay mode.
> This patch adds CF_NOIRQ flag for such block.
>
> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
> ---
> accel/tcg/cpu-exec.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
> index 6dcff3618c..5962f158dc 100644
> --- a/accel/tcg/cpu-exec.c
> +++ b/accel/tcg/cpu-exec.c
> @@ -648,7 +648,8 @@ static inline bool cpu_handle_exception(CPUState *cpu, int *ret)
> if (replay_has_exception()
> && cpu_neg(cpu)->icount_decr.u16.low + cpu->icount_extra == 0) {
> /* Execute just one insn to trigger exception pending in the log */
> - cpu->cflags_next_tb = (curr_cflags(cpu) & ~CF_USE_ICOUNT) | 1;
> + cpu->cflags_next_tb = (curr_cflags(cpu) & ~CF_USE_ICOUNT)
> + | CF_NOIRQ | 1;
Queued to tcg-next.
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-02 2:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-31 11:25 [PATCH] replay: use CF_NOIRQ for special exception-replaying TB Pavel Dovgalyuk
2022-01-31 20:37 ` Richard Henderson
2022-02-01 23:12 ` Richard Henderson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.