* [PATCH 0/2] Staging: iio: Fix sparse warnings
@ 2015-10-27 23:04 Ksenija Stanojevic
2015-10-27 23:07 ` [PATCH 1/2] Staging: iio: impedance-analyzer: Fix sparse warning Ksenija Stanojevic
2015-10-27 23:08 ` [PATCH 2/2] Staging: iio: adc: " Ksenija Stanojevic
0 siblings, 2 replies; 3+ messages in thread
From: Ksenija Stanojevic @ 2015-10-27 23:04 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Ksenija Stanojevic
Fix sparse warnings regarding cast to restricted __be16 in iio drivers.
Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Ksenija Stanojevic (2):
Staging: iio: impedance-analyzer: Fix sparse warning
Staging: iio: adc: Fix sparse warning
drivers/staging/iio/adc/ad7816.c | 5 +++--
drivers/staging/iio/impedance-analyzer/ad5933.c | 11 ++++++-----
2 files changed, 9 insertions(+), 7 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] Staging: iio: impedance-analyzer: Fix sparse warning
2015-10-27 23:04 [PATCH 0/2] Staging: iio: Fix sparse warnings Ksenija Stanojevic
@ 2015-10-27 23:07 ` Ksenija Stanojevic
2015-10-27 23:08 ` [PATCH 2/2] Staging: iio: adc: " Ksenija Stanojevic
1 sibling, 0 replies; 3+ messages in thread
From: Ksenija Stanojevic @ 2015-10-27 23:07 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Ksenija Stanojevic
Fix following sparse endian warning:
drivers/staging/iio/impedance-analyzer/ad5933.c:671:34: warning: cast to restricted __be16
drivers/staging/iio/impedance-analyzer/ad5933.c:671:34: warning: cast to restricted __be16
drivers/staging/iio/impedance-analyzer/ad5933.c:671:34: warning: cast to restricted __be16
drivers/staging/iio/impedance-analyzer/ad5933.c:671:34: warning: cast to restricted __be16
drivers/staging/iio/impedance-analyzer/ad5933.c:672:34: warning: cast to restricted __be16
drivers/staging/iio/impedance-analyzer/ad5933.c:672:34: warning: cast to restricted __be16
drivers/staging/iio/impedance-analyzer/ad5933.c:672:34: warning: cast to restricted __be16
drivers/staging/iio/impedance-analyzer/ad5933.c:672:34: warning: cast to restricted __be16
drivers/staging/iio/impedance-analyzer/ad5933.c:674:34: warning: cast to restricted __be16
drivers/staging/iio/impedance-analyzer/ad5933.c:674:34: warning: cast to restricted __be16
drivers/staging/iio/impedance-analyzer/ad5933.c:674:34: warning: cast to restricted __be16
drivers/staging/iio/impedance-analyzer/ad5933.c:674:34: warning: cast to restricted __be16
Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
---
drivers/staging/iio/impedance-analyzer/ad5933.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
index c18109c..10c43dda 100644
--- a/drivers/staging/iio/impedance-analyzer/ad5933.c
+++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
@@ -644,7 +644,8 @@ static void ad5933_work(struct work_struct *work)
struct ad5933_state *st = container_of(work,
struct ad5933_state, work.work);
struct iio_dev *indio_dev = i2c_get_clientdata(st->client);
- signed short buf[2];
+ __be16 buf[2];
+ int val[2];
unsigned char status;
mutex_lock(&indio_dev->mlock);
@@ -668,12 +669,12 @@ static void ad5933_work(struct work_struct *work)
scan_count * 2, (u8 *)buf);
if (scan_count == 2) {
- buf[0] = be16_to_cpu(buf[0]);
- buf[1] = be16_to_cpu(buf[1]);
+ val[0] = be16_to_cpu(buf[0]);
+ val[1] = be16_to_cpu(buf[1]);
} else {
- buf[0] = be16_to_cpu(buf[0]);
+ val[0] = be16_to_cpu(buf[0]);
}
- iio_push_to_buffers(indio_dev, buf);
+ iio_push_to_buffers(indio_dev, val);
} else {
/* no data available - try again later */
schedule_delayed_work(&st->work, st->poll_time_jiffies);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] Staging: iio: adc: Fix sparse warning
2015-10-27 23:04 [PATCH 0/2] Staging: iio: Fix sparse warnings Ksenija Stanojevic
2015-10-27 23:07 ` [PATCH 1/2] Staging: iio: impedance-analyzer: Fix sparse warning Ksenija Stanojevic
@ 2015-10-27 23:08 ` Ksenija Stanojevic
1 sibling, 0 replies; 3+ messages in thread
From: Ksenija Stanojevic @ 2015-10-27 23:08 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Ksenija Stanojevic
Fix following sparse endianness problems:
CHECK drivers/staging/iio/adc/ad7816.c
drivers/staging/iio/adc/ad7816.c:91:17: warning: cast to restricted
__be16
drivers/staging/iio/adc/ad7816.c:91:17: warning: cast to restricted
__be16
drivers/staging/iio/adc/ad7816.c:91:17: warning: cast to restricted
__be16
drivers/staging/iio/adc/ad7816.c:91:17: warning: cast to restricted
__be16
Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
---
drivers/staging/iio/adc/ad7816.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7816.c
index b3dec706..ccec57c 100644
--- a/drivers/staging/iio/adc/ad7816.c
+++ b/drivers/staging/iio/adc/ad7816.c
@@ -59,6 +59,7 @@ static int ad7816_spi_read(struct ad7816_chip_info *chip, u16 *data)
{
struct spi_device *spi_dev = chip->spi_dev;
int ret = 0;
+ __be16 buf;
gpio_set_value(chip->rdwr_pin, 1);
gpio_set_value(chip->rdwr_pin, 0);
@@ -82,13 +83,13 @@ static int ad7816_spi_read(struct ad7816_chip_info *chip, u16 *data)
gpio_set_value(chip->rdwr_pin, 0);
gpio_set_value(chip->rdwr_pin, 1);
- ret = spi_read(spi_dev, (u8 *)data, sizeof(*data));
+ ret = spi_read(spi_dev, &buf, sizeof(*data));
if (ret < 0) {
dev_err(&spi_dev->dev, "SPI data read error\n");
return ret;
}
- *data = be16_to_cpu(*data);
+ *data = be16_to_cpu(buf);
return ret;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-27 23:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-27 23:04 [PATCH 0/2] Staging: iio: Fix sparse warnings Ksenija Stanojevic
2015-10-27 23:07 ` [PATCH 1/2] Staging: iio: impedance-analyzer: Fix sparse warning Ksenija Stanojevic
2015-10-27 23:08 ` [PATCH 2/2] Staging: iio: adc: " Ksenija Stanojevic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.