All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Schmitt, Phillip J" <phillip.j.schmitt@intel.com>
To: Alexander Duyck <aduyck@mirantis.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>
Subject: RE: [Intel-wired-lan] [next PATCH 01/11] ixgbe: Return error on failure to allocate mac_table
Date: Thu, 10 Dec 2015 22:51:49 +0000	[thread overview]
Message-ID: <305E19FFAC908240AB6DEBD1E2D8C1E180CF612A@ORSMSX108.amr.corp.intel.com> (raw)
In-Reply-To: <20151103010929.28233.47017.stgit@localhost.localdomain>



> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.org] On
> Behalf Of Alexander Duyck
> Sent: Monday, November 02, 2015 5:09 PM
> To: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH 01/11] ixgbe: Return error on failure to
> allocate mac_table
> 
> Add a check to make certain mac_table was actually allocated and is not NULL.
> If it is NULL return -ENOMEM and allow the probe routine to fail rather then
> causing a NULL pointer dereference further down the line.
> 
> Signed-off-by: Alexander Duyck <aduyck@mirantis.com>

Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>

WARNING: multiple messages have this Message-ID (diff)
From: Schmitt, Phillip J <phillip.j.schmitt@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH 01/11] ixgbe: Return error on failure to allocate mac_table
Date: Thu, 10 Dec 2015 22:51:49 +0000	[thread overview]
Message-ID: <305E19FFAC908240AB6DEBD1E2D8C1E180CF612A@ORSMSX108.amr.corp.intel.com> (raw)
In-Reply-To: <20151103010929.28233.47017.stgit@localhost.localdomain>



> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Alexander Duyck
> Sent: Monday, November 02, 2015 5:09 PM
> To: netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH 01/11] ixgbe: Return error on failure to
> allocate mac_table
> 
> Add a check to make certain mac_table was actually allocated and is not NULL.
> If it is NULL return -ENOMEM and allow the probe routine to fail rather then
> causing a NULL pointer dereference further down the line.
> 
> Signed-off-by: Alexander Duyck <aduyck@mirantis.com>

Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>


  reply	other threads:[~2015-12-10 22:51 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03  1:09 [next PATCH 00/11] ixgbe: Add support for mixed PF/VF virtualization Alexander Duyck
2015-11-03  1:09 ` [Intel-wired-lan] " Alexander Duyck
2015-11-03  1:09 ` [next PATCH 01/11] ixgbe: Return error on failure to allocate mac_table Alexander Duyck
2015-11-03  1:09   ` [Intel-wired-lan] " Alexander Duyck
2015-12-10 22:51   ` Schmitt, Phillip J [this message]
2015-12-10 22:51     ` Schmitt, Phillip J
2015-11-03  1:09 ` [next PATCH 02/11] ixgbe: Fix SR-IOV VLAN pool configuration Alexander Duyck
2015-11-03  1:09   ` [Intel-wired-lan] " Alexander Duyck
2015-12-10 22:52   ` Schmitt, Phillip J
2015-12-10 22:52     ` Schmitt, Phillip J
2015-11-03  1:09 ` [next PATCH 03/11] ixgbe: Simplify definitions for regidx and bit in set_vfta Alexander Duyck
2015-11-03  1:09   ` [Intel-wired-lan] " Alexander Duyck
2015-12-10 22:52   ` Schmitt, Phillip J
2015-12-10 22:52     ` Schmitt, Phillip J
2015-11-03  1:09 ` [next PATCH 04/11] ixgbe: Reduce VT code indent in set_vfta by introducing jump label Alexander Duyck
2015-11-03  1:09   ` [Intel-wired-lan] " Alexander Duyck
2015-12-10 22:52   ` Schmitt, Phillip J
2015-12-10 22:52     ` Schmitt, Phillip J
2015-11-03  1:09 ` [next PATCH 05/11] ixgbe: Simplify configuration of setting VLVF and VLVFB Alexander Duyck
2015-11-03  1:09   ` [Intel-wired-lan] " Alexander Duyck
2015-12-10 22:52   ` Schmitt, Phillip J
2015-12-10 22:52     ` Schmitt, Phillip J
2015-11-03  1:10 ` [next PATCH 06/11] ixgbe: Add support for adding/removing VLAN on PF bypassing the VLVF Alexander Duyck
2015-11-03  1:10   ` [Intel-wired-lan] " Alexander Duyck
2015-12-10 22:52   ` Schmitt, Phillip J
2015-12-10 22:52     ` Schmitt, Phillip J
2015-11-03  1:10 ` [next PATCH 07/11] ixgbe: Reorder search to work from the top down instead of bottom up Alexander Duyck
2015-11-03  1:10   ` [Intel-wired-lan] " Alexander Duyck
2015-12-10 22:53   ` Schmitt, Phillip J
2015-12-10 22:53     ` Schmitt, Phillip J
2015-11-03  1:10 ` [next PATCH 08/11] ixgbe: Add support for VLAN promiscuous with SR-IOV Alexander Duyck
2015-11-03  1:10   ` [Intel-wired-lan] " Alexander Duyck
2015-12-10 22:53   ` Schmitt, Phillip J
2015-12-10 22:53     ` Schmitt, Phillip J
2015-11-03  1:10 ` [next PATCH 09/11] ixgbe: Fix VLAN promisc in relation to SR-IOV Alexander Duyck
2015-11-03  1:10   ` [Intel-wired-lan] " Alexander Duyck
2015-12-10 22:53   ` Schmitt, Phillip J
2015-12-10 22:53     ` Schmitt, Phillip J
2015-11-03  1:10 ` [next PATCH 10/11] ixgbe: Clear stale pool mappings Alexander Duyck
2015-11-03  1:10   ` [Intel-wired-lan] " Alexander Duyck
2015-12-10 22:53   ` Schmitt, Phillip J
2015-12-10 22:53     ` Schmitt, Phillip J
2015-11-03  1:10 ` [next PATCH 11/11] ixgbe: Clean stale VLANs when changing port vlan or resetting Alexander Duyck
2015-11-03  1:10   ` [Intel-wired-lan] " Alexander Duyck
2015-12-10 22:54   ` Schmitt, Phillip J
2015-12-10 22:54     ` Schmitt, Phillip J
2015-11-03 12:38 ` [next PATCH 00/11] ixgbe: Add support for mixed PF/VF virtualization Jeff Kirsher
2015-11-03 12:38   ` [Intel-wired-lan] " Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=305E19FFAC908240AB6DEBD1E2D8C1E180CF612A@ORSMSX108.amr.corp.intel.com \
    --to=phillip.j.schmitt@intel.com \
    --cc=aduyck@mirantis.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.