From: Sven Eckelmann <sven@narfation.org>
To: Sven Eckelmann <sven@narfation.org>, Ansuel Smith <ansuelsmth@gmail.com>
Cc: ath10k@lists.infradead.org,
Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
Zhi Chen <zhichen@codeaurora.org>,
linux-wireless@vger.kernel.org,
Sebastian Gottschall <s.gottschall@newmedia-net.de>,
John Crispin <john@phrozen.org>,
Steve deRosier <derosier@cal-sierra.com>
Subject: Re: [PATCH] ath10k: fix incorrect multicast/broadcast rate setting
Date: Tue, 26 Feb 2019 10:23:30 +0100 [thread overview]
Message-ID: <3062143.B1lnfLpWcE@bentobox> (raw)
In-Reply-To: <2172036.sbaLp6LFFn@bentobox>
[-- Attachment #1: Type: text/plain, Size: 1728 bytes --]
On Monday, 25 February 2019 21:00:38 CET Sven Eckelmann wrote:
[...]
> Tested-by: Sven Eckelmann <sven@narfation.org>
>
> Was tested on QCA988X with 10.2.4-1.0-00041
I just wanted to test it with 802.11s setup on IPQ4019 with 10.4-3.5.3-00057
and QCA9888 with 10.4-3.5.3-00053 (ath10k-firmware) and 10.4-3.6-00140
(linux-firmware 2018-12-16-211de167) for both. But it looks like the firmware
always crashes with and without this patch and 11s.
[ 221.620803] ath10k_pci 0000:01:00.0: wmi command 36967 timeout, restarting hardware
[ 221.744056] ieee80211 phy0: Hardware restart was requested
[ 225.130829] ath10k_pci 0000:01:00.0: failed to receive control response completion, polling..
[ 226.170824] ath10k_pci 0000:01:00.0: Service connect timeout
[ 226.170871] ath10k_pci 0000:01:00.0: failed to connect htt (-110)
[ 226.252248] ath10k_pci 0000:01:00.0: Could not init core: -110
If i count correctly, this is WMI_10_4_GPIO_CONFIG_CMDID. Not really supported
by upstream but it looks like there is an Openwrt private patch (not yet
accepted upstream [1])
package/kernel/mac80211/patches/ath/974-ath10k_add-LED-and-GPIO-controlling-support-for-various-chipsets.patch
which I have now removed to fix this problem for me.
The tests with 10.4-3.6-00140 and 10.4-3.5.3-* worked fine without this patch.
@Kalle are you expecting that he resents the patch again or can you just
append this information to the commit message? At least it looks at the moment
like there will be no new patch in the near future. But the
commit cd93b83ad92 ("ath10k: support for multicast rate control") is breaking
real world setups.
Kind regards,
Sven
[1] https://patchwork.kernel.org/patch/10327075/
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Sven Eckelmann <sven@narfation.org>
To: Sven Eckelmann <sven@narfation.org>, Ansuel Smith <ansuelsmth@gmail.com>
Cc: Steve deRosier <derosier@cal-sierra.com>,
Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
Zhi Chen <zhichen@codeaurora.org>,
John Crispin <john@phrozen.org>,
Sebastian Gottschall <s.gottschall@newmedia-net.de>
Subject: Re: [PATCH] ath10k: fix incorrect multicast/broadcast rate setting
Date: Tue, 26 Feb 2019 10:23:30 +0100 [thread overview]
Message-ID: <3062143.B1lnfLpWcE@bentobox> (raw)
In-Reply-To: <2172036.sbaLp6LFFn@bentobox>
[-- Attachment #1.1: Type: text/plain, Size: 1728 bytes --]
On Monday, 25 February 2019 21:00:38 CET Sven Eckelmann wrote:
[...]
> Tested-by: Sven Eckelmann <sven@narfation.org>
>
> Was tested on QCA988X with 10.2.4-1.0-00041
I just wanted to test it with 802.11s setup on IPQ4019 with 10.4-3.5.3-00057
and QCA9888 with 10.4-3.5.3-00053 (ath10k-firmware) and 10.4-3.6-00140
(linux-firmware 2018-12-16-211de167) for both. But it looks like the firmware
always crashes with and without this patch and 11s.
[ 221.620803] ath10k_pci 0000:01:00.0: wmi command 36967 timeout, restarting hardware
[ 221.744056] ieee80211 phy0: Hardware restart was requested
[ 225.130829] ath10k_pci 0000:01:00.0: failed to receive control response completion, polling..
[ 226.170824] ath10k_pci 0000:01:00.0: Service connect timeout
[ 226.170871] ath10k_pci 0000:01:00.0: failed to connect htt (-110)
[ 226.252248] ath10k_pci 0000:01:00.0: Could not init core: -110
If i count correctly, this is WMI_10_4_GPIO_CONFIG_CMDID. Not really supported
by upstream but it looks like there is an Openwrt private patch (not yet
accepted upstream [1])
package/kernel/mac80211/patches/ath/974-ath10k_add-LED-and-GPIO-controlling-support-for-various-chipsets.patch
which I have now removed to fix this problem for me.
The tests with 10.4-3.6-00140 and 10.4-3.5.3-* worked fine without this patch.
@Kalle are you expecting that he resents the patch again or can you just
append this information to the commit message? At least it looks at the moment
like there will be no new patch in the near future. But the
commit cd93b83ad92 ("ath10k: support for multicast rate control") is breaking
real world setups.
Kind regards,
Sven
[1] https://patchwork.kernel.org/patch/10327075/
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 146 bytes --]
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2019-02-26 9:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 4:56 [PATCH] ath10k: fix incorrect multicast/broadcast rate setting Pradeep Kumar Chitrapu
2018-12-11 4:56 ` Pradeep Kumar Chitrapu
2018-12-11 19:22 ` Peter Oh
2018-12-11 19:22 ` Peter Oh
2019-02-07 14:42 ` Kalle Valo
2019-02-07 14:42 ` Kalle Valo
2019-02-25 20:00 ` Sven Eckelmann
2019-02-25 20:00 ` Sven Eckelmann
2019-02-26 9:23 ` Sven Eckelmann [this message]
2019-02-26 9:23 ` Sven Eckelmann
2019-04-03 12:28 ` Kalle Valo
2019-04-03 12:28 ` Kalle Valo
2019-04-03 13:04 ` Sven Eckelmann
2019-04-03 13:04 ` Sven Eckelmann
2019-04-29 14:43 ` Kalle Valo
2019-04-29 14:43 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3062143.B1lnfLpWcE@bentobox \
--to=sven@narfation.org \
--cc=ansuelsmth@gmail.com \
--cc=ath10k@lists.infradead.org \
--cc=derosier@cal-sierra.com \
--cc=john@phrozen.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pradeepc@codeaurora.org \
--cc=s.gottschall@newmedia-net.de \
--cc=zhichen@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.