* Re: [PATCH] cpufreq: conservative: Allow down_threshold to take values from 1 to 10
[not found] <1497169719-13613-1-git-send-email-twilczynski@naver.com>
@ 2017-06-12 3:40 ` Viresh Kumar
2017-06-12 12:23 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2017-06-12 3:40 UTC (permalink / raw)
To: Tomasz Wilczyński; +Cc: rjw, linux-pm, linux-kernel
On 11-06-17, 17:28, Tomasz Wilczyński wrote:
> Commit 27ed3cd2ebf4cd78b198be9758c538cdede36d8a ("cpufreq: conservative:
> Fix the logic in frequency decrease checking") removed the 10 point
> substraction when comparing the load against down_threshold but did not
> remove the related limit for the down_threshold value. As a result,
> down_threshold lower than 11 is not allowed even though values from
> 1 to 10 do work correctly too. The comment ("cannot be lower than 11
> otherwise freq will not fall") is also not true after removing the
> substraction.
>
> For this reason, allow down_threshold to take any value from 1 to 99
> and fix the related comment.
>
> Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
Please add Fixes tag and relevant kernel release for stable tag.
> ---
> drivers/cpufreq/cpufreq_conservative.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq_conservative.c b/drivers/cpufreq/cpufreq_conservative.c
> index 992f7c2..88220ff 100644
> --- a/drivers/cpufreq/cpufreq_conservative.c
> +++ b/drivers/cpufreq/cpufreq_conservative.c
> @@ -185,8 +185,8 @@ static ssize_t store_down_threshold(struct gov_attr_set *attr_set,
> int ret;
> ret = sscanf(buf, "%u", &input);
>
> - /* cannot be lower than 11 otherwise freq will not fall */
> - if (ret != 1 || input < 11 || input > 100 ||
> + /* cannot be lower than 1 otherwise freq will not fall */
> + if (ret != 1 || input < 1 || input > 100 ||
> input >= dbs_data->up_threshold)
> return -EINVAL;
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: conservative: Allow down_threshold to take values from 1 to 10
2017-06-12 3:40 ` [PATCH] cpufreq: conservative: Allow down_threshold to take values from 1 to 10 Viresh Kumar
@ 2017-06-12 12:23 ` Rafael J. Wysocki
[not found] ` <7fa1e0c6-8d9c-c346-f5e2-87f024ebc1bb@naver.com>
0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2017-06-12 12:23 UTC (permalink / raw)
To: Viresh Kumar, Tomasz Wilczyński; +Cc: linux-pm, linux-kernel
On Monday, June 12, 2017 09:10:35 AM Viresh Kumar wrote:
> On 11-06-17, 17:28, Tomasz Wilczyński wrote:
> > Commit 27ed3cd2ebf4cd78b198be9758c538cdede36d8a ("cpufreq: conservative:
> > Fix the logic in frequency decrease checking") removed the 10 point
> > substraction when comparing the load against down_threshold but did not
> > remove the related limit for the down_threshold value. As a result,
> > down_threshold lower than 11 is not allowed even though values from
> > 1 to 10 do work correctly too. The comment ("cannot be lower than 11
> > otherwise freq will not fall") is also not true after removing the
> > substraction.
> >
> > For this reason, allow down_threshold to take any value from 1 to 99
> > and fix the related comment.
> >
> > Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
>
> Please add Fixes tag and relevant kernel release for stable tag.
Actually, the Fixes: tag would be sufficient and then adding it would be
appreciated.
No need to resend the patch, though.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: conservative: Allow down_threshold to take values from 1 to 10
[not found] ` <7fa1e0c6-8d9c-c346-f5e2-87f024ebc1bb@naver.com>
@ 2017-06-13 6:02 ` Viresh Kumar
0 siblings, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2017-06-13 6:02 UTC (permalink / raw)
To: Tomasz Wilczynski; +Cc: Rafael J. Wysocki, linux-pm, linux-kernel
On 13-06-17, 14:58, Tomasz Wilczynski wrote:
> This is my first patch so please bare with me...
No worries, we were just telling you about what's the right way..
> I am just a little
> confused. Does this mean that it is all right to leave the patch as it is,
> or should I still add the Fixes: tag and resubmit it?
Rafael has already applied the patch with all the required tags (look
in the PM tree):
commit b8e11f7d2791bd9320be1c6e772a60b2aa093e45
Author: Tomasz Wilczyński <twilczynski@naver.com>
Date: Sun Jun 11 17:28:39 2017 +0900
cpufreq: conservative: Allow down_threshold to take values from 1 to 10
Commit 27ed3cd2ebf4 (cpufreq: conservative: Fix the logic in frequency
decrease checking) removed the 10 point substraction when comparing the
load against down_threshold but did not remove the related limit for the
down_threshold value. As a result, down_threshold lower than 11 is not
allowed even though values from 1 to 10 do work correctly too. The
comment ("cannot be lower than 11 otherwise freq will not fall") also
does not apply after removing the substraction.
For this reason, allow down_threshold to take any value from 1 to 99
and fix the related comment.
Fixes: 27ed3cd2ebf4 (cpufreq: conservative: Fix the logic in frequency decrease checking)
Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Cc: 3.10+ <stable@vger.kernel.org> # 3.10+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/cpufreq/cpufreq_conservative.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-13 6:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1497169719-13613-1-git-send-email-twilczynski@naver.com>
2017-06-12 3:40 ` [PATCH] cpufreq: conservative: Allow down_threshold to take values from 1 to 10 Viresh Kumar
2017-06-12 12:23 ` Rafael J. Wysocki
[not found] ` <7fa1e0c6-8d9c-c346-f5e2-87f024ebc1bb@naver.com>
2017-06-13 6:02 ` Viresh Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.