All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] arm: configs: helios4: Change U-Boot offset on SPI Flash
@ 2018-12-19  4:08 Aditya Prayoga
  2018-12-21  7:48 ` Stefan Roese
  2018-12-21 15:29 ` Stefan Roese
  0 siblings, 2 replies; 3+ messages in thread
From: Aditya Prayoga @ 2018-12-19  4:08 UTC (permalink / raw)
  To: u-boot

SPI flash support on Helios4 [1] has been merge to u-boot/master on
commit 8cb8c0c6a83bef ("Merge git://git.denx.de/u-boot-marvell")

However, the SPI image build failed after the merge with following
message:

COPY    spl/u-boot-spl.bin
MKIMAGE u-boot-spl.kwb
Error: Image header (incl. SPL image) too big!
header=0x20816 CONFIG_SYS_U_BOOT_OFFS=0x20000!
Increase CONFIG_SYS_U_BOOT_OFFS!
Error: Image header (incl. SPL image) too big!
header=0x20816 CONFIG_SYS_U_BOOT_OFFS=0x20000!
Increase CONFIG_SYS_U_BOOT_OFFS!
Could not create image
Makefile:1162: recipe for target 'u-boot-spl.kwb' failed
make: *** [u-boot-spl.kwb] Error 1

Let's increase the u-boot offset to 0x30000 to accommodate SPL changes
and leave some margin for future changes.

[1] https://patchwork.ozlabs.org/patch/1007762/

Signed-off-by: Aditya Prayoga <aditya@kobol.io>
---
Notes

* After doing git bisect, I found out if the SPI flash support patch
applied after
commit 6f57c34473d37b ("serial: ns16550: fix debug uart putc called
before init")
SPI image build would failed because of the SPL+header size

* To build SPI image:
make mrproper
make helios4_defconfig

sed -i "s/CONFIG_MVEBU_SPL_BOOT_DEVICE_MMC=y/"\
"# CONFIG_MVEBU_SPL_BOOT_DEVICE_MMC is not set/g" .config

sed -i "s/# CONFIG_MVEBU_SPL_BOOT_DEVICE_SPI is not set/"\
"CONFIG_MVEBU_SPL_BOOT_DEVICE_SPI=y/g" .config

sed -i "s/CONFIG_ENV_IS_IN_MMC=y/"\
"# CONFIG_ENV_IS_IN_MMC is not set/g" .config

sed -i "s/# CONFIG_ENV_IS_IN_SPI_FLASH is not set/"\
"CONFIG_ENV_IS_IN_SPI_FLASH=y/g" .config

make
---
 include/configs/helios4.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/configs/helios4.h b/include/configs/helios4.h
index 3157225..4e98f19 100644
--- a/include/configs/helios4.h
+++ b/include/configs/helios4.h
@@ -118,7 +118,7 @@
 #define CONFIG_SPL_SPI_FLASH_SUPPORT
 #define CONFIG_SPL_SPI_LOAD
 #define CONFIG_SPL_SPI_SUPPORT
-#define CONFIG_SYS_SPI_U_BOOT_OFFS	0x20000
+#define CONFIG_SYS_SPI_U_BOOT_OFFS	0x30000
 #define CONFIG_SYS_U_BOOT_OFFS		CONFIG_SYS_SPI_U_BOOT_OFFS
 #endif
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] arm: configs: helios4: Change U-Boot offset on SPI Flash
  2018-12-19  4:08 [U-Boot] [PATCH] arm: configs: helios4: Change U-Boot offset on SPI Flash Aditya Prayoga
@ 2018-12-21  7:48 ` Stefan Roese
  2018-12-21 15:29 ` Stefan Roese
  1 sibling, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2018-12-21  7:48 UTC (permalink / raw)
  To: u-boot

On 19.12.18 05:08, Aditya Prayoga wrote:
> SPI flash support on Helios4 [1] has been merge to u-boot/master on
> commit 8cb8c0c6a83bef ("Merge git://git.denx.de/u-boot-marvell")
> 
> However, the SPI image build failed after the merge with following
> message:
> 
> COPY    spl/u-boot-spl.bin
> MKIMAGE u-boot-spl.kwb
> Error: Image header (incl. SPL image) too big!
> header=0x20816 CONFIG_SYS_U_BOOT_OFFS=0x20000!
> Increase CONFIG_SYS_U_BOOT_OFFS!
> Error: Image header (incl. SPL image) too big!
> header=0x20816 CONFIG_SYS_U_BOOT_OFFS=0x20000!
> Increase CONFIG_SYS_U_BOOT_OFFS!
> Could not create image
> Makefile:1162: recipe for target 'u-boot-spl.kwb' failed
> make: *** [u-boot-spl.kwb] Error 1
> 
> Let's increase the u-boot offset to 0x30000 to accommodate SPL changes
> and leave some margin for future changes.
> 
> [1] https://patchwork.ozlabs.org/patch/1007762/
> 
> Signed-off-by: Aditya Prayoga <aditya@kobol.io>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] arm: configs: helios4: Change U-Boot offset on SPI Flash
  2018-12-19  4:08 [U-Boot] [PATCH] arm: configs: helios4: Change U-Boot offset on SPI Flash Aditya Prayoga
  2018-12-21  7:48 ` Stefan Roese
@ 2018-12-21 15:29 ` Stefan Roese
  1 sibling, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2018-12-21 15:29 UTC (permalink / raw)
  To: u-boot

On 19.12.18 05:08, Aditya Prayoga wrote:
> SPI flash support on Helios4 [1] has been merge to u-boot/master on
> commit 8cb8c0c6a83bef ("Merge git://git.denx.de/u-boot-marvell")
> 
> However, the SPI image build failed after the merge with following
> message:
> 
> COPY    spl/u-boot-spl.bin
> MKIMAGE u-boot-spl.kwb
> Error: Image header (incl. SPL image) too big!
> header=0x20816 CONFIG_SYS_U_BOOT_OFFS=0x20000!
> Increase CONFIG_SYS_U_BOOT_OFFS!
> Error: Image header (incl. SPL image) too big!
> header=0x20816 CONFIG_SYS_U_BOOT_OFFS=0x20000!
> Increase CONFIG_SYS_U_BOOT_OFFS!
> Could not create image
> Makefile:1162: recipe for target 'u-boot-spl.kwb' failed
> make: *** [u-boot-spl.kwb] Error 1
> 
> Let's increase the u-boot offset to 0x30000 to accommodate SPL changes
> and leave some margin for future changes.
> 
> [1] https://patchwork.ozlabs.org/patch/1007762/
> 
> Signed-off-by: Aditya Prayoga <aditya@kobol.io>

Applied to u-boot-marvell/master.

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-21 15:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-19  4:08 [U-Boot] [PATCH] arm: configs: helios4: Change U-Boot offset on SPI Flash Aditya Prayoga
2018-12-21  7:48 ` Stefan Roese
2018-12-21 15:29 ` Stefan Roese

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.