* [Intel-wired-lan] [PATCH] igbvf: convert msleep to mdelay in atomic context
@ 2017-07-20 16:15 Greg Edwards
2017-07-29 0:01 ` Brown, Aaron F
0 siblings, 1 reply; 2+ messages in thread
From: Greg Edwards @ 2017-07-20 16:15 UTC (permalink / raw)
To: intel-wired-lan
This fixes a "scheduling while atomic" splat seen with
CONFIG_DEBUG_ATOMIC_SLEEP enabled.
Signed-off-by: Greg Edwards <gedwards@ddn.com>
---
drivers/net/ethernet/intel/igbvf/vf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igbvf/vf.c b/drivers/net/ethernet/intel/igbvf/vf.c
index 1d3aa9adcaa8..9577ccf4b26a 100644
--- a/drivers/net/ethernet/intel/igbvf/vf.c
+++ b/drivers/net/ethernet/intel/igbvf/vf.c
@@ -149,7 +149,7 @@ static s32 e1000_reset_hw_vf(struct e1000_hw *hw)
msgbuf[0] = E1000_VF_RESET;
mbx->ops.write_posted(hw, msgbuf, 1);
- msleep(10);
+ mdelay(10);
/* set our "perm_addr" based on info provided by PF */
ret_val = mbx->ops.read_posted(hw, msgbuf, 3);
--
2.13.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Intel-wired-lan] [PATCH] igbvf: convert msleep to mdelay in atomic context
2017-07-20 16:15 [Intel-wired-lan] [PATCH] igbvf: convert msleep to mdelay in atomic context Greg Edwards
@ 2017-07-29 0:01 ` Brown, Aaron F
0 siblings, 0 replies; 2+ messages in thread
From: Brown, Aaron F @ 2017-07-29 0:01 UTC (permalink / raw)
To: intel-wired-lan
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf
> Of Greg Edwards
> Sent: Thursday, July 20, 2017 9:15 AM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Greg Edwards <gedwards@ddn.com>
> Subject: [Intel-wired-lan] [PATCH] igbvf: convert msleep to mdelay in atomic
> context
>
> This fixes a "scheduling while atomic" splat seen with
> CONFIG_DEBUG_ATOMIC_SLEEP enabled.
>
> Signed-off-by: Greg Edwards <gedwards@ddn.com>
> ---
> drivers/net/ethernet/intel/igbvf/vf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
This could be considered a 3 of 3 for the 2 mbox related igbvf patches I just replied to as those introduce a call trace on driver load which this resolves.
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-29 0:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-20 16:15 [Intel-wired-lan] [PATCH] igbvf: convert msleep to mdelay in atomic context Greg Edwards
2017-07-29 0:01 ` Brown, Aaron F
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.