All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Brown, Aaron F" <aaron.f.brown@intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>
Cc: "intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON
Date: Tue, 13 Feb 2018 20:54:10 +0000	[thread overview]
Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B8C7E574C@ORSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20180206194759.26991-1-christophe.jaillet@wanadoo.fr>

> From: netdev-owner@vger.kernel.org [mailto:netdev-
> owner@vger.kernel.org] On Behalf Of Christophe JAILLET
> Sent: Tuesday, February 6, 2018 11:48 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; kernel-janitors@vger.kernel.org; Christophe
> JAILLET <christophe.jaillet@wanadoo.fr>
> Subject: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON
> 
> 'HWTSTAMP_TX_ON' should be handled as a value, not as a bit mask.
> The modified code should behave the same, because HWTSTAMP_TX_ON is
> 1
> and no other possible values of 'tx_type' would match the test.
> However, this is more future-proof, should other values be allowed one day.
> 
> See 'struct hwtstamp_config' in 'include/uapi/linux/net_tstamp.h'
> 
> This fixes a warning reported by smatch:
>    igb_xmit_frame_ring() warn: bit shifter 'HWTSTAMP_TX_ON' used for
> logical '&'
> 
> Fixes: 26bd4e2db06be ("igb: protect TX timestamping from API misuse")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/net/ethernet/intel/igb/igb_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Tested-by: Aaron Brown <aaron.f.brown@intel.com>

WARNING: multiple messages have this Message-ID (diff)
From: "Brown, Aaron F" <aaron.f.brown@intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>
Cc: "intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON
Date: Tue, 13 Feb 2018 20:54:10 +0000	[thread overview]
Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B8C7E574C@ORSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20180206194759.26991-1-christophe.jaillet@wanadoo.fr>

PiBGcm9tOiBuZXRkZXYtb3duZXJAdmdlci5rZXJuZWwub3JnIFttYWlsdG86bmV0ZGV2LQ0KPiBv
d25lckB2Z2VyLmtlcm5lbC5vcmddIE9uIEJlaGFsZiBPZiBDaHJpc3RvcGhlIEpBSUxMRVQNCj4g
U2VudDogVHVlc2RheSwgRmVicnVhcnkgNiwgMjAxOCAxMTo0OCBBTQ0KPiBUbzogS2lyc2hlciwg
SmVmZnJleSBUIDxqZWZmcmV5LnQua2lyc2hlckBpbnRlbC5jb20+DQo+IENjOiBpbnRlbC13aXJl
ZC1sYW5AbGlzdHMub3N1b3NsLm9yZzsgbmV0ZGV2QHZnZXIua2VybmVsLm9yZzsgbGludXgtDQo+
IGtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IGtlcm5lbC1qYW5pdG9yc0B2Z2VyLmtlcm5lbC5vcmc7
IENocmlzdG9waGUNCj4gSkFJTExFVCA8Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI+DQo+
IFN1YmplY3Q6IFtQQVRDSF0gaWdiOiBGaXggYSB0ZXN0IHdpdGggSFdUU1RBTVBfVFhfT04NCj4g
DQo+ICdIV1RTVEFNUF9UWF9PTicgc2hvdWxkIGJlIGhhbmRsZWQgYXMgYSB2YWx1ZSwgbm90IGFz
IGEgYml0IG1hc2suDQo+IFRoZSBtb2RpZmllZCBjb2RlIHNob3VsZCBiZWhhdmUgdGhlIHNhbWUs
IGJlY2F1c2UgSFdUU1RBTVBfVFhfT04gaXMNCj4gMQ0KPiBhbmQgbm8gb3RoZXIgcG9zc2libGUg
dmFsdWVzIG9mICd0eF90eXBlJyB3b3VsZCBtYXRjaCB0aGUgdGVzdC4NCj4gSG93ZXZlciwgdGhp
cyBpcyBtb3JlIGZ1dHVyZS1wcm9vZiwgc2hvdWxkIG90aGVyIHZhbHVlcyBiZSBhbGxvd2VkIG9u
ZSBkYXkuDQo+IA0KPiBTZWUgJ3N0cnVjdCBod3RzdGFtcF9jb25maWcnIGluICdpbmNsdWRlL3Vh
cGkvbGludXgvbmV0X3RzdGFtcC5oJw0KPiANCj4gVGhpcyBmaXhlcyBhIHdhcm5pbmcgcmVwb3J0
ZWQgYnkgc21hdGNoOg0KPiAgICBpZ2JfeG1pdF9mcmFtZV9yaW5nKCkgd2FybjogYml0IHNoaWZ0
ZXIgJ0hXVFNUQU1QX1RYX09OJyB1c2VkIGZvcg0KPiBsb2dpY2FsICcmJw0KPiANCj4gRml4ZXM6
IDI2YmQ0ZTJkYjA2YmUgKCJpZ2I6IHByb3RlY3QgVFggdGltZXN0YW1waW5nIGZyb20gQVBJIG1p
c3VzZSIpDQo+IFNpZ25lZC1vZmYtYnk6IENocmlzdG9waGUgSkFJTExFVCA8Y2hyaXN0b3BoZS5q
YWlsbGV0QHdhbmFkb28uZnI+DQo+IC0tLQ0KPiAgZHJpdmVycy9uZXQvZXRoZXJuZXQvaW50ZWwv
aWdiL2lnYl9tYWluLmMgfCAyICstDQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyks
IDEgZGVsZXRpb24oLSkNCj4gDQoNClRlc3RlZC1ieTogQWFyb24gQnJvd24gPGFhcm9uLmYuYnJv
d25AaW50ZWwuY29tPg0K

WARNING: multiple messages have this Message-ID (diff)
From: Brown, Aaron F <aaron.f.brown@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] igb: Fix a test with HWTSTAMP_TX_ON
Date: Tue, 13 Feb 2018 20:54:10 +0000	[thread overview]
Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B8C7E574C@ORSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20180206194759.26991-1-christophe.jaillet@wanadoo.fr>

> From: netdev-owner at vger.kernel.org [mailto:netdev-
> owner at vger.kernel.org] On Behalf Of Christophe JAILLET
> Sent: Tuesday, February 6, 2018 11:48 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
> Cc: intel-wired-lan at lists.osuosl.org; netdev at vger.kernel.org; linux-
> kernel at vger.kernel.org; kernel-janitors at vger.kernel.org; Christophe
> JAILLET <christophe.jaillet@wanadoo.fr>
> Subject: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON
> 
> 'HWTSTAMP_TX_ON' should be handled as a value, not as a bit mask.
> The modified code should behave the same, because HWTSTAMP_TX_ON is
> 1
> and no other possible values of 'tx_type' would match the test.
> However, this is more future-proof, should other values be allowed one day.
> 
> See 'struct hwtstamp_config' in 'include/uapi/linux/net_tstamp.h'
> 
> This fixes a warning reported by smatch:
>    igb_xmit_frame_ring() warn: bit shifter 'HWTSTAMP_TX_ON' used for
> logical '&'
> 
> Fixes: 26bd4e2db06be ("igb: protect TX timestamping from API misuse")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/net/ethernet/intel/igb/igb_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Tested-by: Aaron Brown <aaron.f.brown@intel.com>

  parent reply	other threads:[~2018-02-13 20:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06 19:47 [PATCH] igb: Fix a test with HWTSTAMP_TX_ON Christophe JAILLET
2018-02-06 19:47 ` [Intel-wired-lan] " Christophe JAILLET
2018-02-06 19:47 ` Christophe JAILLET
2018-02-06 21:06 ` Richard Cochran
2018-02-06 21:06   ` [Intel-wired-lan] " Richard Cochran
2018-02-06 21:06   ` Richard Cochran
2018-02-13 20:54 ` Brown, Aaron F [this message]
2018-02-13 20:54   ` [Intel-wired-lan] " Brown, Aaron F
2018-02-13 20:54   ` Brown, Aaron F

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=309B89C4C689E141A5FF6A0C5FB2118B8C7E574C@ORSMSX103.amr.corp.intel.com \
    --to=aaron.f.brown@intel.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.