* [Buildroot] [PATCH 1/1] package/efl: Fix build with mesa
@ 2019-03-05 0:19 Vadim Kochan
2019-03-06 10:12 ` Romain Naour
0 siblings, 1 reply; 6+ messages in thread
From: Vadim Kochan @ 2019-03-05 0:19 UTC (permalink / raw)
To: buildroot
efl does not compile with mesa without OpenGL ES because it checks for
GL_ES_VERSION_2_0 and declares own GLintptr and GLsizeiptr types if such
version is not defined, but mesa declares them too for OpenGL version
1.5, so fix it by add check also for OpenGL 1.5 where these types are
defined.
Use patch from:
https://git.enlightenment.org/core/efl.git/commit/?id=0d2b624f1e24240a1c4e651aa1cfe9a8dd10a573
Fixes:
http://autobuild.buildroot.net/results/62ca120f1e54e8c3ae445f98b2624b526569f007
Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
---
...e-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch | 34 ++++++++++++++++++++++
1 file changed, 34 insertions(+)
create mode 100644 package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch
diff --git a/package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch b/package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch
new file mode 100644
index 0000000000..453b9f47b2
--- /dev/null
+++ b/package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch
@@ -0,0 +1,34 @@
+From d045dd99acdd47be238642d4f9384dccacde2b42 Mon Sep 17 00:00:00 2001
+From: "Carsten Haitzler (Rasterman)" <raster@rasterman.com>
+Date: Sat, 15 Dec 2018 16:19:01 +0000
+Subject: [PATCH] evas gl - make GLintptr etc. also ndefed for GL_VERSION_1_5
+ fix typedef
+
+It seems that GL_VERSION_1_5 define == these provided by gl already. At
+least reading the mesa headers I do, so this should fix T7502
+
+ at fix
+---
+ src/lib/evas/Evas_GL.h | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/src/lib/evas/Evas_GL.h b/src/lib/evas/Evas_GL.h
+index fa3e6f4..5524d82 100644
+--- a/src/lib/evas/Evas_GL.h
++++ b/src/lib/evas/Evas_GL.h
+@@ -4272,9 +4272,11 @@ typedef signed int GLfixed; // Changed khronos_int32_t
+
+ #ifndef GL_ES_VERSION_2_0
+ /* GL types for handling large vertex buffer objects */
+-#include <stddef.h>
++# ifndef GL_VERSION_1_5
++# include <stddef.h>
+ typedef ptrdiff_t GLintptr; // Changed khronos_intptr_t
+ typedef ptrdiff_t GLsizeiptr; // Changed khronos_ssize_t
++# endif
+ #endif
+
+ /* Some definitions from GLES 3.0.
+--
+2.14.1
+
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/efl: Fix build with mesa
2019-03-05 0:19 [Buildroot] [PATCH 1/1] package/efl: Fix build with mesa Vadim Kochan
@ 2019-03-06 10:12 ` Romain Naour
2019-03-06 10:19 ` Vadym Kochan
0 siblings, 1 reply; 6+ messages in thread
From: Romain Naour @ 2019-03-06 10:12 UTC (permalink / raw)
To: buildroot
Hi Vadim,
Le 05/03/2019 ? 01:19, Vadim Kochan a ?crit?:
> efl does not compile with mesa without OpenGL ES because it checks for
> GL_ES_VERSION_2_0 and declares own GLintptr and GLsizeiptr types if such
> version is not defined, but mesa declares them too for OpenGL version
> 1.5, so fix it by add check also for OpenGL 1.5 where these types are
> defined.
>
> Use patch from:
> https://git.enlightenment.org/core/efl.git/commit/?id=0d2b624f1e24240a1c4e651aa1cfe9a8dd10a573
>
> Fixes:
> http://autobuild.buildroot.net/results/62ca120f1e54e8c3ae445f98b2624b526569f007
>
> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> ---
> ...e-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch | 34 ++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
> create mode 100644 package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch
>
> diff --git a/package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch b/package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch
> new file mode 100644
> index 0000000000..453b9f47b2
> --- /dev/null
> +++ b/package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch
> @@ -0,0 +1,34 @@
> +From d045dd99acdd47be238642d4f9384dccacde2b42 Mon Sep 17 00:00:00 2001
> +From: "Carsten Haitzler (Rasterman)" <raster@rasterman.com>
> +Date: Sat, 15 Dec 2018 16:19:01 +0000
> +Subject: [PATCH] evas gl - make GLintptr etc. also ndefed for GL_VERSION_1_5
> + fix typedef
> +
> +It seems that GL_VERSION_1_5 define == these provided by gl already. At
> +least reading the mesa headers I do, so this should fix T7502
> +
> + at fix
Your SoB line is missing here.
Also it would be great to add the upstream status of this patch.
Otherwise, the patch is ok.
Best regards,
Romain
> +---
> + src/lib/evas/Evas_GL.h | 4 +++-
> + 1 file changed, 3 insertions(+), 1 deletion(-)
> +
> +diff --git a/src/lib/evas/Evas_GL.h b/src/lib/evas/Evas_GL.h
> +index fa3e6f4..5524d82 100644
> +--- a/src/lib/evas/Evas_GL.h
> ++++ b/src/lib/evas/Evas_GL.h
> +@@ -4272,9 +4272,11 @@ typedef signed int GLfixed; // Changed khronos_int32_t
> +
> + #ifndef GL_ES_VERSION_2_0
> + /* GL types for handling large vertex buffer objects */
> +-#include <stddef.h>
> ++# ifndef GL_VERSION_1_5
> ++# include <stddef.h>
> + typedef ptrdiff_t GLintptr; // Changed khronos_intptr_t
> + typedef ptrdiff_t GLsizeiptr; // Changed khronos_ssize_t
> ++# endif
> + #endif
> +
> + /* Some definitions from GLES 3.0.
> +--
> +2.14.1
> +
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/efl: Fix build with mesa
2019-03-06 10:12 ` Romain Naour
@ 2019-03-06 10:19 ` Vadym Kochan
2019-03-06 10:26 ` Romain Naour
0 siblings, 1 reply; 6+ messages in thread
From: Vadym Kochan @ 2019-03-06 10:19 UTC (permalink / raw)
To: buildroot
Hi Romain,
On Wed, Mar 06, 2019 at 11:12:40AM +0100, Romain Naour wrote:
> Hi Vadim,
>
> Le 05/03/2019 ? 01:19, Vadim Kochan a ?crit?:
> > efl does not compile with mesa without OpenGL ES because it checks for
> > GL_ES_VERSION_2_0 and declares own GLintptr and GLsizeiptr types if such
> > version is not defined, but mesa declares them too for OpenGL version
> > 1.5, so fix it by add check also for OpenGL 1.5 where these types are
> > defined.
> >
> > Use patch from:
> > https://git.enlightenment.org/core/efl.git/commit/?id=0d2b624f1e24240a1c4e651aa1cfe9a8dd10a573
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/62ca120f1e54e8c3ae445f98b2624b526569f007
> >
> > Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> > ---
> > ...e-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch | 34 ++++++++++++++++++++++
> > 1 file changed, 34 insertions(+)
> > create mode 100644 package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch
> >
> > diff --git a/package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch b/package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch
> > new file mode 100644
> > index 0000000000..453b9f47b2
> > --- /dev/null
> > +++ b/package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch
> > @@ -0,0 +1,34 @@
> > +From d045dd99acdd47be238642d4f9384dccacde2b42 Mon Sep 17 00:00:00 2001
> > +From: "Carsten Haitzler (Rasterman)" <raster@rasterman.com>
> > +Date: Sat, 15 Dec 2018 16:19:01 +0000
> > +Subject: [PATCH] evas gl - make GLintptr etc. also ndefed for GL_VERSION_1_5
> > + fix typedef
> > +
> > +It seems that GL_VERSION_1_5 define == these provided by gl already. At
> > +least reading the mesa headers I do, so this should fix T7502
> > +
> > + at fix
>
> Your SoB line is missing here.
> Also it would be great to add the upstream status of this patch.
>
> Otherwise, the patch is ok.
>
> Best regards,
> Romain
>
I directly applied the original commit (as patch) from URI which you provided, and
there was no SoB, so should I put there myself (I was not sure with this
because I did not touched the original patch) ?
Regards,
Vadim Kochan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/efl: Fix build with mesa
2019-03-06 10:19 ` Vadym Kochan
@ 2019-03-06 10:26 ` Romain Naour
0 siblings, 0 replies; 6+ messages in thread
From: Romain Naour @ 2019-03-06 10:26 UTC (permalink / raw)
To: buildroot
Hi Vadym,
Le 06/03/2019 ? 11:19, Vadym Kochan a ?crit?:
> Hi Romain,
>
> On Wed, Mar 06, 2019 at 11:12:40AM +0100, Romain Naour wrote:
>> Hi Vadim,
>>
>> Le 05/03/2019 ? 01:19, Vadim Kochan a ?crit?:
>>> efl does not compile with mesa without OpenGL ES because it checks for
>>> GL_ES_VERSION_2_0 and declares own GLintptr and GLsizeiptr types if such
>>> version is not defined, but mesa declares them too for OpenGL version
>>> 1.5, so fix it by add check also for OpenGL 1.5 where these types are
>>> defined.
>>>
>>> Use patch from:
>>> https://git.enlightenment.org/core/efl.git/commit/?id=0d2b624f1e24240a1c4e651aa1cfe9a8dd10a573
>>>
>>> Fixes:
>>> http://autobuild.buildroot.net/results/62ca120f1e54e8c3ae445f98b2624b526569f007
>>>
>>> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
>>> ---
>>> ...e-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch | 34 ++++++++++++++++++++++
>>> 1 file changed, 34 insertions(+)
>>> create mode 100644 package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch
>>>
>>> diff --git a/package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch b/package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch
>>> new file mode 100644
>>> index 0000000000..453b9f47b2
>>> --- /dev/null
>>> +++ b/package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch
>>> @@ -0,0 +1,34 @@
>>> +From d045dd99acdd47be238642d4f9384dccacde2b42 Mon Sep 17 00:00:00 2001
>>> +From: "Carsten Haitzler (Rasterman)" <raster@rasterman.com>
>>> +Date: Sat, 15 Dec 2018 16:19:01 +0000
>>> +Subject: [PATCH] evas gl - make GLintptr etc. also ndefed for GL_VERSION_1_5
>>> + fix typedef
>>> +
>>> +It seems that GL_VERSION_1_5 define == these provided by gl already. At
>>> +least reading the mesa headers I do, so this should fix T7502
>>> +
>>> + at fix
>>
>> Your SoB line is missing here.
>> Also it would be great to add the upstream status of this patch.
>>
>> Otherwise, the patch is ok.
>>
>> Best regards,
>> Romain
>>
>
> I directly applied the original commit (as patch) from URI which you provided, and
> there was no SoB, so should I put there myself (I was not sure with this
> because I did not touched the original patch) ?
Even if the patch is not modified by you, contributors must add their SoB line
(even if upstream doesn't use them).
See:
https://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
Best regards,
Romain
>
> Regards,
> Vadim Kochan
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/efl: Fix build with mesa
2019-03-06 23:07 Vadim Kochan
@ 2019-03-06 23:10 ` Vadim Kochan
0 siblings, 0 replies; 6+ messages in thread
From: Vadim Kochan @ 2019-03-06 23:10 UTC (permalink / raw)
To: buildroot
Hi,
I am sorry, will resend with a proper changelog and subject prefix ...
just almost sleeping ...
On Thu, Mar 07, 2019 at 01:07:33AM +0200, Vadim Kochan wrote:
> efl does not compile with mesa without OpenGL ES because it checks for
> GL_ES_VERSION_2_0 and declares own GLintptr and GLsizeiptr types if such
> version is not defined, but mesa declares them too for OpenGL version
> 1.5, so fix it by add check also for OpenGL 1.5 where these types are
> defined.
>
> Use patch from:
> https://git.enlightenment.org/core/efl.git/commit/?id=0d2b624f1e24240a1c4e651aa1cfe9a8dd10a573
>
> Fixes:
> http://autobuild.buildroot.net/results/62ca120f1e54e8c3ae445f98b2624b526569f007
>
> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> ---
> ...e-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch | 34 ++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
> create mode 100644 package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch
>
> diff --git a/package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch b/package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch
> new file mode 100644
> index 0000000000..b64a200ffb
> --- /dev/null
> +++ b/package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch
> @@ -0,0 +1,34 @@
> +From d045dd99acdd47be238642d4f9384dccacde2b42 Mon Sep 17 00:00:00 2001
> +From: "Carsten Haitzler (Rasterman)" <raster@rasterman.com>
> +Date: Sat, 15 Dec 2018 16:19:01 +0000
> +Subject: [PATCH] evas gl - make GLintptr etc. also ndefed for GL_VERSION_1_5
> + fix typedef
> +
> +It seems that GL_VERSION_1_5 define == these provided by gl already. At
> +least reading the mesa headers I do, so this should fix T7502
> +
> +Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> +---
> + src/lib/evas/Evas_GL.h | 4 +++-
> + 1 file changed, 3 insertions(+), 1 deletion(-)
> +
> +diff --git a/src/lib/evas/Evas_GL.h b/src/lib/evas/Evas_GL.h
> +index fa3e6f4..5524d82 100644
> +--- a/src/lib/evas/Evas_GL.h
> ++++ b/src/lib/evas/Evas_GL.h
> +@@ -4272,9 +4272,11 @@ typedef signed int GLfixed; // Changed khronos_int32_t
> +
> + #ifndef GL_ES_VERSION_2_0
> + /* GL types for handling large vertex buffer objects */
> +-#include <stddef.h>
> ++# ifndef GL_VERSION_1_5
> ++# include <stddef.h>
> + typedef ptrdiff_t GLintptr; // Changed khronos_intptr_t
> + typedef ptrdiff_t GLsizeiptr; // Changed khronos_ssize_t
> ++# endif
> + #endif
> +
> + /* Some definitions from GLES 3.0.
> +--
> +2.14.1
> +
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/efl: Fix build with mesa
@ 2019-03-06 23:07 Vadim Kochan
2019-03-06 23:10 ` Vadim Kochan
0 siblings, 1 reply; 6+ messages in thread
From: Vadim Kochan @ 2019-03-06 23:07 UTC (permalink / raw)
To: buildroot
efl does not compile with mesa without OpenGL ES because it checks for
GL_ES_VERSION_2_0 and declares own GLintptr and GLsizeiptr types if such
version is not defined, but mesa declares them too for OpenGL version
1.5, so fix it by add check also for OpenGL 1.5 where these types are
defined.
Use patch from:
https://git.enlightenment.org/core/efl.git/commit/?id=0d2b624f1e24240a1c4e651aa1cfe9a8dd10a573
Fixes:
http://autobuild.buildroot.net/results/62ca120f1e54e8c3ae445f98b2624b526569f007
Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
---
...e-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch | 34 ++++++++++++++++++++++
1 file changed, 34 insertions(+)
create mode 100644 package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch
diff --git a/package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch b/package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch
new file mode 100644
index 0000000000..b64a200ffb
--- /dev/null
+++ b/package/efl/0001-evas-gl-make-GLintptr-etc.-also-ndefed-for-GL_VERSIO.patch
@@ -0,0 +1,34 @@
+From d045dd99acdd47be238642d4f9384dccacde2b42 Mon Sep 17 00:00:00 2001
+From: "Carsten Haitzler (Rasterman)" <raster@rasterman.com>
+Date: Sat, 15 Dec 2018 16:19:01 +0000
+Subject: [PATCH] evas gl - make GLintptr etc. also ndefed for GL_VERSION_1_5
+ fix typedef
+
+It seems that GL_VERSION_1_5 define == these provided by gl already. At
+least reading the mesa headers I do, so this should fix T7502
+
+Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
+---
+ src/lib/evas/Evas_GL.h | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/src/lib/evas/Evas_GL.h b/src/lib/evas/Evas_GL.h
+index fa3e6f4..5524d82 100644
+--- a/src/lib/evas/Evas_GL.h
++++ b/src/lib/evas/Evas_GL.h
+@@ -4272,9 +4272,11 @@ typedef signed int GLfixed; // Changed khronos_int32_t
+
+ #ifndef GL_ES_VERSION_2_0
+ /* GL types for handling large vertex buffer objects */
+-#include <stddef.h>
++# ifndef GL_VERSION_1_5
++# include <stddef.h>
+ typedef ptrdiff_t GLintptr; // Changed khronos_intptr_t
+ typedef ptrdiff_t GLsizeiptr; // Changed khronos_ssize_t
++# endif
+ #endif
+
+ /* Some definitions from GLES 3.0.
+--
+2.14.1
+
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-06 23:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-05 0:19 [Buildroot] [PATCH 1/1] package/efl: Fix build with mesa Vadim Kochan
2019-03-06 10:12 ` Romain Naour
2019-03-06 10:19 ` Vadym Kochan
2019-03-06 10:26 ` Romain Naour
2019-03-06 23:07 Vadim Kochan
2019-03-06 23:10 ` Vadim Kochan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.