From: Nicolas Ferre <nicolas.ferre@microchip.com> To: Quentin Schulz <quentin.schulz@free-electrons.com>, <broonie@kernel.org> Cc: <linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <alexandre.belloni@free-electrons.com>, <thomas.petazzoni@free-electrons.com> Subject: Re: [PATCH 2/2] spi: atmel: add PM support to SAMA5D2 Date: Wed, 12 Apr 2017 11:08:50 +0200 [thread overview] Message-ID: <30f4f62b-6fa0-bfd8-a855-8c394fba654b@microchip.com> (raw) In-Reply-To: <20170412070520.29621-2-quentin.schulz@free-electrons.com> Le 12/04/2017 à 09:05, Quentin Schulz a écrit : > This adds PM support to the ATMEL SAMA5D2 Xplained. Well not only for this board. The Backup+Self-Refresh PM state is available for all boards using the SAMA5D2 SoC (and beyond)... > When suspending, VDDCore is shut down and the SPI registers are lost. Yes, but only on sama5d2 and only if the Backup+Self-Refresh (or deepest PM state on sama5d2). > Thus, the SPI controller needs to be re-initialized after resuming from > a system suspend. > > Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com> I'm okay with the core of the patch but would prefer a modified commit message. Best regards, > --- > drivers/spi/spi-atmel.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c > index 247d920..1eb83c9 100644 > --- a/drivers/spi/spi-atmel.c > +++ b/drivers/spi/spi-atmel.c > @@ -1702,8 +1702,17 @@ static int atmel_spi_suspend(struct device *dev) > static int atmel_spi_resume(struct device *dev) > { > struct spi_master *master = dev_get_drvdata(dev); > + struct atmel_spi *as = spi_master_get_devdata(master); > int ret; > > + ret = clk_prepare_enable(as->clk); > + if (ret) > + return ret; > + > + atmel_spi_init(as); > + > + clk_disable_unprepare(as->clk); > + > if (!pm_runtime_suspended(dev)) { > ret = atmel_spi_runtime_resume(dev); > if (ret) > -- Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org> To: Quentin Schulz <quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>, <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>, <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Subject: Re: [PATCH 2/2] spi: atmel: add PM support to SAMA5D2 Date: Wed, 12 Apr 2017 11:08:50 +0200 [thread overview] Message-ID: <30f4f62b-6fa0-bfd8-a855-8c394fba654b@microchip.com> (raw) In-Reply-To: <20170412070520.29621-2-quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Le 12/04/2017 à 09:05, Quentin Schulz a écrit : > This adds PM support to the ATMEL SAMA5D2 Xplained. Well not only for this board. The Backup+Self-Refresh PM state is available for all boards using the SAMA5D2 SoC (and beyond)... > When suspending, VDDCore is shut down and the SPI registers are lost. Yes, but only on sama5d2 and only if the Backup+Self-Refresh (or deepest PM state on sama5d2). > Thus, the SPI controller needs to be re-initialized after resuming from > a system suspend. > > Signed-off-by: Quentin Schulz <quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> I'm okay with the core of the patch but would prefer a modified commit message. Best regards, > --- > drivers/spi/spi-atmel.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c > index 247d920..1eb83c9 100644 > --- a/drivers/spi/spi-atmel.c > +++ b/drivers/spi/spi-atmel.c > @@ -1702,8 +1702,17 @@ static int atmel_spi_suspend(struct device *dev) > static int atmel_spi_resume(struct device *dev) > { > struct spi_master *master = dev_get_drvdata(dev); > + struct atmel_spi *as = spi_master_get_devdata(master); > int ret; > > + ret = clk_prepare_enable(as->clk); > + if (ret) > + return ret; > + > + atmel_spi_init(as); > + > + clk_disable_unprepare(as->clk); > + > if (!pm_runtime_suspended(dev)) { > ret = atmel_spi_runtime_resume(dev); > if (ret) > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-04-12 9:08 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-12 7:05 [PATCH 1/2] spi: atmel: factorize reusable code for SPI controller init Quentin Schulz 2017-04-12 7:05 ` Quentin Schulz 2017-04-12 7:05 ` [PATCH 2/2] spi: atmel: add PM support to SAMA5D2 Quentin Schulz 2017-04-12 7:05 ` Quentin Schulz 2017-04-12 9:08 ` Nicolas Ferre [this message] 2017-04-12 9:08 ` Nicolas Ferre 2017-04-18 18:00 ` Applied "spi: atmel: add deepest PM support to SAMA5D2" to the spi tree Mark Brown 2017-04-12 8:40 ` [PATCH 1/2] spi: atmel: factorize reusable code for SPI controller init Nicolas Ferre 2017-04-12 8:40 ` Nicolas Ferre 2017-04-12 9:48 ` Applied "spi: atmel: factorize reusable code for SPI controller init" to the spi tree Mark Brown 2017-04-12 9:48 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=30f4f62b-6fa0-bfd8-a855-8c394fba654b@microchip.com \ --to=nicolas.ferre@microchip.com \ --cc=alexandre.belloni@free-electrons.com \ --cc=broonie@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=quentin.schulz@free-electrons.com \ --cc=thomas.petazzoni@free-electrons.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.