[PATCH] log: add missing symbol

[PATCH] log: add missing symbol

[Stephen Hemminger]

rte_get_log_type and rte_get_log_level functions has been avaliable
for many versions. But they are missing from the shared library map
and therefore do not get exported correctly.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
index cbe175f..51a241c 100644
--- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
+++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
@@ -93,7 +93,9 @@ DPDK_2.0 {
 	rte_realloc;
 	rte_set_application_usage_hook;
 	rte_set_log_level;
+	rte_get_log_level;
 	rte_set_log_type;
+	rte_get_log_type;
 	rte_socket_id;
 	rte_strerror;
 	rte_strsplit;
-- 
2.1.4

Re: [PATCH] log: add missing symbol

[Neil Horman]

On Wed, Dec 16, 2015 at 04:38:34PM -0800, Stephen Hemminger wrote:
> rte_get_log_type and rte_get_log_level functions has been avaliable
> for many versions. But they are missing from the shared library map
> and therefore do not get exported correctly.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> index cbe175f..51a241c 100644
> --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> @@ -93,7 +93,9 @@ DPDK_2.0 {
>  	rte_realloc;
>  	rte_set_application_usage_hook;
>  	rte_set_log_level;
> +	rte_get_log_level;
>  	rte_set_log_type;
> +	rte_get_log_type;
>  	rte_socket_id;
>  	rte_strerror;
>  	rte_strsplit;
> -- 
> 2.1.4
> 
> 
Acked-by: Neil Horman <nhorman@tuxdriver.com>

Re: [PATCH] log: add missing symbol

[Thomas Monjalon]

2015-12-16 16:38, Stephen Hemminger:
> rte_get_log_type and rte_get_log_level functions has been avaliable
> for many versions. But they are missing from the shared library map
> and therefore do not get exported correctly.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++
>  1 file changed, 2 insertions(+)

Why only in linuxapp?

> diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> index cbe175f..51a241c 100644
> --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> @@ -93,7 +93,9 @@ DPDK_2.0 {
>  	rte_realloc;
>  	rte_set_application_usage_hook;
>  	rte_set_log_level;
> +	rte_get_log_level;
>  	rte_set_log_type;
> +	rte_get_log_type;

We try to keep an alphabetical order :)

Re: [PATCH] log: add missing symbol

[Thomas Monjalon]

2016-01-27 10:35, Thomas Monjalon:
> 2015-12-16 16:38, Stephen Hemminger:
> > rte_get_log_type and rte_get_log_level functions has been avaliable
> > for many versions. But they are missing from the shared library map
> > and therefore do not get exported correctly.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> >  lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> Why only in linuxapp?
> 
> > diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> > index cbe175f..51a241c 100644
> > --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> > +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> > @@ -93,7 +93,9 @@ DPDK_2.0 {
> >  	rte_realloc;
> >  	rte_set_application_usage_hook;
> >  	rte_set_log_level;
> > +	rte_get_log_level;
> >  	rte_set_log_type;
> > +	rte_get_log_type;
> 
> We try to keep an alphabetical order :)

Reordered, updated in bsdapp/ and
Applied, thanks