From: "H. Nikolaus Schaller" <hns@goldelico.com> To: Andrzej Hajda <andrzej.hajda@intel.com>, Neil Armstrong <narmstrong@baylibre.com>, Robert Foss <robert.foss@linaro.org>, Paul Boddie <paul@boddie.org.uk>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jernej Skrabec <jernej.skrabec@gmail.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Paul Cercueil <paul@crapouillou.net>, Maxime Ripard <maxime@cerno.tech>, "H. Nikolaus Schaller" <hns@goldelico.com>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Cc: Jonas Karlman <jonas@kwiboo.se>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, letux-kernel@openphoenux.org Subject: [PATCH v16 3/4] drm/bridge: display-connector: add ddc-en gpio support Date: Sat, 26 Feb 2022 18:13:01 +0100 [thread overview] Message-ID: <31045a729978327615a50d4d17b47e6034095192.1645895582.git.hns@goldelico.com> (raw) In-Reply-To: <cover.1645895582.git.hns@goldelico.com> "hdmi-connector.yaml" bindings defines an optional property "ddc-en-gpios" for a single gpio to enable DDC operation. Usually this controls +5V power on the HDMI connector. This +5V may also be needed for HPD. This was not reflected in code. Now, the driver activates the ddc gpio after probe and deactivates after remove so it is "almost on". But only if this driver is loaded (and not e.g. blacklisted as module). Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> --- drivers/gpu/drm/bridge/display-connector.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/drm/bridge/display-connector.c index d24f5b90feabf..e4d52a7e31b71 100644 --- a/drivers/gpu/drm/bridge/display-connector.c +++ b/drivers/gpu/drm/bridge/display-connector.c @@ -24,6 +24,7 @@ struct display_connector { int hpd_irq; struct regulator *dp_pwr; + struct gpio_desc *ddc_en; }; static inline struct display_connector * @@ -345,6 +346,17 @@ static int display_connector_probe(struct platform_device *pdev) } } + /* enable DDC */ + if (type == DRM_MODE_CONNECTOR_HDMIA) { + conn->ddc_en = devm_gpiod_get_optional(&pdev->dev, "ddc-en", + GPIOD_OUT_HIGH); + + if (IS_ERR(conn->ddc_en)) { + dev_err(&pdev->dev, "Couldn't get ddc-en gpio\n"); + return PTR_ERR(conn->ddc_en); + } + } + conn->bridge.funcs = &display_connector_bridge_funcs; conn->bridge.of_node = pdev->dev.of_node; @@ -373,6 +385,9 @@ static int display_connector_remove(struct platform_device *pdev) { struct display_connector *conn = platform_get_drvdata(pdev); + if (conn->ddc_en) + gpiod_set_value(conn->ddc_en, 0); + if (conn->dp_pwr) regulator_disable(conn->dp_pwr); -- 2.33.0
WARNING: multiple messages have this Message-ID (diff)
From: "H. Nikolaus Schaller" <hns@goldelico.com> To: Andrzej Hajda <andrzej.hajda@intel.com>, Neil Armstrong <narmstrong@baylibre.com>, Robert Foss <robert.foss@linaro.org>, Paul Boddie <paul@boddie.org.uk>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jernej Skrabec <jernej.skrabec@gmail.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Paul Cercueil <paul@crapouillou.net>, Maxime Ripard <maxime@cerno.tech>, "H. Nikolaus Schaller" <hns@goldelico.com>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Cc: letux-kernel@openphoenux.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jonas Karlman <jonas@kwiboo.se> Subject: [PATCH v16 3/4] drm/bridge: display-connector: add ddc-en gpio support Date: Sat, 26 Feb 2022 18:13:01 +0100 [thread overview] Message-ID: <31045a729978327615a50d4d17b47e6034095192.1645895582.git.hns@goldelico.com> (raw) In-Reply-To: <cover.1645895582.git.hns@goldelico.com> "hdmi-connector.yaml" bindings defines an optional property "ddc-en-gpios" for a single gpio to enable DDC operation. Usually this controls +5V power on the HDMI connector. This +5V may also be needed for HPD. This was not reflected in code. Now, the driver activates the ddc gpio after probe and deactivates after remove so it is "almost on". But only if this driver is loaded (and not e.g. blacklisted as module). Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> --- drivers/gpu/drm/bridge/display-connector.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/drm/bridge/display-connector.c index d24f5b90feabf..e4d52a7e31b71 100644 --- a/drivers/gpu/drm/bridge/display-connector.c +++ b/drivers/gpu/drm/bridge/display-connector.c @@ -24,6 +24,7 @@ struct display_connector { int hpd_irq; struct regulator *dp_pwr; + struct gpio_desc *ddc_en; }; static inline struct display_connector * @@ -345,6 +346,17 @@ static int display_connector_probe(struct platform_device *pdev) } } + /* enable DDC */ + if (type == DRM_MODE_CONNECTOR_HDMIA) { + conn->ddc_en = devm_gpiod_get_optional(&pdev->dev, "ddc-en", + GPIOD_OUT_HIGH); + + if (IS_ERR(conn->ddc_en)) { + dev_err(&pdev->dev, "Couldn't get ddc-en gpio\n"); + return PTR_ERR(conn->ddc_en); + } + } + conn->bridge.funcs = &display_connector_bridge_funcs; conn->bridge.of_node = pdev->dev.of_node; @@ -373,6 +385,9 @@ static int display_connector_remove(struct platform_device *pdev) { struct display_connector *conn = platform_get_drvdata(pdev); + if (conn->ddc_en) + gpiod_set_value(conn->ddc_en, 0); + if (conn->dp_pwr) regulator_disable(conn->dp_pwr); -- 2.33.0
next prev parent reply other threads:[~2022-02-26 17:13 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-26 17:12 [PATCH v16 0/4] MIPS: JZ4780 and CI20 HDMI H. Nikolaus Schaller 2022-02-26 17:12 ` H. Nikolaus Schaller 2022-02-26 17:12 ` [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll() H. Nikolaus Schaller 2022-02-26 17:12 ` H. Nikolaus Schaller 2022-03-03 16:23 ` Neil Armstrong 2022-03-03 16:23 ` Neil Armstrong 2022-03-03 16:30 ` H. Nikolaus Schaller 2022-03-03 16:30 ` H. Nikolaus Schaller 2022-03-03 16:43 ` [Letux-kernel] " H. Nikolaus Schaller 2022-03-03 16:43 ` H. Nikolaus Schaller 2022-03-03 16:51 ` Paul Cercueil 2022-03-03 16:51 ` Paul Cercueil 2022-03-03 17:09 ` H. Nikolaus Schaller 2022-03-03 17:09 ` H. Nikolaus Schaller 2022-03-03 17:20 ` Paul Cercueil 2022-03-03 17:20 ` Paul Cercueil 2022-03-03 17:59 ` H. Nikolaus Schaller 2022-03-03 17:59 ` H. Nikolaus Schaller 2022-03-04 13:30 ` Neil Armstrong 2022-03-04 13:30 ` Neil Armstrong 2022-03-04 16:47 ` Paul Cercueil 2022-03-04 16:47 ` Paul Cercueil 2022-03-04 17:51 ` H. Nikolaus Schaller 2022-03-04 17:51 ` H. Nikolaus Schaller 2022-03-04 18:04 ` Paul Cercueil 2022-03-04 18:04 ` Paul Cercueil 2022-03-04 18:15 ` H. Nikolaus Schaller 2022-03-04 18:15 ` H. Nikolaus Schaller 2022-03-04 18:33 ` Paul Cercueil 2022-03-04 18:33 ` Paul Cercueil 2022-03-04 18:41 ` H. Nikolaus Schaller 2022-03-04 18:41 ` H. Nikolaus Schaller 2022-03-05 7:49 ` H. Nikolaus Schaller 2022-03-05 7:49 ` H. Nikolaus Schaller 2022-03-03 16:46 ` Paul Cercueil 2022-03-03 16:46 ` Paul Cercueil 2022-03-03 17:05 ` H. Nikolaus Schaller 2022-03-03 17:05 ` H. Nikolaus Schaller 2022-02-26 17:13 ` [PATCH v16 2/4] drm/ingenic: Add dw-hdmi driver specialization for jz4780 H. Nikolaus Schaller 2022-02-26 17:13 ` H. Nikolaus Schaller 2022-02-26 17:13 ` H. Nikolaus Schaller [this message] 2022-02-26 17:13 ` [PATCH v16 3/4] drm/bridge: display-connector: add ddc-en gpio support H. Nikolaus Schaller 2022-02-26 17:13 ` [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes H. Nikolaus Schaller 2022-02-26 17:13 ` H. Nikolaus Schaller 2022-03-01 9:18 ` Neil Armstrong 2022-03-01 9:18 ` Neil Armstrong 2022-03-01 20:37 ` H. Nikolaus Schaller 2022-03-01 20:37 ` H. Nikolaus Schaller 2022-03-02 10:25 ` Neil Armstrong 2022-03-02 10:25 ` Neil Armstrong 2022-03-02 11:15 ` H. Nikolaus Schaller 2022-03-02 11:15 ` H. Nikolaus Schaller 2022-03-02 14:34 ` Neil Armstrong 2022-03-02 14:34 ` Neil Armstrong 2022-03-02 22:24 ` H. Nikolaus Schaller 2022-03-02 22:24 ` H. Nikolaus Schaller 2022-03-03 8:35 ` Neil Armstrong 2022-03-03 8:35 ` Neil Armstrong 2022-03-03 10:40 ` H. Nikolaus Schaller 2022-03-03 10:40 ` H. Nikolaus Schaller 2022-03-03 11:42 ` Neil Armstrong 2022-03-03 11:42 ` Neil Armstrong 2022-03-03 11:45 ` H. Nikolaus Schaller 2022-03-03 11:45 ` H. Nikolaus Schaller 2022-03-03 15:37 ` H. Nikolaus Schaller 2022-03-03 15:37 ` H. Nikolaus Schaller 2022-03-03 16:14 ` Neil Armstrong 2022-03-03 16:14 ` Neil Armstrong 2022-03-03 15:15 ` Paul Cercueil 2022-03-03 15:15 ` Paul Cercueil
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=31045a729978327615a50d4d17b47e6034095192.1645895582.git.hns@goldelico.com \ --to=hns@goldelico.com \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=airlied@linux.ie \ --cc=andrzej.hajda@intel.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=jernej.skrabec@gmail.com \ --cc=jonas@kwiboo.se \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=letux-kernel@openphoenux.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=maxime@cerno.tech \ --cc=narmstrong@baylibre.com \ --cc=paul@boddie.org.uk \ --cc=paul@crapouillou.net \ --cc=robert.foss@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.