[PATCH] ata: pata_pdc202xx_old: make make static read-only array pio_timing const

[PATCH] ata: pata_pdc202xx_old: make make static read-only array pio_timing const

[Colin Ian King]

The static array pio_timing is read-only so it make sense to make
it const.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/ata/pata_pdc202xx_old.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/pata_pdc202xx_old.c b/drivers/ata/pata_pdc202xx_old.c
index b99849095853..f894ff2de0a9 100644
--- a/drivers/ata/pata_pdc202xx_old.c
+++ b/drivers/ata/pata_pdc202xx_old.c
@@ -78,7 +78,7 @@ static void pdc202xx_configure_piomode(struct ata_port *ap, struct ata_device *a
 {
 	struct pci_dev *pdev = to_pci_dev(ap->host->dev);
 	int port = 0x60 + 8 * ap->port_no + 4 * adev->devno;
-	static u16 pio_timing[5] = {
+	static const u16 pio_timing[5] = {
 		0x0913, 0x050C , 0x0308, 0x0206, 0x0104
 	};
 	u8 r_ap, r_bp;
-- 
2.33.1

Re: [PATCH] ata: pata_pdc202xx_old: make make static read-only array pio_timing const

[Sergey Shtylyov]

Hello!

   Too many verbs in the subject. :-)

On 1/24/22 1:22 AM, Colin Ian King wrote:

> The static array pio_timing is read-only so it make sense to make
> it const.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

   With that fixed:

Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>

[...]

MBR, Sergey

Re: [PATCH] ata: pata_pdc202xx_old: make make static read-only array pio_timing const

[Damien Le Moal]

On 2022/01/25 2:15, Sergey Shtylyov wrote:
> Hello!
> 
>    Too many verbs in the subject. :-)

Yep. I will fix that when applying. No need to resend !

> 
> On 1/24/22 1:22 AM, Colin Ian King wrote:
> 
>> The static array pio_timing is read-only so it make sense to make
>> it const.
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> 
>    With that fixed:
> 
> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>

Thanks for the review.

> 
> [...]
> 
> MBR, Sergey


-- 
Damien Le Moal
Western Digital Research

Re: [PATCH] ata: pata_pdc202xx_old: make make static read-only array pio_timing const

[Colin King (gmail)]

On 24/01/2022 21:37, Damien Le Moal wrote:
> On 2022/01/25 2:15, Sergey Shtylyov wrote:
>> Hello!
>>
>>     Too many verbs in the subject. :-)
> 
> Yep. I will fix that when applying. No need to resend !

Thanks for fixing this up. Much appreciated.
> 
>>
>> On 1/24/22 1:22 AM, Colin Ian King wrote:
>>
>>> The static array pio_timing is read-only so it make sense to make
>>> it const.
>>>
>>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>>
>>     With that fixed:
>>
>> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> 
> Thanks for the review.
> 
>>
>> [...]
>>
>> MBR, Sergey
> 
> 

Re: [PATCH] ata: pata_pdc202xx_old: make make static read-only array pio_timing const

[Damien Le Moal]

On 1/24/22 07:22, Colin Ian King wrote:
> The static array pio_timing is read-only so it make sense to make
> it const.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Applied to for-5.18. Thanks !

-- 
Damien Le Moal
Western Digital Research