From: William Kucharski <william.kucharski@oracle.com>
To: Shakeel Butt <shakeelb@google.com>
Cc: Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Florian Westphal <fw@strlen.de>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
syzbot+7713f3aa67be76b1552c@syzkaller.appspotmail.com,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Roopa Prabhu <roopa@cumulusnetworks.com>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
bridge@lists.linux-foundation.org
Subject: Re: [PATCH v2] netfilter: account ebt_table_info to kmemcg
Date: Thu, 3 Jan 2019 03:14:56 -0700 [thread overview]
Message-ID: <313C6566-289D-4973-BB15-857EED858DA3@oracle.com> (raw)
In-Reply-To: <20190103031431.247970-1-shakeelb@google.com>
> On Jan 2, 2019, at 8:14 PM, Shakeel Butt <shakeelb@google.com> wrote:
>
> countersize = COUNTER_OFFSET(tmp.nentries) * nr_cpu_ids;
> - newinfo = vmalloc(sizeof(*newinfo) + countersize);
> + newinfo = __vmalloc(sizeof(*newinfo) + countersize, GFP_KERNEL_ACCOUNT,
> + PAGE_KERNEL);
> if (!newinfo)
> return -ENOMEM;
>
> if (countersize)
> memset(newinfo->counters, 0, countersize);
>
> - newinfo->entries = vmalloc(tmp.entries_size);
> + newinfo->entries = __vmalloc(tmp.entries_size, GFP_KERNEL_ACCOUNT,
> + PAGE_KERNEL);
> if (!newinfo->entries) {
> ret = -ENOMEM;
> goto free_newinfo;
> --
Just out of curiosity, what are the actual sizes of these areas in typical use
given __vmalloc() will be allocating by the page?
WARNING: multiple messages have this Message-ID (diff)
From: William Kucharski <william.kucharski@oracle.com>
To: Shakeel Butt <shakeelb@google.com>
Cc: coreteam@netfilter.org,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
Roopa Prabhu <roopa@cumulusnetworks.com>,
bridge@lists.linux-foundation.org,
Florian Westphal <fw@strlen.de>,
LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@kernel.org>, Linux-MM <linux-mm@kvack.org>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
netfilter-devel@vger.kernel.org,
syzbot+7713f3aa67be76b1552c@syzkaller.appspotmail.com,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [Bridge] [PATCH v2] netfilter: account ebt_table_info to kmemcg
Date: Thu, 3 Jan 2019 03:14:56 -0700 [thread overview]
Message-ID: <313C6566-289D-4973-BB15-857EED858DA3@oracle.com> (raw)
In-Reply-To: <20190103031431.247970-1-shakeelb@google.com>
> On Jan 2, 2019, at 8:14 PM, Shakeel Butt <shakeelb@google.com> wrote:
>
> countersize = COUNTER_OFFSET(tmp.nentries) * nr_cpu_ids;
> - newinfo = vmalloc(sizeof(*newinfo) + countersize);
> + newinfo = __vmalloc(sizeof(*newinfo) + countersize, GFP_KERNEL_ACCOUNT,
> + PAGE_KERNEL);
> if (!newinfo)
> return -ENOMEM;
>
> if (countersize)
> memset(newinfo->counters, 0, countersize);
>
> - newinfo->entries = vmalloc(tmp.entries_size);
> + newinfo->entries = __vmalloc(tmp.entries_size, GFP_KERNEL_ACCOUNT,
> + PAGE_KERNEL);
> if (!newinfo->entries) {
> ret = -ENOMEM;
> goto free_newinfo;
> --
Just out of curiosity, what are the actual sizes of these areas in typical use
given __vmalloc() will be allocating by the page?
next prev parent reply other threads:[~2019-01-03 10:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 3:14 [PATCH v2] netfilter: account ebt_table_info to kmemcg Shakeel Butt
2019-01-03 3:14 ` [Bridge] " Shakeel Butt
2019-01-03 3:14 ` Shakeel Butt
2019-01-03 3:14 ` Shakeel Butt via Bridge
2019-01-03 10:14 ` William Kucharski [this message]
2019-01-03 10:14 ` [Bridge] " William Kucharski
2019-01-03 16:18 ` Shakeel Butt
2019-01-03 16:18 ` [Bridge] " Shakeel Butt
2019-01-03 16:18 ` Shakeel Butt
2019-01-06 11:00 ` Kirill Tkhai
2019-01-06 11:00 ` [Bridge] " Kirill Tkhai
2019-01-06 11:00 ` Kirill Tkhai
2019-01-06 11:00 ` Kirill Tkhai
2019-01-10 9:22 ` Kirill Tkhai
2019-01-10 9:22 ` [Bridge] " Kirill Tkhai
2019-01-10 9:41 ` Michal Hocko
2019-01-10 9:41 ` [Bridge] " Michal Hocko
2019-01-10 9:48 ` Kirill Tkhai
2019-01-10 9:48 ` [Bridge] " Kirill Tkhai
2019-01-10 0:44 ` Pablo Neira Ayuso
2019-01-10 0:44 ` [Bridge] " Pablo Neira Ayuso
2019-01-10 0:44 ` Pablo Neira Ayuso
2019-01-10 23:57 ` Pablo Neira Ayuso
2019-01-10 23:57 ` [Bridge] " Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=313C6566-289D-4973-BB15-857EED858DA3@oracle.com \
--to=william.kucharski@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bridge@lists.linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=pablo@netfilter.org \
--cc=roopa@cumulusnetworks.com \
--cc=shakeelb@google.com \
--cc=syzbot+7713f3aa67be76b1552c@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.