From: "Heiko Stübner" <heiko@sntech.de>
To: Tobias Schramm <t.schramm@manjaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Andy Yan <andy.yan@rock-chips.com>,
Douglas Anderson <dianders@chromium.org>,
Jagan Teki <jagan@amarulasolutions.com>,
Markus Reichl <m.reichl@fivetechno.de>,
Alexis Ballier <aballier@gentoo.org>,
Matthias Kaehlcke <mka@chromium.org>, Nick Xie <nick@khadas.com>,
Kever Yang <kever.yang@rock-chips.com>,
Vivek Unune <npcomplete13@gmail.com>,
Katsuhiro Suzuki <katsuhiro@katsuster.net>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
anarsoul@gmail.com, enric.balletbo@collabora.com
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add initial support for Pinebook Pro
Date: Fri, 28 Feb 2020 16:15:25 +0100 [thread overview]
Message-ID: <3144691.gaQQKPV42P@diego> (raw)
In-Reply-To: <37190f26-48aa-dcad-d4b1-8a534ba1360e@manjaro.org>
Hi Tobias,
Am Freitag, 28. Februar 2020, 15:57:10 CET schrieb Tobias Schramm:
> thanks for the review. I'll implement the changes and send a v2.
>
> >> + * of wakeup sources without disabling the whole key
> > Also can you explain the problem a bit? If there is a deficit in the input
> > subsystem regarding wakeup events, dt is normally not the place to work
> > around things [we're supposed to be OS independent]
>
> The issue is that some users wanted to be able to control the wakeup
> functionality of the keys separately via sysfs. That does not seem to be
> possible when combining both keys into one gpio-keys node. A more
> detailed explanation of the issue can be found at [1].
ok ... but that is really strange, because looking at gpio-keys.c I see
it checking the individual button wakeup-property before setting
the irq-wake in gpio_keys_enable_wakeup() .
Ah, but I guess manually disabling/enabling wakeup via sysfs only
works for the whole device and all wakeup buttons.
In general this sounds more like a gpio-keys deficit, but in the end
we can keep the separate gpio-key nodes here, they don't violate any
dt-bindings ;-) .
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Tobias Schramm <t.schramm-x9ov/VOV9nNAfugRpC6u6w@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Andy Yan <andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
Douglas Anderson
<dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Jagan Teki
<jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>,
Markus Reichl <m.reichl-SRyzfwRm/0rPTwkrwQOX7A@public.gmane.org>,
Alexis Ballier <aballier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>,
Matthias Kaehlcke <mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Nick Xie <nick-XW3xCAIBE2TQT0dZR+AlfA@public.gmane.org>,
Kever Yang <kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
Vivek Unune
<npcomplete13-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Katsuhiro Suzuki
<katsuhiro-WKCMddiH/C4xsqv6Oivclw@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add initial support for Pinebook Pro
Date: Fri, 28 Feb 2020 16:15:25 +0100 [thread overview]
Message-ID: <3144691.gaQQKPV42P@diego> (raw)
In-Reply-To: <37190f26-48aa-dcad-d4b1-8a534ba1360e-x9ov/VOV9nNAfugRpC6u6w@public.gmane.org>
Hi Tobias,
Am Freitag, 28. Februar 2020, 15:57:10 CET schrieb Tobias Schramm:
> thanks for the review. I'll implement the changes and send a v2.
>
> >> + * of wakeup sources without disabling the whole key
> > Also can you explain the problem a bit? If there is a deficit in the input
> > subsystem regarding wakeup events, dt is normally not the place to work
> > around things [we're supposed to be OS independent]
>
> The issue is that some users wanted to be able to control the wakeup
> functionality of the keys separately via sysfs. That does not seem to be
> possible when combining both keys into one gpio-keys node. A more
> detailed explanation of the issue can be found at [1].
ok ... but that is really strange, because looking at gpio-keys.c I see
it checking the individual button wakeup-property before setting
the irq-wake in gpio_keys_enable_wakeup() .
Ah, but I guess manually disabling/enabling wakeup via sysfs only
works for the whole device and all wakeup buttons.
In general this sounds more like a gpio-keys deficit, but in the end
we can keep the separate gpio-key nodes here, they don't violate any
dt-bindings ;-) .
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Tobias Schramm <t.schramm@manjaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Alexis Ballier <aballier@gentoo.org>,
Katsuhiro Suzuki <katsuhiro@katsuster.net>,
linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Kever Yang <kever.yang@rock-chips.com>,
Markus Reichl <m.reichl@fivetechno.de>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Jagan Teki <jagan@amarulasolutions.com>,
Nick Xie <nick@khadas.com>,
enric.balletbo@collabora.com, Andy Yan <andy.yan@rock-chips.com>,
Matthias Kaehlcke <mka@chromium.org>,
Vivek Unune <npcomplete13@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add initial support for Pinebook Pro
Date: Fri, 28 Feb 2020 16:15:25 +0100 [thread overview]
Message-ID: <3144691.gaQQKPV42P@diego> (raw)
In-Reply-To: <37190f26-48aa-dcad-d4b1-8a534ba1360e@manjaro.org>
Hi Tobias,
Am Freitag, 28. Februar 2020, 15:57:10 CET schrieb Tobias Schramm:
> thanks for the review. I'll implement the changes and send a v2.
>
> >> + * of wakeup sources without disabling the whole key
> > Also can you explain the problem a bit? If there is a deficit in the input
> > subsystem regarding wakeup events, dt is normally not the place to work
> > around things [we're supposed to be OS independent]
>
> The issue is that some users wanted to be able to control the wakeup
> functionality of the keys separately via sysfs. That does not seem to be
> possible when combining both keys into one gpio-keys node. A more
> detailed explanation of the issue can be found at [1].
ok ... but that is really strange, because looking at gpio-keys.c I see
it checking the individual button wakeup-property before setting
the irq-wake in gpio_keys_enable_wakeup() .
Ah, but I guess manually disabling/enabling wakeup via sysfs only
works for the whole device and all wakeup buttons.
In general this sounds more like a gpio-keys deficit, but in the end
we can keep the separate gpio-key nodes here, they don't violate any
dt-bindings ;-) .
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-28 15:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 18:06 [PATCH 0/2] Add support for the pine64 Pinebook Pro Tobias Schramm
2020-02-27 18:06 ` Tobias Schramm
2020-02-27 18:06 ` [PATCH 1/2] dt-bindings: Add doc for " Tobias Schramm
2020-02-27 18:06 ` Tobias Schramm
2020-02-27 18:06 ` Tobias Schramm
2020-02-27 18:06 ` [PATCH 2/2] arm64: dts: rockchip: Add initial support for " Tobias Schramm
2020-02-27 18:06 ` Tobias Schramm
2020-02-28 14:19 ` Heiko Stübner
2020-02-28 14:19 ` Heiko Stübner
2020-02-28 14:19 ` Heiko Stübner
2020-02-28 14:57 ` Tobias Schramm
2020-02-28 14:57 ` Tobias Schramm
2020-02-28 15:15 ` Heiko Stübner [this message]
2020-02-28 15:15 ` Heiko Stübner
2020-02-28 15:15 ` Heiko Stübner
-- strict thread matches above, loose matches on Subject: below --
2020-01-16 22:56 [PATCH 1/2] dt-bindings: Add doc for Pine64 " Emmanuel Vadot
2020-01-16 22:56 ` [PATCH 2/2] arm64: dts: rockchip: Add initial support for " Emmanuel Vadot
2020-01-16 22:56 ` Emmanuel Vadot
2020-01-19 20:17 ` Heiko Stübner
2020-01-19 20:17 ` Heiko Stübner
2020-01-19 20:17 ` Heiko Stübner
2020-01-19 21:31 ` Emmanuel Vadot
2020-01-19 21:31 ` Emmanuel Vadot
2020-01-19 21:31 ` Emmanuel Vadot
2020-01-21 14:13 ` Tobias Schramm
2020-01-21 14:13 ` Tobias Schramm
2020-01-21 14:13 ` Tobias Schramm
2020-01-21 14:21 ` Heiko Stuebner
2020-01-21 14:21 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3144691.gaQQKPV42P@diego \
--to=heiko@sntech.de \
--cc=aballier@gentoo.org \
--cc=anarsoul@gmail.com \
--cc=andy.yan@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=jagan@amarulasolutions.com \
--cc=katsuhiro@katsuster.net \
--cc=kever.yang@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=m.reichl@fivetechno.de \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=nick@khadas.com \
--cc=npcomplete13@gmail.com \
--cc=robh+dt@kernel.org \
--cc=t.schramm@manjaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.