[U-Boot] WaRP7 nok on master

[U-Boot] WaRP7 nok on master

[Pierre-Jean Texier]

Hi Fabio, Stefano,

Just FYI, I just tested the U-Boot master branch (with u-boot-imx merges).
And I have some problems when the WaRP7 boot-up.
In fact, no output...

However, on u-boot-imx, everything works well (tags/u-boot-imx-20190426).

After some manipulation with git bisect, it appears that the problem 
comes from commit [1].
So, with a git revert 3a7c45f6a7725808e2e82908be4bc90d4d78e737, 
everything works again.

Without this revert, the WaRP7 is not
functional (also the pico-pi i.MX7 if DM_SERIAL is implemented, tested 
by Joris in CC).



Thanks

BR
/Pierre-Jean

[1] 
https://github.com/trini/u-boot/commit/3a7c45f6a7725808e2e82908be4bc90d4d78e737

[U-Boot] WaRP7 nok on master

[Stefano Babic]

Hi Piere, Lukasz,

On 01/05/19 20:49, Pierre-Jean Texier wrote:
> Hi Fabio, Stefano,
> 
> Just FYI, I just tested the U-Boot master branch (with u-boot-imx merges).
> And I have some problems when the WaRP7 boot-up.
> In fact, no output...
> 
> However, on u-boot-imx, everything works well (tags/u-boot-imx-20190426).
> 
> After some manipulation with git bisect, it appears that the problem
> comes from commit [1].
> So, with a git revert 3a7c45f6a7725808e2e82908be4bc90d4d78e737,
> everything works again.
> 
> Without this revert, the WaRP7 is not
> functional (also the pico-pi i.MX7 if DM_SERIAL is implemented, tested
> by Joris in CC)

This is painful - Lukasz, can you comment this ? Your patch is small and
it seems to fix just qemu, it is difficult to understand why it has side
effects on real SOCs like i.MX.

Regards,
Stefano



> 
> 
> 
> Thanks
> 
> BR
> /Pierre-Jean
> 
> [1]
> https://github.com/trini/u-boot/commit/3a7c45f6a7725808e2e82908be4bc90d4d78e737
> 
> 


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[U-Boot] WaRP7 nok on master

[Auer, Lukas]

Hi Stefano,

On Thu, 2019-05-02 at 10:55 +0200, Stefano Babic wrote:
> Hi Piere, Lukasz,
> 
> On 01/05/19 20:49, Pierre-Jean Texier wrote:
> > Hi Fabio, Stefano,
> > 
> > Just FYI, I just tested the U-Boot master branch (with u-boot-imx merges).
> > And I have some problems when the WaRP7 boot-up.
> > In fact, no output...
> > 
> > However, on u-boot-imx, everything works well (tags/u-boot-imx-20190426).
> > 
> > After some manipulation with git bisect, it appears that the problem
> > comes from commit [1].
> > So, with a git revert 3a7c45f6a7725808e2e82908be4bc90d4d78e737,
> > everything works again.
> > 
> > Without this revert, the WaRP7 is not
> > functional (also the pico-pi i.MX7 if DM_SERIAL is implemented, tested
> > by Joris in CC)
> 
> This is painful - Lukasz, can you comment this ? Your patch is small and
> it seems to fix just qemu, it is difficult to understand why it has side
> effects on real SOCs like i.MX.
> 

I was able to reproduce the issue on my side. With the patch, U-Boot
probes the drivers for devices under simple-bus device tree nodes in
the pre-relocation device model. The default value of
CONFIG_SYS_MALLOC_LEN (0x400) leaves U-Boot with not enough memory to
do this, causing it to hang. If it is increased, for example to 0x1000,
everything works again.

Let me know, how you want to fix this. If you want, I can send a patch
to increase CONFIG_SYS_MALLOC_LEN for the i.MX parts.

Thanks,
Lukas

> > 
> > [1]
> > https://github.com/trini/u-boot/commit/3a7c45f6a7725808e2e82908be4bc90d4d78e737
> > 

[U-Boot] WaRP7 nok on master

[Pierre-Jean Texier]

Hi Lucas,

Le 02/05/2019 à 12:21, Auer, Lukas a écrit :
> Hi Stefano,
>
> On Thu, 2019-05-02 at 10:55 +0200, Stefano Babic wrote:
>> Hi Piere, Lukasz,
>>
>> On 01/05/19 20:49, Pierre-Jean Texier wrote:
>>> Hi Fabio, Stefano,
>>>
>>> Just FYI, I just tested the U-Boot master branch (with u-boot-imx merges).
>>> And I have some problems when the WaRP7 boot-up.
>>> In fact, no output...
>>>
>>> However, on u-boot-imx, everything works well (tags/u-boot-imx-20190426).
>>>
>>> After some manipulation with git bisect, it appears that the problem
>>> comes from commit [1].
>>> So, with a git revert 3a7c45f6a7725808e2e82908be4bc90d4d78e737,
>>> everything works again.
>>>
>>> Without this revert, the WaRP7 is not
>>> functional (also the pico-pi i.MX7 if DM_SERIAL is implemented, tested
>>> by Joris in CC)
>> This is painful - Lukasz, can you comment this ? Your patch is small and
>> it seems to fix just qemu, it is difficult to understand why it has side
>> effects on real SOCs like i.MX.
>>
> I was able to reproduce the issue on my side. With the patch, U-Boot
> probes the drivers for devices under simple-bus device tree nodes in
> the pre-relocation device model. The default value of
> CONFIG_SYS_MALLOC_LEN (0x400) leaves U-Boot with not enough memory to
> do this, causing it to hang. If it is increased, for example to 0x1000,
> everything works again.
>
> Let me know, how you want to fix this. If you want, I can send a patch
> to increase CONFIG_SYS_MALLOC_LEN for the i.MX parts.


Indeed, everything works again with 0x1000 for CONFIG_SYS_MALLOC_LEN.

Thanks


Pierre-Jean


>
> Thanks,
> Lukas
>
>>> [1]
>>> https://github.com/trini/u-boot/commit/3a7c45f6a7725808e2e82908be4bc90d4d78e737
>>>

[U-Boot] WaRP7 nok on master

[Fabio Estevam]

Hi Lukas,

On Thu, May 2, 2019 at 7:21 AM Auer, Lukas
<lukas.auer@aisec.fraunhofer.de> wrote:

> I was able to reproduce the issue on my side. With the patch, U-Boot
> probes the drivers for devices under simple-bus device tree nodes in
> the pre-relocation device model. The default value of
> CONFIG_SYS_MALLOC_LEN (0x400) leaves U-Boot with not enough memory to
> do this, causing it to hang. If it is increased, for example to 0x1000,
> everything works again.
>
> Let me know, how you want to fix this. If you want, I can send a patch
> to increase CONFIG_SYS_MALLOC_LEN for the i.MX parts.

I guess you mean CONFIG_SYS_MALLOC_F_LEN instead?

Could you please send a patch setting CONFIG_SYS_MALLOC_F_LEN as
0x2000 by default for i.MX?

0x1000 seems not to be enough:
http://git.denx.de/?p=u-boot.git;a=commitdiff;h=8b9cba0295dcdce5eb8bb10d79f6dafb5a167349;hp=b7de88cd5cb8c213fb158b37fcf0662c1d2332cd

[U-Boot] WaRP7 nok on master

[Auer, Lukas]

Hi Fabio,

On Thu, 2019-05-02 at 11:08 -0300, Fabio Estevam wrote:
> Hi Lukas,
> 
> On Thu, May 2, 2019 at 7:21 AM Auer, Lukas
> <lukas.auer@aisec.fraunhofer.de> wrote:
> 
> > I was able to reproduce the issue on my side. With the patch, U-Boot
> > probes the drivers for devices under simple-bus device tree nodes in
> > the pre-relocation device model. The default value of
> > CONFIG_SYS_MALLOC_LEN (0x400) leaves U-Boot with not enough memory to
> > do this, causing it to hang. If it is increased, for example to 0x1000,
> > everything works again.
> > 
> > Let me know, how you want to fix this. If you want, I can send a patch
> > to increase CONFIG_SYS_MALLOC_LEN for the i.MX parts.
> 
> I guess you mean CONFIG_SYS_MALLOC_F_LEN instead?
> 

Oops yes, that's what I meant.

> Could you please send a patch setting CONFIG_SYS_MALLOC_F_LEN as
> 0x2000 by default for i.MX?
> 
> 0x1000 seems not to be enough:
> http://git.denx.de/?p=u-boot.git;a=commitdiff;h=8b9cba0295dcdce5eb8bb10d79f6dafb5a167349;hp=b7de88cd5cb8c213fb158b37fcf0662c1d2332cd

Yes, I will send a patch for this. Do you prefer setting the default
value for i.MX in one place (in arch/arm/mach-imx/Kconfig) or
individually for each sub-family (for example in arch/arm/mach-
imx/mx7/Kconfig for i.MX7)?

Thanks,
Lukas

[U-Boot] WaRP7 nok on master

[Fabio Estevam]

Hi Lukas,

On Thu, May 2, 2019 at 1:58 PM Auer, Lukas
<lukas.auer@aisec.fraunhofer.de> wrote:

> Yes, I will send a patch for this. Do you prefer setting the default
> value for i.MX in one place (in arch/arm/mach-imx/Kconfig) or
> individually for each sub-family (for example in arch/arm/mach-
> imx/mx7/Kconfig for i.MX7)?

I think we can set it in one place. Thanks

[U-Boot] WaRP7 nok on master

[Fabio Estevam]

Hi Lukas,

On Thu, May 2, 2019 at 1:59 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Lukas,
>
> On Thu, May 2, 2019 at 1:58 PM Auer, Lukas
> <lukas.auer@aisec.fraunhofer.de> wrote:
>
> > Yes, I will send a patch for this. Do you prefer setting the default
> > value for i.MX in one place (in arch/arm/mach-imx/Kconfig) or
> > individually for each sub-family (for example in arch/arm/mach-
> > imx/mx7/Kconfig for i.MX7)?
>
> I think we can set it in one place. Thanks

I have just submitted a patch for this. Please take a look.

Thanks

[U-Boot] WaRP7 nok on master

[Auer, Lukas]

Hi Fabio,

On Fri, 2019-05-03 at 09:26 -0300, Fabio Estevam wrote:
> Hi Lukas,
> 
> On Thu, May 2, 2019 at 1:59 PM Fabio Estevam <festevam@gmail.com> wrote:
> > Hi Lukas,
> > 
> > On Thu, May 2, 2019 at 1:58 PM Auer, Lukas
> > <lukas.auer@aisec.fraunhofer.de> wrote:
> > 
> > > Yes, I will send a patch for this. Do you prefer setting the default
> > > value for i.MX in one place (in arch/arm/mach-imx/Kconfig) or
> > > individually for each sub-family (for example in arch/arm/mach-
> > > imx/mx7/Kconfig for i.MX7)?
> > 
> > I think we can set it in one place. Thanks
> 
> I have just submitted a patch for this. Please take a look.
> 
> Thanks

Sorry, I have been busy until now. I will take a look.

Thanks,
Lukas