* [PATCH] staging: wfx: silence symbol 'wfx_get_ps_timeout' was not declared warning
@ 2021-04-19 15:33 ` Ashish Kalra
0 siblings, 0 replies; 6+ messages in thread
From: Ashish Kalra @ 2021-04-19 15:33 UTC (permalink / raw)
To: Jérôme Pouiller, Greg Kroah-Hartman, devel, linux-kernel
Cc: eashishkalra
Upon running sparse, "warning: symbol 'wfx_get_ps_timeout' was not declared.
Should it be static?" and "warning: symbol 'wfx_update_pm' was not declared.
Should it be static?" is brought to notice for this file. static keyword
should be added to prevent this warning. let's add it to make it cleaner and
silence the Sparse warning.
Signed-off-by: Ashish Kalra <eashishkalra@gmail.com>
---
drivers/staging/wfx/sta.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
index 12e8a5b638f1..d855d87c2102 100644
--- a/drivers/staging/wfx/sta.c
+++ b/drivers/staging/wfx/sta.c
@@ -200,7 +200,7 @@ void wfx_configure_filter(struct ieee80211_hw *hw, unsigned int changed_flags,
mutex_unlock(&wdev->conf_mutex);
}
-int wfx_get_ps_timeout(struct wfx_vif *wvif, bool *enable_ps)
+static int wfx_get_ps_timeout(struct wfx_vif *wvif, bool *enable_ps)
{
struct ieee80211_channel *chan0 = NULL, *chan1 = NULL;
struct ieee80211_conf *conf = &wvif->wdev->hw->conf;
@@ -230,7 +230,7 @@ int wfx_get_ps_timeout(struct wfx_vif *wvif, bool *enable_ps)
return -1;
}
-int wfx_update_pm(struct wfx_vif *wvif)
+static int wfx_update_pm(struct wfx_vif *wvif)
{
int ps_timeout;
bool ps;
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] staging: wfx: silence symbol 'wfx_get_ps_timeout' was not declared warning
@ 2021-04-19 15:33 ` Ashish Kalra
0 siblings, 0 replies; 6+ messages in thread
From: Ashish Kalra @ 2021-04-19 15:33 UTC (permalink / raw)
To: Jérôme Pouiller, Greg Kroah-Hartman, devel, linux-kernel
Cc: eashishkalra
Upon running sparse, "warning: symbol 'wfx_get_ps_timeout' was not declared.
Should it be static?" and "warning: symbol 'wfx_update_pm' was not declared.
Should it be static?" is brought to notice for this file. static keyword
should be added to prevent this warning. let's add it to make it cleaner and
silence the Sparse warning.
Signed-off-by: Ashish Kalra <eashishkalra@gmail.com>
---
drivers/staging/wfx/sta.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
index 12e8a5b638f1..d855d87c2102 100644
--- a/drivers/staging/wfx/sta.c
+++ b/drivers/staging/wfx/sta.c
@@ -200,7 +200,7 @@ void wfx_configure_filter(struct ieee80211_hw *hw, unsigned int changed_flags,
mutex_unlock(&wdev->conf_mutex);
}
-int wfx_get_ps_timeout(struct wfx_vif *wvif, bool *enable_ps)
+static int wfx_get_ps_timeout(struct wfx_vif *wvif, bool *enable_ps)
{
struct ieee80211_channel *chan0 = NULL, *chan1 = NULL;
struct ieee80211_conf *conf = &wvif->wdev->hw->conf;
@@ -230,7 +230,7 @@ int wfx_get_ps_timeout(struct wfx_vif *wvif, bool *enable_ps)
return -1;
}
-int wfx_update_pm(struct wfx_vif *wvif)
+static int wfx_update_pm(struct wfx_vif *wvif)
{
int ps_timeout;
bool ps;
--
2.25.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: wfx: silence symbol 'wfx_get_ps_timeout' was not declared warning
2021-04-19 15:33 ` Ashish Kalra
@ 2021-04-19 15:55 ` Jérôme Pouiller
-1 siblings, 0 replies; 6+ messages in thread
From: Jérôme Pouiller @ 2021-04-19 15:55 UTC (permalink / raw)
To: Greg Kroah-Hartman, devel, linux-kernel, Ashish Kalra
On Monday 19 April 2021 17:33:48 CEST Ashish Kalra wrote:
>
> Upon running sparse, "warning: symbol 'wfx_get_ps_timeout' was not declared.
> Should it be static?" and "warning: symbol 'wfx_update_pm' was not declared.
> Should it be static?" is brought to notice for this file. static keyword
> should be added to prevent this warning. let's add it to make it cleaner and
> silence the Sparse warning.
Hi Ashish,
Thank you for your contribution.
It seems that this issue is already fixed by commit ce59858bbc10 "staging:
wfx: make methods 'wfx_get_ps_timeout' and 'wfx_update_pm' static" (merged
in master in version 5.8). Can you check you are working on the last tree?
--
Jérôme Pouiller
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: wfx: silence symbol 'wfx_get_ps_timeout' was not declared warning
@ 2021-04-19 15:55 ` Jérôme Pouiller
0 siblings, 0 replies; 6+ messages in thread
From: Jérôme Pouiller @ 2021-04-19 15:55 UTC (permalink / raw)
To: Greg Kroah-Hartman, devel, linux-kernel, Ashish Kalra
On Monday 19 April 2021 17:33:48 CEST Ashish Kalra wrote:
>
> Upon running sparse, "warning: symbol 'wfx_get_ps_timeout' was not declared.
> Should it be static?" and "warning: symbol 'wfx_update_pm' was not declared.
> Should it be static?" is brought to notice for this file. static keyword
> should be added to prevent this warning. let's add it to make it cleaner and
> silence the Sparse warning.
Hi Ashish,
Thank you for your contribution.
It seems that this issue is already fixed by commit ce59858bbc10 "staging:
wfx: make methods 'wfx_get_ps_timeout' and 'wfx_update_pm' static" (merged
in master in version 5.8). Can you check you are working on the last tree?
--
Jérôme Pouiller
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: wfx: silence symbol 'wfx_get_ps_timeout' was not declared warning
2021-04-19 15:55 ` Jérôme Pouiller
@ 2021-04-19 16:56 ` Ashish Kalra
-1 siblings, 0 replies; 6+ messages in thread
From: Ashish Kalra @ 2021-04-19 16:56 UTC (permalink / raw)
To: Jérôme Pouiller
Cc: Greg Kroah-Hartman, devel, linux-kernel, Ashish Kalra
On Mon, Apr 19, 2021 at 05:55:34PM +0200, Jérôme Pouiller wrote:
> On Monday 19 April 2021 17:33:48 CEST Ashish Kalra wrote:
> >
> > Upon running sparse, "warning: symbol 'wfx_get_ps_timeout' was not declared.
> > Should it be static?" and "warning: symbol 'wfx_update_pm' was not declared.
> > Should it be static?" is brought to notice for this file. static keyword
> > should be added to prevent this warning. let's add it to make it cleaner and
> > silence the Sparse warning.
>
> Hi Ashish,
>
> Thank you for your contribution.
>
> It seems that this issue is already fixed by commit ce59858bbc10 "staging:
> wfx: make methods 'wfx_get_ps_timeout' and 'wfx_update_pm' static" (merged
> in master in version 5.8). Can you check you are working on the last tree?
>
>
> --
> Jérôme Pouiller
>
>
Thanks Jerome
It seems some sync issue with my source code.I will update to
latest and correct
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: wfx: silence symbol 'wfx_get_ps_timeout' was not declared warning
@ 2021-04-19 16:56 ` Ashish Kalra
0 siblings, 0 replies; 6+ messages in thread
From: Ashish Kalra @ 2021-04-19 16:56 UTC (permalink / raw)
To: Jérôme Pouiller
Cc: devel, Greg Kroah-Hartman, linux-kernel, Ashish Kalra
On Mon, Apr 19, 2021 at 05:55:34PM +0200, Jérôme Pouiller wrote:
> On Monday 19 April 2021 17:33:48 CEST Ashish Kalra wrote:
> >
> > Upon running sparse, "warning: symbol 'wfx_get_ps_timeout' was not declared.
> > Should it be static?" and "warning: symbol 'wfx_update_pm' was not declared.
> > Should it be static?" is brought to notice for this file. static keyword
> > should be added to prevent this warning. let's add it to make it cleaner and
> > silence the Sparse warning.
>
> Hi Ashish,
>
> Thank you for your contribution.
>
> It seems that this issue is already fixed by commit ce59858bbc10 "staging:
> wfx: make methods 'wfx_get_ps_timeout' and 'wfx_update_pm' static" (merged
> in master in version 5.8). Can you check you are working on the last tree?
>
>
> --
> Jérôme Pouiller
>
>
Thanks Jerome
It seems some sync issue with my source code.I will update to
latest and correct
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-19 16:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-19 15:33 [PATCH] staging: wfx: silence symbol 'wfx_get_ps_timeout' was not declared warning Ashish Kalra
2021-04-19 15:33 ` Ashish Kalra
2021-04-19 15:55 ` Jérôme Pouiller
2021-04-19 15:55 ` Jérôme Pouiller
2021-04-19 16:56 ` Ashish Kalra
2021-04-19 16:56 ` Ashish Kalra
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.