* [PATCH] clk: rockchip: Remove useless init of "grf" to -EPROBE_DEFER
@ 2017-01-06 16:31 ` Douglas Anderson
0 siblings, 0 replies; 4+ messages in thread
From: Douglas Anderson @ 2017-01-06 16:31 UTC (permalink / raw)
To: Heiko Stuebner
Cc: linux-rockchip, Douglas Anderson, mturquette, sboyd, linux-clk,
linux-arm-kernel, linux-kernel
When we used to defer setting the "grf" member to
rockchip_clk_get_grf() it was important to init the "grf" member to an
error value in rockchip_clk_init(). With recent changes, we now set
"grf" right in rockchip_clk_init() (two lines below the place where we
initted it). That makes the old init useless. Get rid of it.
Fixes: 6f339dc2719e ("clk: rockchip: lookup General Register Files in rockchip_clk_init")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/clk/rockchip/clk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c
index 3abcbf441cc5..fe1d393cf678 100644
--- a/drivers/clk/rockchip/clk.c
+++ b/drivers/clk/rockchip/clk.c
@@ -344,7 +344,6 @@ struct rockchip_clk_provider * __init rockchip_clk_init(struct device_node *np,
ctx->clk_data.clks = clk_table;
ctx->clk_data.clk_num = nr_clks;
ctx->cru_node = np;
- ctx->grf = ERR_PTR(-EPROBE_DEFER);
spin_lock_init(&ctx->lock);
ctx->grf = syscon_regmap_lookup_by_phandle(ctx->cru_node,
--
2.11.0.390.gc69c2f50cf-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] clk: rockchip: Remove useless init of "grf" to -EPROBE_DEFER
@ 2017-01-06 16:31 ` Douglas Anderson
0 siblings, 0 replies; 4+ messages in thread
From: Douglas Anderson @ 2017-01-06 16:31 UTC (permalink / raw)
To: linux-arm-kernel
When we used to defer setting the "grf" member to
rockchip_clk_get_grf() it was important to init the "grf" member to an
error value in rockchip_clk_init(). With recent changes, we now set
"grf" right in rockchip_clk_init() (two lines below the place where we
initted it). That makes the old init useless. Get rid of it.
Fixes: 6f339dc2719e ("clk: rockchip: lookup General Register Files in rockchip_clk_init")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/clk/rockchip/clk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c
index 3abcbf441cc5..fe1d393cf678 100644
--- a/drivers/clk/rockchip/clk.c
+++ b/drivers/clk/rockchip/clk.c
@@ -344,7 +344,6 @@ struct rockchip_clk_provider * __init rockchip_clk_init(struct device_node *np,
ctx->clk_data.clks = clk_table;
ctx->clk_data.clk_num = nr_clks;
ctx->cru_node = np;
- ctx->grf = ERR_PTR(-EPROBE_DEFER);
spin_lock_init(&ctx->lock);
ctx->grf = syscon_regmap_lookup_by_phandle(ctx->cru_node,
--
2.11.0.390.gc69c2f50cf-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: rockchip: Remove useless init of "grf" to -EPROBE_DEFER
2017-01-06 16:31 ` Douglas Anderson
@ 2017-01-06 19:32 ` Heiko Stuebner
-1 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2017-01-06 19:32 UTC (permalink / raw)
To: Douglas Anderson
Cc: linux-rockchip, mturquette, sboyd, linux-clk, linux-arm-kernel,
linux-kernel
Am Freitag, 6. Januar 2017, 08:31:01 CET schrieb Douglas Anderson:
> When we used to defer setting the "grf" member to
> rockchip_clk_get_grf() it was important to init the "grf" member to an
> error value in rockchip_clk_init(). With recent changes, we now set
> "grf" right in rockchip_clk_init() (two lines below the place where we
> initted it). That makes the old init useless. Get rid of it.
>
> Fixes: 6f339dc2719e ("clk: rockchip: lookup General Register Files in
> rockchip_clk_init") Signed-off-by: Douglas Anderson <dianders@chromium.org>
thanks for the catch, applied for 4.11
Thanks
Heiko
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] clk: rockchip: Remove useless init of "grf" to -EPROBE_DEFER
@ 2017-01-06 19:32 ` Heiko Stuebner
0 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2017-01-06 19:32 UTC (permalink / raw)
To: linux-arm-kernel
Am Freitag, 6. Januar 2017, 08:31:01 CET schrieb Douglas Anderson:
> When we used to defer setting the "grf" member to
> rockchip_clk_get_grf() it was important to init the "grf" member to an
> error value in rockchip_clk_init(). With recent changes, we now set
> "grf" right in rockchip_clk_init() (two lines below the place where we
> initted it). That makes the old init useless. Get rid of it.
>
> Fixes: 6f339dc2719e ("clk: rockchip: lookup General Register Files in
> rockchip_clk_init") Signed-off-by: Douglas Anderson <dianders@chromium.org>
thanks for the catch, applied for 4.11
Thanks
Heiko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-06 19:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-06 16:31 [PATCH] clk: rockchip: Remove useless init of "grf" to -EPROBE_DEFER Douglas Anderson
2017-01-06 16:31 ` Douglas Anderson
2017-01-06 19:32 ` Heiko Stuebner
2017-01-06 19:32 ` Heiko Stuebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.