* [PATCH] net: r6040: add in missing white space in error message text
@ 2016-09-12 12:08 Colin King
2016-09-12 13:04 ` Sergei Shtylyov
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-09-12 12:08 UTC (permalink / raw)
To: Florian Fainelli, netdev, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
A couple of dev_err messages span two lines and the literal
string is missing a white space between words. Add the white
space.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/rdc/r6040.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/rdc/r6040.c b/drivers/net/ethernet/rdc/r6040.c
index cb29ee2..5dc655b 100644
--- a/drivers/net/ethernet/rdc/r6040.c
+++ b/drivers/net/ethernet/rdc/r6040.c
@@ -1062,13 +1062,13 @@ static int r6040_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
/* this should always be supported */
err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
if (err) {
- dev_err(&pdev->dev, "32-bit PCI DMA addresses"
+ dev_err(&pdev->dev, "32-bit PCI DMA addresses "
"not supported by the card\n");
goto err_out_disable_dev;
}
err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
if (err) {
- dev_err(&pdev->dev, "32-bit PCI DMA addresses"
+ dev_err(&pdev->dev, "32-bit PCI DMA addresses "
"not supported by the card\n");
goto err_out_disable_dev;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: r6040: add in missing white space in error message text
2016-09-12 12:08 [PATCH] net: r6040: add in missing white space in error message text Colin King
@ 2016-09-12 13:04 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2016-09-12 13:04 UTC (permalink / raw)
To: Colin King, Florian Fainelli, netdev, linux-kernel
Hello.
On 9/12/2016 3:08 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> A couple of dev_err messages span two lines and the literal
> string is missing a white space between words. Add the white
> space.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/rdc/r6040.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/rdc/r6040.c b/drivers/net/ethernet/rdc/r6040.c
> index cb29ee2..5dc655b 100644
> --- a/drivers/net/ethernet/rdc/r6040.c
> +++ b/drivers/net/ethernet/rdc/r6040.c
> @@ -1062,13 +1062,13 @@ static int r6040_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> /* this should always be supported */
> err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
> if (err) {
> - dev_err(&pdev->dev, "32-bit PCI DMA addresses"
> + dev_err(&pdev->dev, "32-bit PCI DMA addresses "
> "not supported by the card\n");
> goto err_out_disable_dev;
> }
> err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
> if (err) {
> - dev_err(&pdev->dev, "32-bit PCI DMA addresses"
> + dev_err(&pdev->dev, "32-bit PCI DMA addresses "
> "not supported by the card\n");
> goto err_out_disable_dev;
> }
The message strings simply shouldn't be broken up, and checkpatch.pl knows
about that.
MBR, Sergei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-12 13:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-12 12:08 [PATCH] net: r6040: add in missing white space in error message text Colin King
2016-09-12 13:04 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.