All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: YueHaibing <yuehaibing@huawei.com>,
	lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
	tiwai@suse.de, daniel.baluta@nxp.com, arnd@arndb.de,
	tglx@linutronix.de, rdunlap@infradead.org
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] ASoC: SOF: Intel: Fix build error
Date: Mon, 2 Dec 2019 11:27:13 -0600	[thread overview]
Message-ID: <31733dff-0811-b2a4-6201-277d7c5ff619@linux.intel.com> (raw)
In-Reply-To: <20191127141649.5524-1-yuehaibing@huawei.com>



On 11/27/19 8:16 AM, YueHaibing wrote:
> If SND_INTEL_DSP_CONFIG is m and SND_SOC_SOF_PCI is y,
> building fails:
> 
> sound/soc/sof/sof-pci-dev.o: In function `sof_pci_probe':
> sof-pci-dev.c:(.text+0xb4): undefined reference to `snd_intel_dsp_driver_probe'
> 
> Select SND_INTEL_DSP_CONFIG to fix this.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 82d9d54a6c0e ("ALSA: hda: add Intel DSP configuration / probe code")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>   sound/soc/sof/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig
> index 71a0fc0..e0b04b5 100644
> --- a/sound/soc/sof/Kconfig
> +++ b/sound/soc/sof/Kconfig
> @@ -14,6 +14,7 @@ config SND_SOC_SOF_PCI
>   	depends on PCI
>   	select SND_SOC_SOF
>   	select SND_SOC_ACPI if ACPI
> +	select SND_INTEL_DSP_CONFIG

Thanks for the report. This looks like a valid issue but I don't think 
the fix is in the right place, we moved all Intel-specific stuff to 
sound/soc/sof/Intel.

In addition I don't get how this can happen in the first place, we have
this statement

config SND_SOC_SOF_INTEL_PCI
	def_tristate SND_SOC_SOF_PCI

Can you share the config that's broken? Thanks!

WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: YueHaibing <yuehaibing@huawei.com>,
	lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
	tiwai@suse.de, daniel.baluta@nxp.com, arnd@arndb.de,
	tglx@linutronix.de, rdunlap@infradead.org
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] ASoC: SOF: Intel: Fix build error
Date: Mon, 2 Dec 2019 11:27:13 -0600	[thread overview]
Message-ID: <31733dff-0811-b2a4-6201-277d7c5ff619@linux.intel.com> (raw)
In-Reply-To: <20191127141649.5524-1-yuehaibing@huawei.com>



On 11/27/19 8:16 AM, YueHaibing wrote:
> If SND_INTEL_DSP_CONFIG is m and SND_SOC_SOF_PCI is y,
> building fails:
> 
> sound/soc/sof/sof-pci-dev.o: In function `sof_pci_probe':
> sof-pci-dev.c:(.text+0xb4): undefined reference to `snd_intel_dsp_driver_probe'
> 
> Select SND_INTEL_DSP_CONFIG to fix this.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 82d9d54a6c0e ("ALSA: hda: add Intel DSP configuration / probe code")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>   sound/soc/sof/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig
> index 71a0fc0..e0b04b5 100644
> --- a/sound/soc/sof/Kconfig
> +++ b/sound/soc/sof/Kconfig
> @@ -14,6 +14,7 @@ config SND_SOC_SOF_PCI
>   	depends on PCI
>   	select SND_SOC_SOF
>   	select SND_SOC_ACPI if ACPI
> +	select SND_INTEL_DSP_CONFIG

Thanks for the report. This looks like a valid issue but I don't think 
the fix is in the right place, we moved all Intel-specific stuff to 
sound/soc/sof/Intel.

In addition I don't get how this can happen in the first place, we have
this statement

config SND_SOC_SOF_INTEL_PCI
	def_tristate SND_SOC_SOF_PCI

Can you share the config that's broken? Thanks!
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2019-12-02 17:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27 14:16 [PATCH] ASoC: SOF: Intel: Fix build error YueHaibing
2019-11-27 14:16 ` [alsa-devel] " YueHaibing
2019-12-02 17:27 ` Pierre-Louis Bossart [this message]
2019-12-02 17:27   ` Pierre-Louis Bossart
2019-12-26  6:26   ` Yuehaibing
2019-12-26  6:26     ` Yuehaibing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31733dff-0811-b2a4-6201-277d7c5ff619@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=rdunlap@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tiwai@suse.de \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.