From: Bart Van Assche <bvanassche@acm.org>
To: Avri Altman <Avri.Altman@wdc.com>, Ed Tsai <ed.tsai@mediatek.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
"peter.wang@mediatek.com" <peter.wang@mediatek.com>,
"chun-hung.wu@mediatek.com" <chun-hung.wu@mediatek.com>,
"alice.chao@mediatek.com" <alice.chao@mediatek.com>,
"powen.kao@mediatek.com" <powen.kao@mediatek.com>,
"naomi.chu@mediatek.com" <naomi.chu@mediatek.com>,
"wsd_upstream@mediatek.com" <wsd_upstream@mediatek.com>
Subject: Re: [PATCH 2/2] ufs: don't use the fair tag sharings
Date: Wed, 10 May 2023 08:56:16 -0700 [thread overview]
Message-ID: <31af3339-d90e-f0bd-4c9e-0da9f8728ce4@acm.org> (raw)
In-Reply-To: <BL0PR04MB6564242D93EE6826CF1F6747FC779@BL0PR04MB6564.namprd04.prod.outlook.com>
On 5/9/23 22:21, Avri Altman wrote:
> Why it was needed to invent a new flag instead of just clear
> BLK_MQ_F_TAG_QUEUE_SHARED?
Hi Avri,
The meaning of BLK_MQ_F_TAG_QUEUE_SHARED is "the tag set is shared
across multiple request queues". Clearing BLK_MQ_F_TAG_QUEUE_SHARED if
the tag set is shared would be wrong: it would break all the code
outside the tag allocation code that tests this flag.
Thanks,
Bart.
next prev parent reply other threads:[~2023-05-10 15:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 6:52 [PATCH 0/2] block: improve the share tag set performance Ed Tsai
2023-05-09 6:52 ` [PATCH 1/2] block: make the fair sharing of tag configurable Ed Tsai
2023-05-09 21:33 ` kernel test robot
2023-05-11 15:33 ` Christoph Hellwig
2023-05-22 5:30 ` kernel test robot
2023-05-09 6:52 ` [PATCH 2/2] ufs: don't use the fair tag sharings Ed Tsai
2023-05-09 8:03 ` Avri Altman
2023-05-09 14:04 ` Bart Van Assche
2023-05-09 16:19 ` Avri Altman
2023-05-09 16:30 ` Bart Van Assche
2023-05-10 5:21 ` Avri Altman
2023-05-10 15:56 ` Bart Van Assche [this message]
2023-05-11 15:34 ` Christoph Hellwig
2023-05-11 15:38 ` Bart Van Assche
2023-05-12 14:02 ` Christoph Hellwig
2023-05-12 18:12 ` Bart Van Assche
2023-05-13 3:09 ` Yu Kuai
2023-05-16 15:12 ` Bart Van Assche
2023-05-17 7:49 ` Yu Kuai
2023-05-17 18:23 ` Bart Van Assche
2023-05-18 1:49 ` Yu Kuai
2023-05-18 2:23 ` Bart Van Assche
2023-05-18 7:55 ` Yu Kuai
2023-06-13 14:07 ` Bart Van Assche
2023-06-14 1:58 ` Yu Kuai
2023-05-10 22:56 ` [PATCH 0/2] block: improve the share tag set performance Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31af3339-d90e-f0bd-4c9e-0da9f8728ce4@acm.org \
--to=bvanassche@acm.org \
--cc=Avri.Altman@wdc.com \
--cc=alice.chao@mediatek.com \
--cc=axboe@kernel.dk \
--cc=chun-hung.wu@mediatek.com \
--cc=ed.tsai@mediatek.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=naomi.chu@mediatek.com \
--cc=peter.wang@mediatek.com \
--cc=powen.kao@mediatek.com \
--cc=stanley.chu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.