From: Christoph Hellwig <hch@infradead.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Ed Tsai <ed.tsai@mediatek.com>,
axboe@kernel.dk, linux-block@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
martin.petersen@oracle.com, stanley.chu@mediatek.com,
peter.wang@mediatek.com, chun-hung.wu@mediatek.com,
alice.chao@mediatek.com, powen.kao@mediatek.com,
naomi.chu@mediatek.com, wsd_upstream@mediatek.com
Subject: Re: [PATCH 2/2] ufs: don't use the fair tag sharings
Date: Fri, 12 May 2023 07:02:15 -0700 [thread overview]
Message-ID: <ZF5G5ztMng8Xbd1W@infradead.org> (raw)
In-Reply-To: <aa9af9ae-62a4-6469-244c-b5d9106bb044@acm.org>
On Thu, May 11, 2023 at 08:38:04AM -0700, Bart Van Assche wrote:
> For which devices is the fair sharing algorithm useful? As far as I know the
> legacy block layer did not have an equivalent of the fair sharing algorithm
> and I'm not aware of any complaints about the legacy block layer regarding
> to fairness. This is why I proposed in January to remove the fair sharing
> code entirely. See also https://lore.kernel.org/linux-block/20230103195337.158625-1-bvanassche@acm.org/.
Because the old code did not do tag allocation itself? Either way I
don't think a "I'll opt out for a random driver" is the proper approach
when you think it's not needed. Especially not without any data
explaining why just that driver is a special snowflake.
next prev parent reply other threads:[~2023-05-12 14:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 6:52 [PATCH 0/2] block: improve the share tag set performance Ed Tsai
2023-05-09 6:52 ` [PATCH 1/2] block: make the fair sharing of tag configurable Ed Tsai
2023-05-09 21:33 ` kernel test robot
2023-05-11 15:33 ` Christoph Hellwig
2023-05-22 5:30 ` kernel test robot
2023-05-09 6:52 ` [PATCH 2/2] ufs: don't use the fair tag sharings Ed Tsai
2023-05-09 8:03 ` Avri Altman
2023-05-09 14:04 ` Bart Van Assche
2023-05-09 16:19 ` Avri Altman
2023-05-09 16:30 ` Bart Van Assche
2023-05-10 5:21 ` Avri Altman
2023-05-10 15:56 ` Bart Van Assche
2023-05-11 15:34 ` Christoph Hellwig
2023-05-11 15:38 ` Bart Van Assche
2023-05-12 14:02 ` Christoph Hellwig [this message]
2023-05-12 18:12 ` Bart Van Assche
2023-05-13 3:09 ` Yu Kuai
2023-05-16 15:12 ` Bart Van Assche
2023-05-17 7:49 ` Yu Kuai
2023-05-17 18:23 ` Bart Van Assche
2023-05-18 1:49 ` Yu Kuai
2023-05-18 2:23 ` Bart Van Assche
2023-05-18 7:55 ` Yu Kuai
2023-06-13 14:07 ` Bart Van Assche
2023-06-14 1:58 ` Yu Kuai
2023-05-10 22:56 ` [PATCH 0/2] block: improve the share tag set performance Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZF5G5ztMng8Xbd1W@infradead.org \
--to=hch@infradead.org \
--cc=alice.chao@mediatek.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=chun-hung.wu@mediatek.com \
--cc=ed.tsai@mediatek.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=naomi.chu@mediatek.com \
--cc=peter.wang@mediatek.com \
--cc=powen.kao@mediatek.com \
--cc=stanley.chu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.