All of lore.kernel.org
 help / color / mirror / Atom feed
From: elfring@users.sourceforge.net (SF Markus Elfring)
To: cocci@systeme.lip6.fr
Subject: [Cocci] “coccicheck failed” during parallel program runs
Date: Thu, 18 Aug 2016 15:13:09 +0200	[thread overview]
Message-ID: <31c3215d-ce79-a19a-53b4-2869ca1b708b@users.sourceforge.net> (raw)
In-Reply-To: <alpine.DEB.2.10.1608180823510.2985@hadrien>

>>> It seems that make coccicheck interprets anything being written on
>>> standard error as a fatal error.
>>
>> How do you come to this conclusion?
> 
> Because the message in question used to be sent to standard output,
> for many years, and no one was complaining.

Is it interesting to look on circumstances and why it was tolerated?

Did the expectations evolve a bit more for this software in the meantime?


> I don't see why printing a warning message to stderr would change the
> return code only in the parallel case.

I would also wonder about such a side effect.

Can a failed call of a function like "printf" in the OCaml source code
result in a questionable return value which will become the discussed
program exit status?


By the way:
This observation depends on the result from the following statements.

?
SPATCH="`which ${SPATCH:=spatch}`"
?
$SPATCH --help | grep "\-\-jobs" > /dev/null && USE_JOBS="yes"
?


Would an approach like the following help here?


Update candidate "scripts/coccicheck":
?
run_cmd_parmap() {
?
	$@ 2>$DEBUG_FILE
	if [[ $? -ne 0 ]]; then
		COMMAND_RESULT=$?
		echo "coccicheck failed"
		exit $COMMAND_RESULT
	fi
}
?

Regards,
Markus

      reply	other threads:[~2016-08-18 13:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18  0:34 [Cocci] Coccinelle issues with Linux kernel 4.8-rc1 Chegondi, Harish
2016-08-18  2:32 ` Julia Lawall
2016-08-26  0:44   ` Chegondi, Harish
2016-08-26  0:54     ` Julia Lawall
2016-08-18  2:37 ` Julia Lawall
2016-08-18  7:06 ` [Cocci] “coccicheck failed” during parallel program runs SF Markus Elfring
2016-08-18  9:00   ` Julia Lawall
2016-08-18 11:34     ` SF Markus Elfring
2016-08-18 12:26       ` Julia Lawall
2016-08-18 13:13         ` SF Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31c3215d-ce79-a19a-53b4-2869ca1b708b@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.