All of lore.kernel.org
 help / color / mirror / Atom feed
From: elfring@users.sourceforge.net (SF Markus Elfring)
To: cocci@systeme.lip6.fr
Subject: [Cocci] “coccicheck failed” during parallel program runs
Date: Thu, 18 Aug 2016 13:34:52 +0200	[thread overview]
Message-ID: <58c55f2c-6dd3-e4df-cb87-5a2079b76917@users.sourceforge.net> (raw)
In-Reply-To: <alpine.DEB.2.10.1608180458020.3107@hadrien>

> It seems that make coccicheck interprets anything being written on
> standard error as a fatal error.

How do you come to this conclusion?


> This seems like a strange point of view,

I would agree ?


> as Coccinelle needs somewhere to print warnings that the user may also
> find useful.

This is usually fine.

But I am more concerned about the safe handling for the program exit status.


Excerpt from scripts/coccicheck:
?
run_cmd_parmap() {
?
	$@ 2>$DEBUG_FILE
	if [[ $? -ne 0 ]]; then
		echo "coccicheck failed"
		exit $?
	fi
}
?


Would you like to take another look at the returned exit code?


> But I have changed Coccinelle such that it prints this particular warning

Will the message reformatting around the information "? with comm_assoc iso"
be really sufficient?



> in a different way that will cause it to disappear when
> the option --very-quiet is used.

Thanks for another bit of fine-tuning in your software.

Regards,
Markus

  reply	other threads:[~2016-08-18 11:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18  0:34 [Cocci] Coccinelle issues with Linux kernel 4.8-rc1 Chegondi, Harish
2016-08-18  2:32 ` Julia Lawall
2016-08-26  0:44   ` Chegondi, Harish
2016-08-26  0:54     ` Julia Lawall
2016-08-18  2:37 ` Julia Lawall
2016-08-18  7:06 ` [Cocci] “coccicheck failed” during parallel program runs SF Markus Elfring
2016-08-18  9:00   ` Julia Lawall
2016-08-18 11:34     ` SF Markus Elfring [this message]
2016-08-18 12:26       ` Julia Lawall
2016-08-18 13:13         ` SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58c55f2c-6dd3-e4df-cb87-5a2079b76917@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.