* [PATCH qemu] aspeed: add support for a witherspoon-bmc board with 128MB flash chip
@ 2019-05-16 16:11 Cédric Le Goater
2019-05-16 23:00 ` Andrew Jeffery
0 siblings, 1 reply; 9+ messages in thread
From: Cédric Le Goater @ 2019-05-16 16:11 UTC (permalink / raw)
To: openbmc
Cc: Joel Stanley, Andrew Jeffery, Adriana Kobylak, Cédric Le Goater
Some Witherspoon boards are shipped with a mt25ql01g flash chip
holding the BMC firmware.
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
It helps in tracking https://github.com/openbmc/u-boot/issues/18
hw/arm/aspeed.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index efc97df00de0..f26215ab5524 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -441,6 +441,17 @@ static const AspeedBoardConfig aspeed_boards[] = {
.i2c_init = witherspoon_bmc_i2c_init,
.ram = 512 * MiB,
.num_cpus = 1,
+ }, {
+ .name = MACHINE_TYPE_NAME("witherspoon128-bmc"),
+ .desc = "OpenPOWER Witherspoon128 BMC (ARM1176)",
+ .soc_name = "ast2500-a1",
+ .hw_strap1 = WITHERSPOON_BMC_HW_STRAP1,
+ .fmc_model = "mt25ql01g",
+ .spi_model = "mx66l1g45g",
+ .num_cs = 2,
+ .i2c_init = witherspoon_bmc_i2c_init,
+ .ram = 512 * MiB,
+ .num_cpus = 1,
}, {
.name = MACHINE_TYPE_NAME("ast2600-evb"),
.desc = "Aspeed AST2600 EVB (Cortex A7)",
--
2.20.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH qemu] aspeed: add support for a witherspoon-bmc board with 128MB flash chip
2019-05-16 16:11 [PATCH qemu] aspeed: add support for a witherspoon-bmc board with 128MB flash chip Cédric Le Goater
@ 2019-05-16 23:00 ` Andrew Jeffery
2019-05-17 6:26 ` Cédric Le Goater
0 siblings, 1 reply; 9+ messages in thread
From: Andrew Jeffery @ 2019-05-16 23:00 UTC (permalink / raw)
To: Cédric Le Goater, openbmc; +Cc: Joel Stanley, Adriana Kobylak
On Fri, 17 May 2019, at 01:42, Cédric Le Goater wrote:
> Some Witherspoon boards are shipped with a mt25ql01g flash chip
> holding the BMC firmware.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
"witherspoon128-bmc" is not very creative, but I can't blame you for that :D
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
> ---
>
> It helps in tracking https://github.com/openbmc/u-boot/issues/18
>
> hw/arm/aspeed.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index efc97df00de0..f26215ab5524 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -441,6 +441,17 @@ static const AspeedBoardConfig aspeed_boards[] = {
> .i2c_init = witherspoon_bmc_i2c_init,
> .ram = 512 * MiB,
> .num_cpus = 1,
> + }, {
> + .name = MACHINE_TYPE_NAME("witherspoon128-bmc"),
> + .desc = "OpenPOWER Witherspoon128 BMC (ARM1176)",
> + .soc_name = "ast2500-a1",
> + .hw_strap1 = WITHERSPOON_BMC_HW_STRAP1,
> + .fmc_model = "mt25ql01g",
> + .spi_model = "mx66l1g45g",
> + .num_cs = 2,
> + .i2c_init = witherspoon_bmc_i2c_init,
> + .ram = 512 * MiB,
> + .num_cpus = 1,
> }, {
> .name = MACHINE_TYPE_NAME("ast2600-evb"),
> .desc = "Aspeed AST2600 EVB (Cortex A7)",
> --
> 2.20.1
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH qemu] aspeed: add support for a witherspoon-bmc board with 128MB flash chip
2019-05-16 23:00 ` Andrew Jeffery
@ 2019-05-17 6:26 ` Cédric Le Goater
2019-05-20 0:56 ` Andrew Jeffery
0 siblings, 1 reply; 9+ messages in thread
From: Cédric Le Goater @ 2019-05-17 6:26 UTC (permalink / raw)
To: Andrew Jeffery, openbmc; +Cc: Joel Stanley, Adriana Kobylak
On 5/17/19 1:00 AM, Andrew Jeffery wrote:
>
>
> On Fri, 17 May 2019, at 01:42, Cédric Le Goater wrote:
>> Some Witherspoon boards are shipped with a mt25ql01g flash chip
>> holding the BMC firmware.
>>
>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>
> "witherspoon128-bmc" is not very creative, but I can't blame you for that :D
he.
Should we introduce a machine option to set the model name of the
FMC flash chip ? I think I tried that in the past but at the block
level and mainline did not like it. But we could try at the machine
level.
Anyhow, it's a good way to debug flash issues on real HW.
> Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
>
>> ---
>>
>> It helps in tracking https://github.com/openbmc/u-boot/issues/18
>>
>> hw/arm/aspeed.c | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
>> index efc97df00de0..f26215ab5524 100644
>> --- a/hw/arm/aspeed.c
>> +++ b/hw/arm/aspeed.c
>> @@ -441,6 +441,17 @@ static const AspeedBoardConfig aspeed_boards[] = {
>> .i2c_init = witherspoon_bmc_i2c_init,
>> .ram = 512 * MiB,
>> .num_cpus = 1,
>> + }, {
>> + .name = MACHINE_TYPE_NAME("witherspoon128-bmc"),
>> + .desc = "OpenPOWER Witherspoon128 BMC (ARM1176)",
>> + .soc_name = "ast2500-a1",
>> + .hw_strap1 = WITHERSPOON_BMC_HW_STRAP1,
>> + .fmc_model = "mt25ql01g",
>> + .spi_model = "mx66l1g45g",
>> + .num_cs = 2,
>> + .i2c_init = witherspoon_bmc_i2c_init,
>> + .ram = 512 * MiB,
>> + .num_cpus = 1,
>> }, {
>> .name = MACHINE_TYPE_NAME("ast2600-evb"),
>> .desc = "Aspeed AST2600 EVB (Cortex A7)",
>> --
>> 2.20.1
>>
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH qemu] aspeed: add support for a witherspoon-bmc board with 128MB flash chip
2019-05-17 6:26 ` Cédric Le Goater
@ 2019-05-20 0:56 ` Andrew Jeffery
2019-05-22 5:37 ` Joel Stanley
0 siblings, 1 reply; 9+ messages in thread
From: Andrew Jeffery @ 2019-05-20 0:56 UTC (permalink / raw)
To: Cédric Le Goater, openbmc; +Cc: Joel Stanley, Adriana Kobylak
On Fri, 17 May 2019, at 15:56, Cédric Le Goater wrote:
> On 5/17/19 1:00 AM, Andrew Jeffery wrote:
> >
> >
> > On Fri, 17 May 2019, at 01:42, Cédric Le Goater wrote:
> >> Some Witherspoon boards are shipped with a mt25ql01g flash chip
> >> holding the BMC firmware.
> >>
> >> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> >
> > "witherspoon128-bmc" is not very creative, but I can't blame you for that :D
>
> he.
>
> Should we introduce a machine option to set the model name of the
> FMC flash chip ? I think I tried that in the past but at the block
> level and mainline did not like it. But we could try at the machine
> level.
>
> Anyhow, it's a good way to debug flash issues on real HW.
Eh. I'm not fussed by a new machine. I wouldn't do anything for the moment.
>
>
> > Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
> >
> >> ---
> >>
> >> It helps in tracking https://github.com/openbmc/u-boot/issues/18
> >>
> >> hw/arm/aspeed.c | 11 +++++++++++
> >> 1 file changed, 11 insertions(+)
> >>
> >> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> >> index efc97df00de0..f26215ab5524 100644
> >> --- a/hw/arm/aspeed.c
> >> +++ b/hw/arm/aspeed.c
> >> @@ -441,6 +441,17 @@ static const AspeedBoardConfig aspeed_boards[] = {
> >> .i2c_init = witherspoon_bmc_i2c_init,
> >> .ram = 512 * MiB,
> >> .num_cpus = 1,
> >> + }, {
> >> + .name = MACHINE_TYPE_NAME("witherspoon128-bmc"),
> >> + .desc = "OpenPOWER Witherspoon128 BMC (ARM1176)",
> >> + .soc_name = "ast2500-a1",
> >> + .hw_strap1 = WITHERSPOON_BMC_HW_STRAP1,
> >> + .fmc_model = "mt25ql01g",
> >> + .spi_model = "mx66l1g45g",
> >> + .num_cs = 2,
> >> + .i2c_init = witherspoon_bmc_i2c_init,
> >> + .ram = 512 * MiB,
> >> + .num_cpus = 1,
> >> }, {
> >> .name = MACHINE_TYPE_NAME("ast2600-evb"),
> >> .desc = "Aspeed AST2600 EVB (Cortex A7)",
> >> --
> >> 2.20.1
> >>
> >>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH qemu] aspeed: add support for a witherspoon-bmc board with 128MB flash chip
2019-05-20 0:56 ` Andrew Jeffery
@ 2019-05-22 5:37 ` Joel Stanley
2019-05-22 6:14 ` Cédric Le Goater
0 siblings, 1 reply; 9+ messages in thread
From: Joel Stanley @ 2019-05-22 5:37 UTC (permalink / raw)
To: Andrew Jeffery; +Cc: Cédric Le Goater, OpenBMC Maillist, Adriana Kobylak
On Mon, 20 May 2019 at 00:56, Andrew Jeffery <andrew@aj.id.au> wrote:
>
>
>
> On Fri, 17 May 2019, at 15:56, Cédric Le Goater wrote:
> > On 5/17/19 1:00 AM, Andrew Jeffery wrote:
> > >
> > >
> > > On Fri, 17 May 2019, at 01:42, Cédric Le Goater wrote:
> > >> Some Witherspoon boards are shipped with a mt25ql01g flash chip
> > >> holding the BMC firmware.
> > >>
> > >> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> > >
> > > "witherspoon128-bmc" is not very creative, but I can't blame you for that :D
> >
> > he.
> >
> > Should we introduce a machine option to set the model name of the
> > FMC flash chip ? I think I tried that in the past but at the block
> > level and mainline did not like it. But we could try at the machine
> > level.
> >
> > Anyhow, it's a good way to debug flash issues on real HW.
>
> Eh. I'm not fussed by a new machine. I wouldn't do anything for the moment.
We could instead add a swift machine with the 128MB NOR. When we get a
model for the SD/MMC it would use that too.
Cheers,
Joel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH qemu] aspeed: add support for a witherspoon-bmc board with 128MB flash chip
2019-05-22 5:37 ` Joel Stanley
@ 2019-05-22 6:14 ` Cédric Le Goater
2019-05-22 6:16 ` Joel Stanley
0 siblings, 1 reply; 9+ messages in thread
From: Cédric Le Goater @ 2019-05-22 6:14 UTC (permalink / raw)
To: Joel Stanley, Andrew Jeffery; +Cc: OpenBMC Maillist, Adriana Kobylak
On 5/22/19 7:37 AM, Joel Stanley wrote:
> On Mon, 20 May 2019 at 00:56, Andrew Jeffery <andrew@aj.id.au> wrote:
>>
>>
>>
>> On Fri, 17 May 2019, at 15:56, Cédric Le Goater wrote:
>>> On 5/17/19 1:00 AM, Andrew Jeffery wrote:
>>>>
>>>>
>>>> On Fri, 17 May 2019, at 01:42, Cédric Le Goater wrote:
>>>>> Some Witherspoon boards are shipped with a mt25ql01g flash chip
>>>>> holding the BMC firmware.
>>>>>
>>>>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>>>>
>>>> "witherspoon128-bmc" is not very creative, but I can't blame you for that :D
>>>
>>> he.
>>>
>>> Should we introduce a machine option to set the model name of the
>>> FMC flash chip ? I think I tried that in the past but at the block
>>> level and mainline did not like it. But we could try at the machine
>>> level.
>>>
>>> Anyhow, it's a good way to debug flash issues on real HW.
>>
>> Eh. I'm not fussed by a new machine. I wouldn't do anything for the moment.
>
> We could instead add a swift machine with the 128MB NOR. When we get a
> model for the SD/MMC it would use that too.
OK. That's a good direction.
C.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH qemu] aspeed: add support for a witherspoon-bmc board with 128MB flash chip
2019-05-22 6:14 ` Cédric Le Goater
@ 2019-05-22 6:16 ` Joel Stanley
2019-05-22 21:58 ` Adriana Kobylak
0 siblings, 1 reply; 9+ messages in thread
From: Joel Stanley @ 2019-05-22 6:16 UTC (permalink / raw)
To: Cédric Le Goater; +Cc: Andrew Jeffery, OpenBMC Maillist, Adriana Kobylak
On Wed, 22 May 2019 at 06:14, Cédric Le Goater <clg@kaod.org> wrote:
>
> On 5/22/19 7:37 AM, Joel Stanley wrote:
> > On Mon, 20 May 2019 at 00:56, Andrew Jeffery <andrew@aj.id.au> wrote:
> >>
> >>
> >>
> >> On Fri, 17 May 2019, at 15:56, Cédric Le Goater wrote:
> >>> On 5/17/19 1:00 AM, Andrew Jeffery wrote:
> >>>>
> >>>>
> >>>> On Fri, 17 May 2019, at 01:42, Cédric Le Goater wrote:
> >>>>> Some Witherspoon boards are shipped with a mt25ql01g flash chip
> >>>>> holding the BMC firmware.
> >>>>>
> >>>>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> >>>>
> >>>> "witherspoon128-bmc" is not very creative, but I can't blame you for that :D
> >>>
> >>> he.
> >>>
> >>> Should we introduce a machine option to set the model name of the
> >>> FMC flash chip ? I think I tried that in the past but at the block
> >>> level and mainline did not like it. But we could try at the machine
> >>> level.
> >>>
> >>> Anyhow, it's a good way to debug flash issues on real HW.
> >>
> >> Eh. I'm not fussed by a new machine. I wouldn't do anything for the moment.
> >
> > We could instead add a swift machine with the 128MB NOR. When we get a
> > model for the SD/MMC it would use that too.
>
> OK. That's a good direction.
Adriana, could you take this on?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH qemu] aspeed: add support for a witherspoon-bmc board with 128MB flash chip
2019-05-22 6:16 ` Joel Stanley
@ 2019-05-22 21:58 ` Adriana Kobylak
2019-05-23 6:11 ` Cédric Le Goater
0 siblings, 1 reply; 9+ messages in thread
From: Adriana Kobylak @ 2019-05-22 21:58 UTC (permalink / raw)
To: Joel Stanley
Cc: Cédric Le Goater, Andrew Jeffery, OpenBMC Maillist,
Adriana Kobylak, openbmc
>> >>> Should we introduce a machine option to set the model name of the
>> >>> FMC flash chip ? I think I tried that in the past but at the block
>> >>> level and mainline did not like it. But we could try at the machine
>> >>> level.
>> >>>
>> >>> Anyhow, it's a good way to debug flash issues on real HW.
>> >>
>> >> Eh. I'm not fussed by a new machine. I wouldn't do anything for the moment.
>> >
>> > We could instead add a swift machine with the 128MB NOR. When we get a
>> > model for the SD/MMC it would use that too.
>>
>> OK. That's a good direction.
>
> Adriana, could you take this on?
Yeah, was thinking about it when Cedric sent out this patch, but since
theoretically the witherspoon128-bmc model could be used with a swift
image, I put it to the side. But now that you mention it, yeah we can
add the SD/MMC to it later so that'd be valuable to have in a qemu
model. Will send a patch based on the 128 for a new swift bmc to start
with.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH qemu] aspeed: add support for a witherspoon-bmc board with 128MB flash chip
2019-05-22 21:58 ` Adriana Kobylak
@ 2019-05-23 6:11 ` Cédric Le Goater
0 siblings, 0 replies; 9+ messages in thread
From: Cédric Le Goater @ 2019-05-23 6:11 UTC (permalink / raw)
To: Adriana Kobylak, Joel Stanley
Cc: Andrew Jeffery, OpenBMC Maillist, Adriana Kobylak, openbmc
On 5/22/19 11:58 PM, Adriana Kobylak wrote:
>
>>> >>> Should we introduce a machine option to set the model name of the
>>> >>> FMC flash chip ? I think I tried that in the past but at the block
>>> >>> level and mainline did not like it. But we could try at the machine
>>> >>> level.
>>> >>>
>>> >>> Anyhow, it's a good way to debug flash issues on real HW.
>>> >>
>>> >> Eh. I'm not fussed by a new machine. I wouldn't do anything for the moment.
>>> >
>>> > We could instead add a swift machine with the 128MB NOR. When we get a
>>> > model for the SD/MMC it would use that too.
>>>
>>> OK. That's a good direction.
>>
>> Adriana, could you take this on?
>
> Yeah, was thinking about it when Cedric sent out this patch, but since theoretically the witherspoon128-bmc model could be used with a swift image, I put it to the side. But now that you mention it, yeah we can add the SD/MMC to it later so that'd be valuable to have in a qemu model. Will send a patch based on the 128 for a new swift bmc to start with.
Yes. I suppose this machine will have a different layout of I2C devices also,
different HW strapping, etc.
Thanks,
C.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-05-23 8:39 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-16 16:11 [PATCH qemu] aspeed: add support for a witherspoon-bmc board with 128MB flash chip Cédric Le Goater
2019-05-16 23:00 ` Andrew Jeffery
2019-05-17 6:26 ` Cédric Le Goater
2019-05-20 0:56 ` Andrew Jeffery
2019-05-22 5:37 ` Joel Stanley
2019-05-22 6:14 ` Cédric Le Goater
2019-05-22 6:16 ` Joel Stanley
2019-05-22 21:58 ` Adriana Kobylak
2019-05-23 6:11 ` Cédric Le Goater
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.