All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net/ixgbe: fix build on gcc 4.5.1
@ 2017-11-06 10:54 Radu Nicolau
  2017-11-06 11:14 ` Thomas Monjalon
  2017-11-06 11:36 ` [PATCH v2] " Radu Nicolau
  0 siblings, 2 replies; 4+ messages in thread
From: Radu Nicolau @ 2017-11-06 10:54 UTC (permalink / raw)
  To: dev
  Cc: thomas, konstantin.ananyev, bruce.richardson, ferruh.yigit,
	wenzhuo.lu, michael.j.glynn, Radu Nicolau

Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec")

Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
 drivers/net/ixgbe/ixgbe_ipsec.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c
index 99c0a73..105da11 100644
--- a/drivers/net/ixgbe/ixgbe_ipsec.c
+++ b/drivers/net/ixgbe/ixgbe_ipsec.c
@@ -576,48 +576,48 @@ ixgbe_crypto_capabilities_get(void *device __rte_unused)
 		{ /* IPsec Inline Crypto ESP Transport Egress */
 			.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
 			.protocol = RTE_SECURITY_PROTOCOL_IPSEC,
-			.ipsec = {
+			{.ipsec = {
 				.proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP,
 				.mode = RTE_SECURITY_IPSEC_SA_MODE_TRANSPORT,
 				.direction = RTE_SECURITY_IPSEC_SA_DIR_EGRESS,
 				.options = { 0 }
-			},
+			} },
 			.crypto_capabilities = aes_gcm_gmac_crypto_capabilities,
 			.ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
 		},
 		{ /* IPsec Inline Crypto ESP Transport Ingress */
 			.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
 			.protocol = RTE_SECURITY_PROTOCOL_IPSEC,
-			.ipsec = {
+			{.ipsec = {
 				.proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP,
 				.mode = RTE_SECURITY_IPSEC_SA_MODE_TRANSPORT,
 				.direction = RTE_SECURITY_IPSEC_SA_DIR_INGRESS,
 				.options = { 0 }
-			},
+			} },
 			.crypto_capabilities = aes_gcm_gmac_crypto_capabilities,
 			.ol_flags = 0
 		},
 		{ /* IPsec Inline Crypto ESP Tunnel Egress */
 			.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
 			.protocol = RTE_SECURITY_PROTOCOL_IPSEC,
-			.ipsec = {
+			{.ipsec = {
 				.proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP,
 				.mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL,
 				.direction = RTE_SECURITY_IPSEC_SA_DIR_EGRESS,
 				.options = { 0 }
-			},
+			} },
 			.crypto_capabilities = aes_gcm_gmac_crypto_capabilities,
 			.ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
 		},
 		{ /* IPsec Inline Crypto ESP Tunnel Ingress */
 			.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
 			.protocol = RTE_SECURITY_PROTOCOL_IPSEC,
-			.ipsec = {
+			{.ipsec = {
 				.proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP,
 				.mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL,
 				.direction = RTE_SECURITY_IPSEC_SA_DIR_INGRESS,
 				.options = { 0 }
-			},
+			} },
 			.crypto_capabilities = aes_gcm_gmac_crypto_capabilities,
 			.ol_flags = 0
 		},
-- 
2.7.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] net/ixgbe: fix build on gcc 4.5.1
  2017-11-06 10:54 [PATCH] net/ixgbe: fix build on gcc 4.5.1 Radu Nicolau
@ 2017-11-06 11:14 ` Thomas Monjalon
  2017-11-06 11:36 ` [PATCH v2] " Radu Nicolau
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2017-11-06 11:14 UTC (permalink / raw)
  To: Radu Nicolau
  Cc: dev, konstantin.ananyev, bruce.richardson, ferruh.yigit,
	wenzhuo.lu, michael.j.glynn

06/11/2017 11:54, Radu Nicolau:
> Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec")
> 
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>

Please show the compilation error in the commit message.
It is also better to briefly explain what was wrong.
Thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH v2] net/ixgbe: fix build on gcc 4.5.1
  2017-11-06 10:54 [PATCH] net/ixgbe: fix build on gcc 4.5.1 Radu Nicolau
  2017-11-06 11:14 ` Thomas Monjalon
@ 2017-11-06 11:36 ` Radu Nicolau
  2017-11-07  1:24   ` Thomas Monjalon
  1 sibling, 1 reply; 4+ messages in thread
From: Radu Nicolau @ 2017-11-06 11:36 UTC (permalink / raw)
  To: dev
  Cc: thomas, konstantin.ananyev, bruce.richardson, ferruh.yigit,
	wenzhuo.lu, michael.j.glynn, Radu Nicolau

Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec")

On SUSE11 with gcc 4.5.1 the following build error occurred,
most likely because of improper handling of annonymous unions:

DPDK/drivers/net/ixgbe/ixgbe_ipsec.c:579:4:
error: unknown field ‘ipsec’ specified in initializer
compilation terminated due to -Wfatal-errors.

Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
v2: additional info added in the commit message.


 drivers/net/ixgbe/ixgbe_ipsec.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c
index 99c0a73..105da11 100644
--- a/drivers/net/ixgbe/ixgbe_ipsec.c
+++ b/drivers/net/ixgbe/ixgbe_ipsec.c
@@ -576,48 +576,48 @@ ixgbe_crypto_capabilities_get(void *device __rte_unused)
 		{ /* IPsec Inline Crypto ESP Transport Egress */
 			.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
 			.protocol = RTE_SECURITY_PROTOCOL_IPSEC,
-			.ipsec = {
+			{.ipsec = {
 				.proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP,
 				.mode = RTE_SECURITY_IPSEC_SA_MODE_TRANSPORT,
 				.direction = RTE_SECURITY_IPSEC_SA_DIR_EGRESS,
 				.options = { 0 }
-			},
+			} },
 			.crypto_capabilities = aes_gcm_gmac_crypto_capabilities,
 			.ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
 		},
 		{ /* IPsec Inline Crypto ESP Transport Ingress */
 			.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
 			.protocol = RTE_SECURITY_PROTOCOL_IPSEC,
-			.ipsec = {
+			{.ipsec = {
 				.proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP,
 				.mode = RTE_SECURITY_IPSEC_SA_MODE_TRANSPORT,
 				.direction = RTE_SECURITY_IPSEC_SA_DIR_INGRESS,
 				.options = { 0 }
-			},
+			} },
 			.crypto_capabilities = aes_gcm_gmac_crypto_capabilities,
 			.ol_flags = 0
 		},
 		{ /* IPsec Inline Crypto ESP Tunnel Egress */
 			.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
 			.protocol = RTE_SECURITY_PROTOCOL_IPSEC,
-			.ipsec = {
+			{.ipsec = {
 				.proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP,
 				.mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL,
 				.direction = RTE_SECURITY_IPSEC_SA_DIR_EGRESS,
 				.options = { 0 }
-			},
+			} },
 			.crypto_capabilities = aes_gcm_gmac_crypto_capabilities,
 			.ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
 		},
 		{ /* IPsec Inline Crypto ESP Tunnel Ingress */
 			.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
 			.protocol = RTE_SECURITY_PROTOCOL_IPSEC,
-			.ipsec = {
+			{.ipsec = {
 				.proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP,
 				.mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL,
 				.direction = RTE_SECURITY_IPSEC_SA_DIR_INGRESS,
 				.options = { 0 }
-			},
+			} },
 			.crypto_capabilities = aes_gcm_gmac_crypto_capabilities,
 			.ol_flags = 0
 		},
-- 
2.7.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] net/ixgbe: fix build on gcc 4.5.1
  2017-11-06 11:36 ` [PATCH v2] " Radu Nicolau
@ 2017-11-07  1:24   ` Thomas Monjalon
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2017-11-07  1:24 UTC (permalink / raw)
  To: Radu Nicolau
  Cc: dev, konstantin.ananyev, bruce.richardson, ferruh.yigit,
	wenzhuo.lu, michael.j.glynn

06/11/2017 12:36, Radu Nicolau:
> Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec")

This Fixes line must be at the end before you SoB.

> On SUSE11 with gcc 4.5.1 the following build error occurred,
> most likely because of improper handling of annonymous unions:
> 
> DPDK/drivers/net/ixgbe/ixgbe_ipsec.c:579:4:
> error: unknown field ‘ipsec’ specified in initializer
> compilation terminated due to -Wfatal-errors.
> 
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-07  1:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-06 10:54 [PATCH] net/ixgbe: fix build on gcc 4.5.1 Radu Nicolau
2017-11-06 11:14 ` Thomas Monjalon
2017-11-06 11:36 ` [PATCH v2] " Radu Nicolau
2017-11-07  1:24   ` Thomas Monjalon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.